From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1628C43381 for ; Wed, 20 Mar 2019 17:04:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8977218A5 for ; Wed, 20 Mar 2019 17:04:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b/1LToRC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727159AbfCTREu (ORCPT ); Wed, 20 Mar 2019 13:04:50 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:44440 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726944AbfCTREu (ORCPT ); Wed, 20 Mar 2019 13:04:50 -0400 Received: by mail-lf1-f68.google.com with SMTP id u9so2423450lfe.11; Wed, 20 Mar 2019 10:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mLVzHO1dIbiYcvX6Ao4KI3q1rS7zqplkW3u9s5kL/oQ=; b=b/1LToRC6Y7HhNjC0aZ158JKVQO1QYTdecoKoyYZ+Bf9TEplws1xTPIWmv56Z4S7Cl xdmhfAb/FI1jbUPwyT8ax4v53EUSNYX9Pa4ekwOO1YY+hhJOqzL07cSLy8Jk68WXtE1A xFVlmSrMtO5vVB+Z6YSBoKkK4Y5CygV/8Sgna/jiy+bdoCySqx3bztLI7lYjkYrBurm0 N4tIelC3wAAiuwOmC9BqvyBOksKLPpSHIXuksEBEK5NuMVJfm3c0XNQg9fOxssWoXEwU xPLxKEh1hJ6dgHMXcE3n5NLd0VfEziDbDXL15dZBqbTqvqx1nu8aujI6f0gizeZf8klD 8xVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mLVzHO1dIbiYcvX6Ao4KI3q1rS7zqplkW3u9s5kL/oQ=; b=aKWC5jHJQHxqrolvz6j7Ue2hzR5f5cRtvi4s6i7Tx/dDptPvGVpCNOze663gBUOU0a k6GA0EpAO6Bl0vvtFK/ezuBxKVCsYSwnwlABKenkDRIsC0REqDCn5VdWyK+Nlt9yHnF4 ySc9DoIJAquaM2Y+v1lcCMHvoTdWAV90rPjmUqD+j/L7SbvXghH5xQNJtTYieLK/rVkg Z/BdPWg0fgR24yjQokgq6ghDi5VZOfHSUF/le/j1O5XgZ5gob7waeKBBbUQtjwR6mk2L jXfs50ofuFXND1hwTKivQWIN5GrIM7LIp8uzyGvGhkkte0kERczOJFUGUuOtKDXKld9A FSRw== X-Gm-Message-State: APjAAAXiLUBPUfPC6764qBqefYzAKqcbiQg6kc11hchGFn0gUFMHm8z9 EQCTRS9vMK/25xeQyn4p5ROnjAQmxa+aKRg/aus= X-Google-Smtp-Source: APXvYqzkzvWroh8DDnyh4XKhK2VCuC5gE5Ma6lT5ARm7z0coUYKawBT7qCGKEa7sxyIua+dvI07vUUFC4l/yzgad5UI= X-Received: by 2002:ac2:4561:: with SMTP id k1mr15865784lfm.95.1553101487397; Wed, 20 Mar 2019 10:04:47 -0700 (PDT) MIME-Version: 1.0 References: <20190320120604.7D99B3FBE9@swsrvapps-01.diasemi.com> In-Reply-To: From: Fabio Estevam Date: Wed, 20 Mar 2019 14:04:42 -0300 Message-ID: Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id To: Steve Twiss , Andrew Lunn Cc: Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , DEVICETREE , LINUX-ARM-KERNEL , LKML , Support Opensource Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steve, [Adding Andrew] On Wed, Mar 20, 2019 at 1:03 PM Steve Twiss wrote: > > Hi Fabio, > > On 20 March 2019 12:17, Fabio Estevam wrote: > > Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id > > > > Hi Steve, > > > > On Wed, Mar 20, 2019 at 9:06 AM Steve Twiss > > wrote: > > > > > > The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as > > > 'rgmii' instead of 'rgmii-id'. Meaning the RX and TX delays that were > > > > This patch declares it as 'rgmii-id', which contradicts the commit log. > > The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as > 'rgmii' instead of 'rgmii-id'. > > Can that be read two ways? > I meant the phy-mode is currently qualified as 'rgmii' instead of what it > should be: 'rgmii-id'. Thanks for the clarification. > > [...] > > > > This patch fixes the network problems seen on the Freescale i.MX6Q/DL > > > > Please provide a Fixes tag. It would be good to know if this fix needs > > to be applied to older kernels. > > I didn't put a Fixes tag in because I find this patch fixes v5.1-rc1 (which I see as broken). > But the patch is not needed in v5.0 because I see that as working. > So didn't see the need for a Cc: stable. It seems we have other boards that need to be fixed and we can not have an old dtb with functional Ethernet with a new kernel. Does anyone know if this issue is AR8031 specific? Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10D1BC43381 for ; Wed, 20 Mar 2019 17:05:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA98D21873 for ; Wed, 20 Mar 2019 17:05:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sYheJ1Hi"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b/1LToRC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA98D21873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=byjN6w3gB2ZQMFb9dvMpjGB30emJLp6UVdgzJMU7vTI=; b=sYheJ1Hi89evFp 3VxyW91pzXStcuVeJbyGJ2onVsz4Jx7Vdjd1KlpOhjwXtGK914hxnI7B2aXLaenlyRLu26FP4wYzM HhUSjIH5sulV4Lxwa/8Ga88bA2z9q3/mTBxk9PcHQ1kgllU7KXT1ZIy6nSmnPLBz/ZWB0CB/oZkFp L2hEdYpdZx3MGY67I64l9XO9Em06FvJI8EWOGlsw/liJzk8W90RHGieICE48qMkiBhvkPf0V7BJFx zgMW3MN/wwbrfowN+v0f4kWQc7tCGDm8s6mKOA+Mxoq6TeR60FlqVLGapAV8jjbm/FzVpKn/BH5dM Vu73N7oSk07Hm28taFnw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6ee9-0002pw-O5; Wed, 20 Mar 2019 17:04:57 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6ee2-0002oh-FS for linux-arm-kernel@lists.infradead.org; Wed, 20 Mar 2019 17:04:55 +0000 Received: by mail-lf1-x144.google.com with SMTP id g7so2454501lfh.10 for ; Wed, 20 Mar 2019 10:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mLVzHO1dIbiYcvX6Ao4KI3q1rS7zqplkW3u9s5kL/oQ=; b=b/1LToRC6Y7HhNjC0aZ158JKVQO1QYTdecoKoyYZ+Bf9TEplws1xTPIWmv56Z4S7Cl xdmhfAb/FI1jbUPwyT8ax4v53EUSNYX9Pa4ekwOO1YY+hhJOqzL07cSLy8Jk68WXtE1A xFVlmSrMtO5vVB+Z6YSBoKkK4Y5CygV/8Sgna/jiy+bdoCySqx3bztLI7lYjkYrBurm0 N4tIelC3wAAiuwOmC9BqvyBOksKLPpSHIXuksEBEK5NuMVJfm3c0XNQg9fOxssWoXEwU xPLxKEh1hJ6dgHMXcE3n5NLd0VfEziDbDXL15dZBqbTqvqx1nu8aujI6f0gizeZf8klD 8xVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mLVzHO1dIbiYcvX6Ao4KI3q1rS7zqplkW3u9s5kL/oQ=; b=OnFclkFJYd+pE56hM0BYpmh2iC37bLXTDZ5SPFwRIk/mbVXH/I/UtmFCpXymy7aCAx /q+cxVnDrtXvIwvvdQx4HVnpof/fxK5GH7gHELLzF07oyrGyfUq5XIqCAyCaTolm+zAK hUEAJ4zUHAa6ZE1fUTakxg0wNaGakpnPnEj3ccTBrfA0EIO4L03vzkYr1WJC/X4SzNeK PTt+BVNHeJFfibyCu/jqr5TIf30+kWW9ahHo98ZnN7kkWSmCDWYFHdd+XhutVN4BIadt EaAj8j3JII37eFwh2tmYVfpqAudonG5auZughcQ7FJJnOdi9pXosETq/UPGZSOMQvtCZ PdAg== X-Gm-Message-State: APjAAAURCtXjSCjHM4bjXFSSsQBuYwxLj5YRLHRZq/I3BzxCUHF7Ocqv BrlFgRNRikfctb19E8MKPq2AVfAYc7wjy6PL4BE= X-Google-Smtp-Source: APXvYqzkzvWroh8DDnyh4XKhK2VCuC5gE5Ma6lT5ARm7z0coUYKawBT7qCGKEa7sxyIua+dvI07vUUFC4l/yzgad5UI= X-Received: by 2002:ac2:4561:: with SMTP id k1mr15865784lfm.95.1553101487397; Wed, 20 Mar 2019 10:04:47 -0700 (PDT) MIME-Version: 1.0 References: <20190320120604.7D99B3FBE9@swsrvapps-01.diasemi.com> In-Reply-To: From: Fabio Estevam Date: Wed, 20 Mar 2019 14:04:42 -0300 Message-ID: Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id To: Steve Twiss , Andrew Lunn X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190320_100450_541283_B463715C X-CRM114-Status: GOOD ( 18.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DEVICETREE , Support Opensource , Sascha Hauer , LKML , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , LINUX-ARM-KERNEL Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Steve, [Adding Andrew] On Wed, Mar 20, 2019 at 1:03 PM Steve Twiss wrote: > > Hi Fabio, > > On 20 March 2019 12:17, Fabio Estevam wrote: > > Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id > > > > Hi Steve, > > > > On Wed, Mar 20, 2019 at 9:06 AM Steve Twiss > > wrote: > > > > > > The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as > > > 'rgmii' instead of 'rgmii-id'. Meaning the RX and TX delays that were > > > > This patch declares it as 'rgmii-id', which contradicts the commit log. > > The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as > 'rgmii' instead of 'rgmii-id'. > > Can that be read two ways? > I meant the phy-mode is currently qualified as 'rgmii' instead of what it > should be: 'rgmii-id'. Thanks for the clarification. > > [...] > > > > This patch fixes the network problems seen on the Freescale i.MX6Q/DL > > > > Please provide a Fixes tag. It would be good to know if this fix needs > > to be applied to older kernels. > > I didn't put a Fixes tag in because I find this patch fixes v5.1-rc1 (which I see as broken). > But the patch is not needed in v5.0 because I see that as working. > So didn't see the need for a Cc: stable. It seems we have other boards that need to be fixed and we can not have an old dtb with functional Ethernet with a new kernel. Does anyone know if this issue is AR8031 specific? Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel