From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E82B63D6 for ; Mon, 21 Nov 2022 18:18:51 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id f3so11904494pgc.2 for ; Mon, 21 Nov 2022 10:18:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+on0BIC3CWKsQ/zQgT7Zq7kaAAA97DJzG1xxvLCYCd0=; b=Y2s0QwXYrb3JZrFrFOem8gxmiYnaXcD53JwjtTM5LgVmhPSgCom9h6ZoSMmFC8EWVX ydMHZcweTpXZyt2CHQhQ40CDwQNLJs70jFsGZlp9wzZ17FSg0DZtTdWCvNXTJQ43Xc6Z qHp6p6sn1SOzrTC1s+ktxqpx28mB7O3KrQ5t7/2JEMdXCQw/ucP5sYtbUxudMJtvR/2x xvDIz3Y9dTEPRVM2McBBEfPfpnvb2rGw2w0pc2p8DRQwML8/0yk9rvpR6QGB+IOq7plS 2krvaNLFAOfEsiW8MP1iLUyRS+OgM4z2RhvigUKReEn3dHZ9JJ4kQHRUsrFeyBp8cD7F NEjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+on0BIC3CWKsQ/zQgT7Zq7kaAAA97DJzG1xxvLCYCd0=; b=H04gOQCygIcxlFskuOp7P7T7iB5jwZ1FZ/B4rohDuAzJ2Y/9HAnqjHYXVc9K6ygpST Y6qmVpef4EYc7k1EA1Pl/OKSgfSUUWpjfsE3PFpqeDA4LUVbeWu0Mn2BWJSmkWm4tHNA MwMloFFc++gZVPs/dWieODsaqG2896Xq2Ghs+H5PsQUPVvQzANsryta8LSNDozFMQjdk a0sLV1pQ9SME16+8TxXRY0TXcSuOhX+hQRfdMA4lqR469Z56PIpG6djIX9Dw63CnDj8s Jir8yH5Kk11V20FICYkisD6gNZ0ozyhfIxK4wou7AmfF26AUKgCEF9bsrJbEsZYsRhNA 2Xfg== X-Gm-Message-State: ANoB5pk7Z34Dl/2XJ45HX9aG/20MA1Icell+euq9lkH67/sBhxpdciAX d6FangzN58LPGAYC+oLFzslk6kfHuLzDECc9qIQ= X-Google-Smtp-Source: AA0mqf7LqN1T/OFto2jVhaNxZ2yGDqc/xRjAOptQIyQmYXhv8nQeAlkd38TMX7ofEDomjM8uh4mAaGxiaYXcFihRecU= X-Received: by 2002:a63:2f46:0:b0:477:4a13:f38e with SMTP id v67-20020a632f46000000b004774a13f38emr2304423pgv.131.1669054730967; Mon, 21 Nov 2022 10:18:50 -0800 (PST) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20221103-upstream-goodix-reset-v2-0-2c38fb03a300@theobroma-systems.com> <20221103-upstream-goodix-reset-v2-5-2c38fb03a300@theobroma-systems.com> In-Reply-To: <20221103-upstream-goodix-reset-v2-5-2c38fb03a300@theobroma-systems.com> From: Fabio Estevam Date: Mon, 21 Nov 2022 15:18:32 -0300 Message-ID: Subject: Re: [PATCH RFC v2 5/7] arm64: dts: imx: fix touchscreen reset GPIO polarity To: Quentin Schulz , "Angus Ainslie (Purism)" , David Jander Cc: Shawn Guo , Krzysztof Kozlowski , Heiko Stuebner , Samuel Holland , Bjorn Andersson , Konrad Dybcio , Jernej Skrabec , Bastien Nocera , Chen-Yu Tsai , Sascha Hauer , Pengutronix Kernel Team , Hans de Goede , Andy Gross , Rob Herring , NXP Linux Team , Dmitry Torokhov , Quentin Schulz , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" [Adding Angus and David] On Mon, Nov 21, 2022 at 3:12 PM Quentin Schulz wrote: > > From: Quentin Schulz > > The reset line is active low for the Goodix touchscreen controller so > let's fix the polarity in the Device Tree node. > > Signed-off-by: Quentin Schulz > --- > arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts | 2 +- > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts b/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts > index 9fbbbb556c0b3..df7e5ae9698e1 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts > @@ -107,7 +107,7 @@ touchscreeen@5d { > interrupt-parent = <&gpio1>; > interrupts = <8 IRQ_TYPE_NONE>; > irq-gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>; > - reset-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>; > }; > > temp-sense@70 { > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > index 6445c6b90b5bb..b038300812b1e 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > @@ -542,7 +542,7 @@ touchscreen@5d { > pinctrl-0 = <&pinctrl_ts>; > interrupt-parent = <&gpio3>; > interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > - reset-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio1 5 GPIO_ACTIVE_LOW>; > irq-gpios = <&gpio3 0 GPIO_ACTIVE_HIGH>; > touchscreen-size-x = <720>; > touchscreen-size-y = <1440>; > > -- > b4 0.10.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A50BC433FE for ; Mon, 21 Nov 2022 18:19:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qMaX5f2+lo///iwvSNC4ZZekfR5RoF/zYC986rPUybs=; b=qjgH30Hw5mNyZs /X+gUb+bBbU69wamRDjXXFfSjrQi1ZtVa9Sm6/23G0Zv7GQZ2CchzfGYE2YgHc9A3vOXEUatTXGm4 9ul6NiPKJBdcbTJCRpGykUPrZdInpGt11owSHa4/OuKUzkAfdTjUl0IaMNLU3Q/lqm4EUTE0g5uRw 2zx5ej0Wce3mX0ZR7bjbIxeud60GRrKgIh1XOSTI8/lC8sbz9VvpsKQtYXVu4fuObzaUEzd2/pMi1 /dNDvRLH/f3/4fX/T6zIAIKh1gSKoZH/nO6PxX7X9OqD2OTK2z1dcPOl/sjxN6qSQm3IyIywORasT kSxt4THrRR/KLe7LSlyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxBNe-00GnTQ-0O; Mon, 21 Nov 2022 18:18:54 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxBNb-00GnSi-NJ; Mon, 21 Nov 2022 18:18:53 +0000 Received: by mail-pg1-x531.google.com with SMTP id 130so11888267pgc.5; Mon, 21 Nov 2022 10:18:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+on0BIC3CWKsQ/zQgT7Zq7kaAAA97DJzG1xxvLCYCd0=; b=Y2s0QwXYrb3JZrFrFOem8gxmiYnaXcD53JwjtTM5LgVmhPSgCom9h6ZoSMmFC8EWVX ydMHZcweTpXZyt2CHQhQ40CDwQNLJs70jFsGZlp9wzZ17FSg0DZtTdWCvNXTJQ43Xc6Z qHp6p6sn1SOzrTC1s+ktxqpx28mB7O3KrQ5t7/2JEMdXCQw/ucP5sYtbUxudMJtvR/2x xvDIz3Y9dTEPRVM2McBBEfPfpnvb2rGw2w0pc2p8DRQwML8/0yk9rvpR6QGB+IOq7plS 2krvaNLFAOfEsiW8MP1iLUyRS+OgM4z2RhvigUKReEn3dHZ9JJ4kQHRUsrFeyBp8cD7F NEjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+on0BIC3CWKsQ/zQgT7Zq7kaAAA97DJzG1xxvLCYCd0=; b=1rjZcKbeWpNhqUVsWPohO2Dh9g7yQcgA+3g3hs8rdbz4Ao3Yad+cTvlCK1afW6S4q6 /lFazpFB+5u/OuCnqrMGZc8k1yvuLu/1EVMs2QEn1bI0JiRGgyqLYjYoMR/ANm4eL6pr zAITvKfgzljdtImdoBqUEMHn/HjhPjJzl7drNmn68SyTuT0HYlo8/LZJdddadWVkdy01 4pzG+EQ5rZkdd3lAzCdjv7xrZ0Vs/h4dcEUQFGNgkDfm4j6V/tlp24lDxqA0MFcbv/bK 3a2I2SB33ET6tc8Jj3oDZTk/ga7jVxsVXdB3rlOsA9jRBUKQMmye/ITsLoVJuleIMQgG //Kg== X-Gm-Message-State: ANoB5pl7EwLQUCTDRCJZy48VqPw7ePXiDbfeFqdlwm5108liBK9Rrs7K r3tMammErASsR5sGFDwaWzRRpOqyTxXxTajmuyg= X-Google-Smtp-Source: AA0mqf7LqN1T/OFto2jVhaNxZ2yGDqc/xRjAOptQIyQmYXhv8nQeAlkd38TMX7ofEDomjM8uh4mAaGxiaYXcFihRecU= X-Received: by 2002:a63:2f46:0:b0:477:4a13:f38e with SMTP id v67-20020a632f46000000b004774a13f38emr2304423pgv.131.1669054730967; Mon, 21 Nov 2022 10:18:50 -0800 (PST) MIME-Version: 1.0 References: <20221103-upstream-goodix-reset-v2-0-2c38fb03a300@theobroma-systems.com> <20221103-upstream-goodix-reset-v2-5-2c38fb03a300@theobroma-systems.com> In-Reply-To: <20221103-upstream-goodix-reset-v2-5-2c38fb03a300@theobroma-systems.com> From: Fabio Estevam Date: Mon, 21 Nov 2022 15:18:32 -0300 Message-ID: Subject: Re: [PATCH RFC v2 5/7] arm64: dts: imx: fix touchscreen reset GPIO polarity To: Quentin Schulz , "Angus Ainslie (Purism)" , David Jander Cc: Shawn Guo , Krzysztof Kozlowski , Heiko Stuebner , Samuel Holland , Bjorn Andersson , Konrad Dybcio , Jernej Skrabec , Bastien Nocera , Chen-Yu Tsai , Sascha Hauer , Pengutronix Kernel Team , Hans de Goede , Andy Gross , Rob Herring , NXP Linux Team , Dmitry Torokhov , Quentin Schulz , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_101851_803824_E75008F0 X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org [Adding Angus and David] On Mon, Nov 21, 2022 at 3:12 PM Quentin Schulz wrote: > > From: Quentin Schulz > > The reset line is active low for the Goodix touchscreen controller so > let's fix the polarity in the Device Tree node. > > Signed-off-by: Quentin Schulz > --- > arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts | 2 +- > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts b/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts > index 9fbbbb556c0b3..df7e5ae9698e1 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts > @@ -107,7 +107,7 @@ touchscreeen@5d { > interrupt-parent = <&gpio1>; > interrupts = <8 IRQ_TYPE_NONE>; > irq-gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>; > - reset-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>; > }; > > temp-sense@70 { > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > index 6445c6b90b5bb..b038300812b1e 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > @@ -542,7 +542,7 @@ touchscreen@5d { > pinctrl-0 = <&pinctrl_ts>; > interrupt-parent = <&gpio3>; > interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > - reset-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio1 5 GPIO_ACTIVE_LOW>; > irq-gpios = <&gpio3 0 GPIO_ACTIVE_HIGH>; > touchscreen-size-x = <720>; > touchscreen-size-y = <1440>; > > -- > b4 0.10.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94431C433FE for ; Mon, 21 Nov 2022 18:19:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P61jzZP8Zn072Ty26Bs4vDP0ol3chBgywkA0FECNeCI=; b=R8++9NJY9D1RWz 1kd4M5TWsXL4hLcaf8s8t1ntWu6ruK0duOxjHOh7CVINjDbE+OUNVYcfBzXZwTn8durxJq0/Zj1lv NZfMH6Z6yIe4cqyuxl61w3by/22FYZqfeIuVIPcEUBD3DctPBsZStDLVqi3T8LC5t8hHqT+CNlw61 rxHpX+9PBynVUlH1nhWuSNg2/D2kxl+ssCgoGRMI5uYNb16CmQWsDcmHaDJDLYHlu2VUfG5ySVR9K 3bP9MrkkFnMsbC/MPvTNzQPyKAnaXAOQzRnbyZggIDVSuEjaGRbk1Y+Y4lO47diRb40FA5djRC+Yu k9fzNf+jkLaAX5jlp+zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxBNe-00GnTY-Lb; Mon, 21 Nov 2022 18:18:54 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxBNb-00GnSi-NJ; Mon, 21 Nov 2022 18:18:53 +0000 Received: by mail-pg1-x531.google.com with SMTP id 130so11888267pgc.5; Mon, 21 Nov 2022 10:18:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+on0BIC3CWKsQ/zQgT7Zq7kaAAA97DJzG1xxvLCYCd0=; b=Y2s0QwXYrb3JZrFrFOem8gxmiYnaXcD53JwjtTM5LgVmhPSgCom9h6ZoSMmFC8EWVX ydMHZcweTpXZyt2CHQhQ40CDwQNLJs70jFsGZlp9wzZ17FSg0DZtTdWCvNXTJQ43Xc6Z qHp6p6sn1SOzrTC1s+ktxqpx28mB7O3KrQ5t7/2JEMdXCQw/ucP5sYtbUxudMJtvR/2x xvDIz3Y9dTEPRVM2McBBEfPfpnvb2rGw2w0pc2p8DRQwML8/0yk9rvpR6QGB+IOq7plS 2krvaNLFAOfEsiW8MP1iLUyRS+OgM4z2RhvigUKReEn3dHZ9JJ4kQHRUsrFeyBp8cD7F NEjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+on0BIC3CWKsQ/zQgT7Zq7kaAAA97DJzG1xxvLCYCd0=; b=1rjZcKbeWpNhqUVsWPohO2Dh9g7yQcgA+3g3hs8rdbz4Ao3Yad+cTvlCK1afW6S4q6 /lFazpFB+5u/OuCnqrMGZc8k1yvuLu/1EVMs2QEn1bI0JiRGgyqLYjYoMR/ANm4eL6pr zAITvKfgzljdtImdoBqUEMHn/HjhPjJzl7drNmn68SyTuT0HYlo8/LZJdddadWVkdy01 4pzG+EQ5rZkdd3lAzCdjv7xrZ0Vs/h4dcEUQFGNgkDfm4j6V/tlp24lDxqA0MFcbv/bK 3a2I2SB33ET6tc8Jj3oDZTk/ga7jVxsVXdB3rlOsA9jRBUKQMmye/ITsLoVJuleIMQgG //Kg== X-Gm-Message-State: ANoB5pl7EwLQUCTDRCJZy48VqPw7ePXiDbfeFqdlwm5108liBK9Rrs7K r3tMammErASsR5sGFDwaWzRRpOqyTxXxTajmuyg= X-Google-Smtp-Source: AA0mqf7LqN1T/OFto2jVhaNxZ2yGDqc/xRjAOptQIyQmYXhv8nQeAlkd38TMX7ofEDomjM8uh4mAaGxiaYXcFihRecU= X-Received: by 2002:a63:2f46:0:b0:477:4a13:f38e with SMTP id v67-20020a632f46000000b004774a13f38emr2304423pgv.131.1669054730967; Mon, 21 Nov 2022 10:18:50 -0800 (PST) MIME-Version: 1.0 References: <20221103-upstream-goodix-reset-v2-0-2c38fb03a300@theobroma-systems.com> <20221103-upstream-goodix-reset-v2-5-2c38fb03a300@theobroma-systems.com> In-Reply-To: <20221103-upstream-goodix-reset-v2-5-2c38fb03a300@theobroma-systems.com> From: Fabio Estevam Date: Mon, 21 Nov 2022 15:18:32 -0300 Message-ID: Subject: Re: [PATCH RFC v2 5/7] arm64: dts: imx: fix touchscreen reset GPIO polarity To: Quentin Schulz , "Angus Ainslie (Purism)" , David Jander Cc: Shawn Guo , Krzysztof Kozlowski , Heiko Stuebner , Samuel Holland , Bjorn Andersson , Konrad Dybcio , Jernej Skrabec , Bastien Nocera , Chen-Yu Tsai , Sascha Hauer , Pengutronix Kernel Team , Hans de Goede , Andy Gross , Rob Herring , NXP Linux Team , Dmitry Torokhov , Quentin Schulz , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_101851_803824_E75008F0 X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [Adding Angus and David] On Mon, Nov 21, 2022 at 3:12 PM Quentin Schulz wrote: > > From: Quentin Schulz > > The reset line is active low for the Goodix touchscreen controller so > let's fix the polarity in the Device Tree node. > > Signed-off-by: Quentin Schulz > --- > arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts | 2 +- > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts b/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts > index 9fbbbb556c0b3..df7e5ae9698e1 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts > @@ -107,7 +107,7 @@ touchscreeen@5d { > interrupt-parent = <&gpio1>; > interrupts = <8 IRQ_TYPE_NONE>; > irq-gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>; > - reset-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>; > }; > > temp-sense@70 { > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > index 6445c6b90b5bb..b038300812b1e 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > @@ -542,7 +542,7 @@ touchscreen@5d { > pinctrl-0 = <&pinctrl_ts>; > interrupt-parent = <&gpio3>; > interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > - reset-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio1 5 GPIO_ACTIVE_LOW>; > irq-gpios = <&gpio3 0 GPIO_ACTIVE_HIGH>; > touchscreen-size-x = <720>; > touchscreen-size-y = <1440>; > > -- > b4 0.10.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel