From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3087C433EF for ; Tue, 16 Nov 2021 11:46:25 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3F7061041 for ; Tue, 16 Nov 2021 11:46:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B3F7061041 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6FAF88380F; Tue, 16 Nov 2021 12:37:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gSPmH+rL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2742A8380C; Tue, 16 Nov 2021 12:37:23 +0100 (CET) Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com [IPv6:2607:f8b0:4864:20::935]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1394C8380F for ; Tue, 16 Nov 2021 12:37:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-ua1-x935.google.com with SMTP id l24so37366700uak.2 for ; Tue, 16 Nov 2021 03:37:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r0rBGXjVlPaB6D1ntHJR9V6O3Dsy6LyGmVCuggnb3Ms=; b=gSPmH+rLCeavifgU2Jkb+2RPsBrXw+Yz/v814TdsYyP704M5E1W2DtTrm0O30jwpbc 0792il7nQL4dAWs9+mUX2mzpyCcLuQto6yFRlmgWVYQp60pwpgMxTUl754353na8LX19 /MotKqeGUcIHZUF/ujRMyC32ZR2OXyYZvbMflCj30DySee3Y+iKMaBKHJeNd0frssTrO GJFA7ULbp5IRuZDuWx4P0eazD4kjEs1dDOqvVRIsVziJZSngEUFFyKeMIAtCK+4R4Xy3 kac0sKlGLcONqhTpax7gpDGd5FlnVJwQsmxI/ob68kPCgl5Wdgk5DMT4xjrOegRZLQMu 0s2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r0rBGXjVlPaB6D1ntHJR9V6O3Dsy6LyGmVCuggnb3Ms=; b=mF8RKAB3xpSVLH0/nsNuOoGyG/pu3p3iqFNJx377IR/ZTZsieoEzAOcAU50xvJxamz y/W+MedF9P9S/cwKvxhDBxHMKqLv73u/uyRue482waGSRdg8CNSp4PFEG3AsZOJeRRZk N9+tBrNYU2Vf4BQoP3Sl1zr/aVqw/0Kl7VwdOFEtDULTb8Acl9XnCt74nKzJk4tqi6xN Rn1dfExrDbIZTWK7fn69eurfyWqjo6xTDGR9UJujqjd4BhxZAHLq7AKHoANGa1ULrwMq F1AZpC5EQHRCk8aQozsqAhXqhJZ8ZtMvuldsDXH326G0lMJg7mZN4VMdetLxjJvcOcd5 K7qA== X-Gm-Message-State: AOAM530mxdTeV0eKLRm/iQaG79Flp+5CrQug8BmzZRAEkxNuO9r1Ktm+ /qWYMVWHw28CeOWWj4IgJFKfJhUnBipTYsANEe4= X-Google-Smtp-Source: ABdhPJynk/OJEBxjkVK1BEgogmzS2kHZg7Bm4vLqg8I7mEGGyoLt3Tlz8btYD/NXps3dslrdVfueiRIm+0/1SeSozF0= X-Received: by 2002:ab0:39cb:: with SMTP id g11mr9828798uaw.53.1637062637615; Tue, 16 Nov 2021 03:37:17 -0800 (PST) MIME-Version: 1.0 References: <20211116035055.1194673-1-ariel.dalessandro@collabora.com> <20211116035055.1194673-2-ariel.dalessandro@collabora.com> In-Reply-To: <20211116035055.1194673-2-ariel.dalessandro@collabora.com> From: Fabio Estevam Date: Tue, 16 Nov 2021 08:37:06 -0300 Message-ID: Subject: Re: [PATCH v3 1/1] imx8mn_var_som: Add support for Variscite VAR-SOM-MX8M-NANO board To: "Ariel D'Alessandro" Cc: U-Boot-Denx , dl-uboot-imx , Adam Ford , Andre Przywara , ZHIZHIKIN Andrey , Christian Hewitt , Heiko Schocher , Ilko Iliev , Jagan Teki , Marcel Ziswiler , Neil Armstrong , Patrick Delaunay , Peter Robinson , Peng Fan , Rick Chen , Stefano Babic , Sean Anderson , Simon Glass , Teresa Remmet , Tim Harvey , Tom Rini Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Ariel, The patch looks good. Only some minor comments: On Tue, Nov 16, 2021 at 12:51 AM Ariel D'Alessandro wrote: > > Add support for iMX8MN VAR-SOM-MX8M-NANO board. Enables support for: > > - 1GiB DDR4 RAM > - 16 GiB eMMC > - SD card > - Gigabit ethernet > - USBOTG1 peripheral - fastboot > > Signed-off-by: Ariel D'Alessandro It would be nice to have a README file so that the users can know how to build and flash mainline U-Boot in this board. > +#define PHYS_SDRAM 0x40000000 > +#define PHYS_SDRAM_SIZE SZ_1G /* 1GB DDR */ > + > +#define CONFIG_BAUDRATE 115200 This is the default. No need to be specified here. > +#define CONFIG_MXC_UART_BASE UART4_BASE_ADDR > + > +/* Monitor Command Prompt */ > +#define CONFIG_SYS_CBSIZE SZ_2K > +#define CONFIG_SYS_MAXARGS 64 > +#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE > +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ > + sizeof(CONFIG_SYS_PROMPT) + 16) > + > +/* USDHC */ > +#define CONFIG_FSL_USDHC This should be placed in defconfig. > +#define CONFIG_SYS_FSL_USDHC_NUM 2 This is not used. Please remove it.