Re: iMX8MM USB support?

From: Fabio Estevam <festevam@gmail.com>
To: Tim Harvey <tharvey@gateworks.com>
Cc: Schrempf Frieder <frieder.schrempf@kontron.de>,
	u-boot <u-boot@lists.denx.de>, Peng Fan <Peng.Fan@nxp.com>
Subject: Re: iMX8MM USB support?
Date: Thu, 1 Jul 2021 21:56:02 -0300	[thread overview]
Message-ID: <CAOMZO5CBGDigz+ceqXLYQO8qG=p_1jh0zBj+VUdJjkG+rQv=5Q@mail.gmail.com> (raw)
In-Reply-To: <CAJ+vNU1zQPJ_K7nCDWyP3Dp9rypj0jiez3iNjS-tTc2hAAfA1A@mail.gmail.com>

Hi Tim,

On Thu, Jul 1, 2021 at 9:49 PM Tim Harvey <tharvey@gateworks.com> wrote:

> Yes, this works on my board. I just sent a v2 of these patches (cc'd you).

I have just tried "ums 0 mmc 1" and it works on a imx8mm-evk now after
applying your patches, thanks!

> By the way, I took a quick stab at enabling SDP on
> imx8mm-venice-gw73xx-0x and found compile issues so I configured for
> an imx8mm_evk using your diffs and hit the same issues.
>
> drivers/usb/host/ehci-mx6.c: In function ‘ehci_hcd_init’:
> drivers/usb/host/ehci-mx6.c:360:46: error: ‘USB_BASE_ADDR’ undeclared
> (first use in this function); did you mean ‘SRC_BASE_ADDR’?
>   struct usb_ehci *ehci = (struct usb_ehci *)(USB_BASE_ADDR +
>                                               ^~~~~~~~~~~~~
>                                               SRC_BASE_ADDR
> drivers/usb/host/ehci-mx6.c:360:46: note: each undeclared identifier
> is reported only once for each function it appears in
> drivers/usb/host/ehci-mx6.c:361:4: error: ‘controller_spacing’
> undeclared (first use in this function); did you mean ‘console_start’?
>    (controller_spacing * index));
>     ^~~~~~~~~~~~~~~~~~
> ...
>
> The above is resolved with CONFIG_DM_USB=y and CONFIG_SPL_DM_USB=y
>
> After enabling those I just run into other issues with things such as:
> WARNING 'mkimage.flash.mkimage' not found, resulting binary is not-functional
>  ...
> aarch64-linux-ld.bfd: cmd/nvedit.o: in function `env_match':
> /usr/src/venice/uboot-master/cmd/nvedit.c:824: undefined reference to
> `env_get_char'
> aarch64-linux-ld.bfd: /usr/src/venice/uboot-master/cmd/nvedit.c:828:
> undefined reference to `env_get_char'
> ...
>
> What branch were you working with here? I tried the above with v2021.07-rc5

I am also testing against 2021.07-rc5.

Please see the complete diff (your patches + imx8mm_evk defconfig
changes against 2021.07-rc5):
https://pastebin.com/raw/BtCD0xat

Now the missing part is SDP. Hopefully we can get SDK working too.

Thanks!