From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755742AbaFBPSg (ORCPT ); Mon, 2 Jun 2014 11:18:36 -0400 Received: from mail-ve0-f181.google.com ([209.85.128.181]:55334 "EHLO mail-ve0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328AbaFBPSf (ORCPT ); Mon, 2 Jun 2014 11:18:35 -0400 MIME-Version: 1.0 In-Reply-To: <538C8B45.6070803@suse.cz> References: <1399904111-23520-1-git-send-email-vbabka@suse.cz> <1400233673-11477-1-git-send-email-vbabka@suse.cz> <537F082F.50501@suse.cz> <538C8B45.6070803@suse.cz> Date: Mon, 2 Jun 2014 12:18:34 -0300 Message-ID: Subject: Re: [PATCH -mm] mm, compaction: properly signal and act upon lock and need_sched() contention - fix From: Fabio Estevam To: Vlastimil Babka Cc: Andrew Morton , Shawn Guo , Kevin Hilman , Rik van Riel , Stephen Warren , Minchan Kim , Bartlomiej Zolnierkiewicz , Hugh Dickins , LKML , Michal Nazarewicz , linux-mm@kvack.org, Mel Gorman , David Rientjes , Olof Johansson , Greg Thelen , Joonsoo Kim , Christoph Lameter , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 2, 2014 at 11:33 AM, Vlastimil Babka wrote: > compact_should_abort() returns true instead of false and vice versa > due to changes between v1 and v2 of the patch. This makes both async > and sync compaction abort with high probability, and has been reported > to cause e.g. soft lockups on some ARM boards, or drivers calling > dma_alloc_coherent() fail to probe with CMA enabled on different boards. > > This patch fixes the return value to match comments and callers expecations. > > Reported-and-tested-by: Kevin Hilman > Reported-and-tested-by: Shawn Guo > Tested-by: Stephen Warren > Signed-off-by: Vlastimil Babka Tested-by: Fabio Estevam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by kanga.kvack.org (Postfix) with ESMTP id 025106B0037 for ; Mon, 2 Jun 2014 11:18:35 -0400 (EDT) Received: by mail-vc0-f173.google.com with SMTP id ik5so2356520vcb.32 for ; Mon, 02 Jun 2014 08:18:35 -0700 (PDT) Received: from mail-ve0-x233.google.com (mail-ve0-x233.google.com [2607:f8b0:400c:c01::233]) by mx.google.com with ESMTPS id 5si8018628vdy.104.2014.06.02.08.18.35 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 02 Jun 2014 08:18:35 -0700 (PDT) Received: by mail-ve0-f179.google.com with SMTP id oy12so5298799veb.24 for ; Mon, 02 Jun 2014 08:18:35 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <538C8B45.6070803@suse.cz> References: <1399904111-23520-1-git-send-email-vbabka@suse.cz> <1400233673-11477-1-git-send-email-vbabka@suse.cz> <537F082F.50501@suse.cz> <538C8B45.6070803@suse.cz> Date: Mon, 2 Jun 2014 12:18:34 -0300 Message-ID: Subject: Re: [PATCH -mm] mm, compaction: properly signal and act upon lock and need_sched() contention - fix From: Fabio Estevam Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka Cc: Andrew Morton , Shawn Guo , Kevin Hilman , Rik van Riel , Stephen Warren , Minchan Kim , Bartlomiej Zolnierkiewicz , Hugh Dickins , LKML , Michal Nazarewicz , linux-mm@kvack.org, Mel Gorman , David Rientjes , Olof Johansson , Greg Thelen , Joonsoo Kim , Christoph Lameter , linux-arm-kernel On Mon, Jun 2, 2014 at 11:33 AM, Vlastimil Babka wrote: > compact_should_abort() returns true instead of false and vice versa > due to changes between v1 and v2 of the patch. This makes both async > and sync compaction abort with high probability, and has been reported > to cause e.g. soft lockups on some ARM boards, or drivers calling > dma_alloc_coherent() fail to probe with CMA enabled on different boards. > > This patch fixes the return value to match comments and callers expecations. > > Reported-and-tested-by: Kevin Hilman > Reported-and-tested-by: Shawn Guo > Tested-by: Stephen Warren > Signed-off-by: Vlastimil Babka Tested-by: Fabio Estevam -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: festevam@gmail.com (Fabio Estevam) Date: Mon, 2 Jun 2014 12:18:34 -0300 Subject: [PATCH -mm] mm, compaction: properly signal and act upon lock and need_sched() contention - fix In-Reply-To: <538C8B45.6070803@suse.cz> References: <1399904111-23520-1-git-send-email-vbabka@suse.cz> <1400233673-11477-1-git-send-email-vbabka@suse.cz> <537F082F.50501@suse.cz> <538C8B45.6070803@suse.cz> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jun 2, 2014 at 11:33 AM, Vlastimil Babka wrote: > compact_should_abort() returns true instead of false and vice versa > due to changes between v1 and v2 of the patch. This makes both async > and sync compaction abort with high probability, and has been reported > to cause e.g. soft lockups on some ARM boards, or drivers calling > dma_alloc_coherent() fail to probe with CMA enabled on different boards. > > This patch fixes the return value to match comments and callers expecations. > > Reported-and-tested-by: Kevin Hilman > Reported-and-tested-by: Shawn Guo > Tested-by: Stephen Warren > Signed-off-by: Vlastimil Babka Tested-by: Fabio Estevam