From mboxrd@z Thu Jan  1 00:00:00 1970
From: Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v7 05/20] usb: phy: msm: Migrate to Managed Device
 Resource allocation
Date: Thu, 24 Apr 2014 13:49:38 -0300
Message-ID: <CAOMZO5COKimLjC0oYqgwSaEvSBUpoy9aP_P-ScU+ozh0KpsCoA@mail.gmail.com>
References: <1398354495-20782-1-git-send-email-iivanov@mm-sol.com>
	<1398354495-20782-6-git-send-email-iivanov@mm-sol.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1398354495-20782-6-git-send-email-iivanov@mm-sol.com>
Sender: linux-kernel-owner@vger.kernel.org
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, USB list <linux-usb@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-arm-msm@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org

On Thu, Apr 24, 2014 at 12:48 PM, Ivan T. Ivanov <iivanov@mm-sol.com> wrote:

> +       motg->vddcx = devm_regulator_get(motg->phy.dev, "HSUSB_VDDCX");
> +       if (IS_ERR(motg->vddcx)) {
> +               dev_err(motg->phy.dev, "unable to get hsusb vddcx\n");
> +               return PTR_ERR(motg->vddcx);
> +       }
> +
> +       motg->v3p3 = devm_regulator_get(motg->phy.dev, "HSUSB_3p3");
> +       if (IS_ERR(motg->v3p3)) {
> +               dev_err(motg->phy.dev, "unable to get hsusb 3p3\n");
> +               return PTR_ERR(motg->v3p3);
> +       }
> +
> +       motg->v1p8 = devm_regulator_get(motg->phy.dev, "HSUSB_1p8");
> +       if (IS_ERR(motg->v1p8)) {
> +               dev_err(motg->phy.dev, "unable to get hsusb 1p8\n");
> +               return PTR_ERR(motg->v1p8);
> +       }

It seems that calling devm_regulator_bulk_get() here would simplify
the code here.