From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Date: Mon, 17 Apr 2017 12:00:11 -0300 Subject: [U-Boot] [PATCH V2 12/12] imx: mx7dsabresd: add board revision check In-Reply-To: <1492063800-17290-12-git-send-email-peng.fan@nxp.com> References: <1492063800-17290-1-git-send-email-peng.fan@nxp.com> <1492063800-17290-12-git-send-email-peng.fan@nxp.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Apr 13, 2017 at 3:10 AM, Peng Fan wrote: > +#define BOARD_REV_C 0x300 > +#define BOARD_REV_B 0x200 > +#define BOARD_REV_A 0x100 > + > +static int mx7sabre_rev(void) > +{ > + /* > + * Get Board ID information from OCOTP_GP1[15:8] > + * i.MX7D SDB RevA: 0x41 > + * i.MX7D SDB RevB: 0x42 Isn't this versioning scheme shared with other NXP boards? If so, it would be better to put this in common code.