All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] imx6q-sabresd: Add a qt5 defconfig variant
Date: Mon, 21 Aug 2017 12:40:18 -0300	[thread overview]
Message-ID: <CAOMZO5Cb2RxwAfm8n8-gXe9_4j2qkEhztX1XYktF3LnZbtC2Kg@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5ACVkLqxWmwFY3kBPjhPVOVs0J_Tq__jZJ29_YFXBFjHw@mail.gmail.com>

Hi Arnout,

On Thu, Aug 3, 2017 at 4:49 PM, Fabio Estevam <festevam@gmail.com> wrote:

>>  Could you re-test based on the next branch?
>
> Thanks for reworking the patch and applying it.
>
> I am currently out of the office without hardware access to test it.
>
> Will test it as soon as I am back to the office (week of August 21)

I was able to test it and can confirm that it works as expected.

>>  Also, you set BR2_TOOLCHAIN_BUILDROOT_GLIBC=y but none of the packages selected
>> seem to need it. Is there a reason why it is needed? Could you either remove it
>> (after testing with uClibc-ng) or add a comment why it is needed and remove
>> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y?
>
> Sure, will do it.

I tried the following change:

--- a/configs/imx6q-sabresd_qt5_defconfig
+++ b/configs/imx6q-sabresd_qt5_defconfig
@@ -8,9 +8,7 @@ BR2_ARM_FPU_VFPV3=y
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_11=y

 # Additional features needed for packages
-BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
 BR2_TOOLCHAIN_BUILDROOT_CXX=y
-BR2_TOOLCHAIN_BUILDROOT_GLIBC=y

 # System

,but in this case the Qt5 package is not installed anymore.

  reply	other threads:[~2017-08-21 15:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21 20:49 [Buildroot] [PATCH v3] imx6q-sabresd: Add a qt5 defconfig variant Fabio Estevam
2017-07-11 13:44 ` Fabio Estevam
2017-07-25  1:43   ` Fabio Estevam
2017-08-03  7:06 ` Arnout Vandecappelle
2017-08-03 19:49   ` Fabio Estevam
2017-08-21 15:40     ` Fabio Estevam [this message]
2017-08-21 16:26       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5Cb2RxwAfm8n8-gXe9_4j2qkEhztX1XYktF3LnZbtC2Kg@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.