From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Subject: Re: [PATCH v2 06/15] arm64: dts: imx8: add adma lpcg clocks Date: Tue, 16 Jul 2019 16:28:22 -0300 Message-ID: References: <1563290089-11085-1-git-send-email-aisheng.dong@nxp.com> <1563290089-11085-7-git-send-email-aisheng.dong@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1563290089-11085-7-git-send-email-aisheng.dong@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Dong Aisheng Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Dong Aisheng , Catalin Marinas , Will Deacon , Rob Herring , NXP Linux Team , Sascha Hauer , Fabio Estevam , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" List-Id: devicetree@vger.kernel.org On Tue, Jul 16, 2019 at 12:37 PM Dong Aisheng wrote: > + uart0_lpcg: clock-controller@5a460000 { > + reg = <0x5a460000 0x10000>; > + #clock-cells = <1>; > + clocks = <&clk IMX_ADMA_UART0_CLK>, > + <&dma_ipg_clk>; Putting the clocks into a single line helps readability, even if it is over 80 col. > + bit-offset = <0 16>; > + clock-output-names = "uart0_lpcg_baud_clk", > + "uart0_lpcg_ipg_clk"; Same here. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C0CDC7618F for ; Tue, 16 Jul 2019 19:28:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 584382173E for ; Tue, 16 Jul 2019 19:28:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dDnl9CEL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mhTDz/D0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 584382173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o48Af750ZanzsvMIMcMRITttnXmlk7t/0yfrbKQIHsM=; b=dDnl9CELBT6Ch0 Uf8VPD6JdmvFQSn93PJMv/tf873mQiEugrcnIfSsde+NvcijJxZGZmRAPZw6/PwiYPW+f9IQu5dGx B4Nds1mfJNAMAGIb9CmAVos1pEVgffvq/wFutyhhaQXj7XKt3ukuu8RlNRC0hryzuUYKjEWnA0zon 0adzhyrtfnFbBs6G7t2LqfE25cz6SX+2x/3edrJ8ZgXWSnH9twwEhSK8YkjjMHk0yFRsLM1BvnCEe ycKU3pWN4HaIxqp+hs+cQiqJCeNv1wfy2vU6odxQAkh3kcJjxpsH6+LDBH5JuWQe0lgySd0etVI+s Y4yyU7RrPyZxrJyYk8PQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hnT7m-0000GU-Hz; Tue, 16 Jul 2019 19:28:30 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hnT7j-0000FF-9L for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2019 19:28:28 +0000 Received: by mail-lj1-x242.google.com with SMTP id v18so21104249ljh.6 for ; Tue, 16 Jul 2019 12:28:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YusULDKtvbaFl4EVjjwq8xCVpUXm7QI7zzqzoLVeBuI=; b=mhTDz/D0OskKZMo3HE8550xVnGiC9jLh8q+9T61FpCJQf+l5OKx0RXL1gKiRgdWQYw AbIKrOmSECVoQscbUZqufL7SFkovNrMppMuR+mpoRgNhnZRqVb0MMABOUip82pFfE3pA R0KqE9borwHUpSlN2j5Jug1Q77+/0D7dFcXv0tHNhVcGUGDyJItOQpMUeNMC8Bk9Her6 zIWo7OBatil6hgBApRzsLm11OIFpKRVa2sYctDblab4ehBO4k+BJh+LsZV+KY3LPuHtz /ajAmjy9bSC+5UQIaI3kjqXD0USAm2o2TRauds2Ep6TjoxwZzqMBRU8hcXqodi5P23Ry /Wqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YusULDKtvbaFl4EVjjwq8xCVpUXm7QI7zzqzoLVeBuI=; b=IZBixrWGcNhJoTj1xuXITdC7Grfx3RH778yXdz1S6wxCPDlfa6MRJFmog5uAZDV9UR wbRdMG4Cyd0HzQ95J1yP++LCh60xz7szCCdH+11D2qLOXnsOWOESBp5P1PahBK4Vgj9Y Tuh5wgOkZb4d/DrzsqKznipv/nRZhYgTlZMp9UUGuNMqyugKW6CpnanuzRONl5Uqkmfg 3wSepSsYizatfYXII+tPkVnTMQiq46qD8JH2XjcaPLm/qk2MzB8qZiKeSELiyI+1EPma ZCv9AVDaDwVKvFoR7io2N/ExHjE96iGgKJbM712oxWY/r/c7mmDRywTOusrSZnjgu18n Pffg== X-Gm-Message-State: APjAAAWGu0lvkteQL4ELmVYUUkslci+nKUtZHyo67Gilcvrk64YcrgdS 0PT58C8RRDvl+AbqdgLgJmH7RYiLbhQSXCKRq8E= X-Google-Smtp-Source: APXvYqzSdyI4sNlpn8VOfFJ3mQLAKcdxygNOIblNaIK5HBO6A5//BJ9WSLuwARQlvQAg7YW5y6IDIu9f0XmIIYbO0ZA= X-Received: by 2002:a2e:a311:: with SMTP id l17mr17966337lje.214.1563305305275; Tue, 16 Jul 2019 12:28:25 -0700 (PDT) MIME-Version: 1.0 References: <1563290089-11085-1-git-send-email-aisheng.dong@nxp.com> <1563290089-11085-7-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1563290089-11085-7-git-send-email-aisheng.dong@nxp.com> From: Fabio Estevam Date: Tue, 16 Jul 2019 16:28:22 -0300 Message-ID: Subject: Re: [PATCH v2 06/15] arm64: dts: imx8: add adma lpcg clocks To: Dong Aisheng X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190716_122827_322896_62669A81 X-CRM114-Status: UNSURE ( 8.07 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Dong Aisheng , Catalin Marinas , Will Deacon , Rob Herring , NXP Linux Team , Sascha Hauer , Fabio Estevam , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 16, 2019 at 12:37 PM Dong Aisheng wrote: > + uart0_lpcg: clock-controller@5a460000 { > + reg = <0x5a460000 0x10000>; > + #clock-cells = <1>; > + clocks = <&clk IMX_ADMA_UART0_CLK>, > + <&dma_ipg_clk>; Putting the clocks into a single line helps readability, even if it is over 80 col. > + bit-offset = <0 16>; > + clock-output-names = "uart0_lpcg_baud_clk", > + "uart0_lpcg_ipg_clk"; Same here. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel