From mboxrd@z Thu Jan  1 00:00:00 1970
From: Fabio Estevam <festevam@gmail.com>
Date: Thu, 7 Jan 2016 11:31:06 -0200
Subject: [U-Boot] [PATCH 1/3] pci: Add error values definitions from the
	kernel
In-Reply-To: <CAEUhbmX_xYmVZWcJHFhd2tLTRELo8nEpUWpwLmva6xXfEMZjcQ@mail.gmail.com>
References: <1452113598-32409-1-git-send-email-festevam@gmail.com>
 <CAEUhbmWijmsSLrzBXRxrCZPKrZcDn6Bw5U6gYW=-xctLqg9-aQ@mail.gmail.com>
 <CAOMZO5AWvC3hAOqiyX-b0m5zmTA9R1ErOti4=v+ddF_+ndxDLg@mail.gmail.com>
 <CAEUhbmX_xYmVZWcJHFhd2tLTRELo8nEpUWpwLmva6xXfEMZjcQ@mail.gmail.com>
Message-ID: <CAOMZO5ChruMj=abNAUs3Jm2Mge3xZTfTmEXWOh6QBKS3p1wJFQ@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, Jan 7, 2016 at 10:58 AM, Bin Meng <bmeng.cn@gmail.com> wrote:

> Ah, yes! Sorry I wanted to say the original proposal to "return 0"
> instead. But now I failed to understand why this fixed the issue
> because those error numbers are not zero.

The problem only happens if we return a negative value.

> And why returning zero is bad? From a working PCIe controller (either

It is not bad, but I still prefer to keep in sync with the kernel driver.