From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C9CCC433EF for ; Mon, 20 Sep 2021 23:15:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3310360EE0 for ; Mon, 20 Sep 2021 23:15:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3310360EE0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0wD8CUYlnqpdOuVPfl2iHcS2nVPyBFgu8UUxdtZKH9g=; b=mYq2OAJz5RXBXp qdiQgLWf9iORGsrQU4MepVoZdFMRX3ItJETIt4ZxXMu9fvktE5k07Ce8Ghb27WvTwmoIxQbUT0c43 kxxxOBSHlJ5epybolUJPqfeF7MTyY58Pav3RPNK7PNVylDhq+C8WO196O2JrPS9kU46MeF8k7p9xn 424VInWS3rmskRUGVKoxW1Iisj2pg1ZSZmVM8D5e4UPr6q/eiBMK0hN3f4GG7qOasDljSoRj/cXSy 6fHnULVPWx/Iw+8YV35rQZ0l1igS39TS6zcOIWDgj6gxGhBjbw7IEl20Uy7fsYdIcmXMDi6U3Id2N thnk8y8Jd5W8wA/D7LCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSST1-003J6W-Lp; Mon, 20 Sep 2021 23:12:55 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSSSx-003J67-Pg for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 23:12:53 +0000 Received: by mail-lf1-x136.google.com with SMTP id p29so73229252lfa.11 for ; Mon, 20 Sep 2021 16:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3r3IW8W79W3qhW3M5wInsOaI0VuAJnf8eLEgzDkz044=; b=Rs2gyd48wybNv2yj0cuwEDeM/6vdUdT6tlkeHwcfRdeZwYbuu6roopnZPJAmVoVWaE z17sPUtLGCbU8eBc4kgS6yPM01y9Pt0Nmz44CN9Qo0TW0st+81S7GM5dG0r3Hqye7Zbt s2c6zndr6HDv3R9DBg04w/XKtX8S4afxcrkVUyWJR+HyJDzC674bEdSC7PJvFEvhmni5 r6F6pgzOj5Hdpb42QXV3S8cC5uCSv7/M+EKq3lEn3xNh6n2PtcYCHVSlcnvzxYM2+QR4 9M5dNg5MpgFTTcmWDh6g/BHuTHJ+UZT2/d1qZ4I/2z07ZDKj5VDpo6HPxotP5esgFfE+ qXIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3r3IW8W79W3qhW3M5wInsOaI0VuAJnf8eLEgzDkz044=; b=HZM8CqVST0o5EsBCcQ0EuC4+674nciBsOzsOU8l1befsL5nA3AKzx5WkD8SiWlGYS8 cEo5vsz4i+Ji8BMe81uCRLDdTmymEGP6FN6SOo5zyCP2ljrtDjDYBlO74sHvChSTxvbk Mie9cKbXKGyXV+7akD4/RwzF5UPbJoP2VBybdqLOMjIxygXB1YxgMovf5Mv1MfjJZov7 jHkI5qZCjd+h/6ezsRmVuz77t+X/SiC7dSjnuTX+LDbKy6T1uPWdINhDmTyPl/uMACsG FOa0sZHYIUYI7OQpimSiqA7cpjIKgNfidCYetIxaV4LzplF5drWpSbdG1i211x+NYJCm BmqQ== X-Gm-Message-State: AOAM531Pdy3RnJLc6gHwDbiHJlg98OnkSXrXwb52Talup+KMqdYWe6ja bIgNuIepOja/Kx/bM73D7QxF16NYd07s9iaLdd0= X-Google-Smtp-Source: ABdhPJxkA1XueXbn2TktlRHsJBt2INSNHrhnisJ9bBFZxG1jxmua/AO7RnKiksPNr/VX1p9iXhp3DIKUYobIRyuhHLs= X-Received: by 2002:a2e:9942:: with SMTP id r2mr25808312ljj.92.1632179570008; Mon, 20 Sep 2021 16:12:50 -0700 (PDT) MIME-Version: 1.0 References: <20210819212819.GM22278@shell.armlinux.org.uk> <20210820001646.GN22278@shell.armlinux.org.uk> <381afc78-5a7f-8286-76ea-2e6c7867972d@arm.com> In-Reply-To: From: Fabio Estevam Date: Mon, 20 Sep 2021 20:12:38 -0300 Message-ID: Subject: Re: arm32 insecure W+X mapping To: Tim Harvey Cc: "Russell King (Oracle)" , Shawn Guo , Pengutronix Kernel Team , Linux ARM Mailing List , Lee Jones , Robin Murphy , NXP Linux Team X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_161251_909461_FBDEC808 X-CRM114-Status: GOOD ( 13.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tim, On Mon, Sep 20, 2021 at 7:53 PM Tim Harvey wrote: > Ok - makes sense. > > I bisected this to cc8870bf4c3a ("ARM: imx6q: drop > of_platform_default_populate() from init_machine"). > > After that patch we get: > [ 0.133082] imx6q_suspend_init: failed to find ocram device! > > and no longer see the W+X failure. > > Fabio, I suspect this is the regression that you are hitting regarding > suspend and that this needs to be reverted. Thanks for bisecting it. Yes, after reverting such commit, suspend/resume works again. The first time it takes a long time to resume: # echo enabled > /sys/class/tty/ttymxc0/power/wakeup # echo mem > /sys/power/state [ 15.599190] PM: suspend entry (deep) [ 15.640341] Filesystems sync: 0.036 seconds [ 64.492708] imx-sdma 20ec000.sdma: external firmware not found, using ROM firmware >From 15 to 69s it is just waiting to suspend. [ 69.611037] Freezing user space processes ... [ 69.614849] cfg80211: failed to load regulatory.db [ 69.625538] (elapsed 0.014 seconds) done. [ 69.630737] OOM killer disabled. [ 69.634227] Freezing remaining freezable tasks ... (elapsed 0.006 seconds) done. [ 69.648817] printk: Suspending console(s) (use no_console_suspend to debug) [ 70.269165] PM: suspend devices took 0.610 seconds [ 70.288058] Disabling non-boot CPUs ... [ 70.362203] mmc1: queuing unknown CIS tuple 0x01 [d9 01 ff] (3 bytes) [ 70.371768] mmc1: queuing unknown CIS tuple 0x1a [01 01 00 02 07] (5 bytes) [ 70.375904] mmc1: queuing unknown CIS tuple 0x1b [c1 41 30 30 ff ff 32 00] (8 bytes) [ 70.376832] mmc1: queuing unknown CIS tuple 0x14 [] (0 bytes) [ 70.400971] PM: resume devices took 0.100 seconds [ 70.445566] OOM killer enabled. [ 70.448883] Restarting tasks ... done. [ 70.461806] PM: suspend exit Subsequent times, there is no such delay. # echo mem > /sys/power/state [ 87.687476] PM: suspend entry (deep) [ 87.755373] Filesystems sync: 0.064 seconds [ 87.764171] Freezing user space processes ... (elapsed 0.002 seconds) done. [ 87.773544] OOM killer disabled. [ 87.776968] Freezing remaining freezable tasks ... (elapsed 0.002 seconds) done. [ 87.786944] printk: Suspending console(s) (use no_console_suspend to debug) [ 88.405849] PM: suspend devices took 0.610 seconds [ 88.423879] Disabling non-boot CPUs ... [ 88.492122] mmc1: queuing unknown CIS tuple 0x01 [d9 01 ff] (3 bytes) [ 88.501684] mmc1: queuing unknown CIS tuple 0x1a [01 01 00 02 07] (5 bytes) [ 88.505837] mmc1: queuing unknown CIS tuple 0x1b [c1 41 30 30 ff ff 32 00] (8 bytes) [ 88.506782] mmc1: queuing unknown CIS tuple 0x14 [] (0 bytes) [ 88.529321] PM: resume devices took 0.090 seconds [ 88.573766] OOM killer enabled. [ 88.577090] Restarting tasks ... done. [ 88.587390] PM: suspend exit # That's an orthogonal issue though. I will send the revert. > That will still leave the W+X issue needing to be fixed at some point. Yes, agreed. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel