From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58CE6C38BE1 for ; Mon, 24 Feb 2020 18:43:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 31C3420836 for ; Mon, 24 Feb 2020 18:43:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k2mwXkvd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727689AbgBXSn0 (ORCPT ); Mon, 24 Feb 2020 13:43:26 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:42844 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726652AbgBXSn0 (ORCPT ); Mon, 24 Feb 2020 13:43:26 -0500 Received: by mail-lf1-f68.google.com with SMTP id 83so7520248lfh.9; Mon, 24 Feb 2020 10:43:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uCmCqGkBSNCRTaEPKViwOJ/762o19mpcQcrckJGGFEA=; b=k2mwXkvdmgi8pr7kvr78v5r1c+AnLoKifDlTcCs/ZSikAZfhL088/hZVAQ1V1srjUW adK/hdF1CUFI0dDf+hlDbEPRtlSXcL2zxq95AAYfEpOO3eQVdUf6EvX6rChQV8hQbo8v 8riLPA0EsHRca0FXC9j8nsopqWH1As4UIhBuVffez4KsHgxuWIUp19NXeLhknVrRe9+N Sp+7x/eT/OC8u0VhApIAdQrx/AVHnjtYqgZrVQAlEAT/ebn/eqX6kf+7Fv8zELrAO9uZ EYLmQ5qTINJfnaSl40WMelswQ70B8cmZf+d4kRok2h07fXkML/ilqbhADPJoekdqgL9f sAGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uCmCqGkBSNCRTaEPKViwOJ/762o19mpcQcrckJGGFEA=; b=dJm9Fgpy1bQ+KGzcl6iMNXaP68RSmMxvacWkPTUHaa4ye0Y10Kc6++tMEZc71AAmbv bxWw6RZXVx0Z2qrXF4PZvvv9FOCD4Zy7EKOsqe+rAhCYns+g8otab1oNQR+vMmSpKKwy Tv3G3YAaLBs+VrKDiJNyydUdxFt/OG6IHDWD6prKyrFkFqvMQr7AvgdnnXH7/lE9kkGA z3Gqxct5NFEUH+5aZ/aU+C3gANnrnDRcZS3j4+IX4AkPjNfcAhLcHLHjGE8ARvebR4Ko TI9m5dcoMxmreDW8ZnMJV6rwl7+d32Zstz/Wl04TRgwvgtkGhTCm9O0Clz5AJLT3ILMG nJng== X-Gm-Message-State: APjAAAWeTyhvaF6/RlrdZHMq4gIdynLni+Rr3WleD+1VtMYKB91VhYNL WPRzpxP8NR2WIBGmERFBpgBOryI8ZnJAv6V1uJw= X-Google-Smtp-Source: APXvYqxVfNaWgGUCHRkeDD7FAEMlSi7VmD5rdHw5mtCFT9xR0L3S4D33CNY+Hp391gODfjB72gHp7oBEt0X4O41lZ/o= X-Received: by 2002:a05:6512:10d4:: with SMTP id k20mr11537422lfg.70.1582569803984; Mon, 24 Feb 2020 10:43:23 -0800 (PST) MIME-Version: 1.0 References: <20200224172236.22478-1-frieder.schrempf@kontron.de> In-Reply-To: <20200224172236.22478-1-frieder.schrempf@kontron.de> From: Fabio Estevam Date: Mon, 24 Feb 2020 15:43:13 -0300 Message-ID: Subject: Re: [PATCH] dma: imx-sdma: Fix the event id check to include RX event for UART6 To: Schrempf Frieder Cc: Dan Williams , Linus Walleij , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Vinod Koul , "stable@vger.kernel.org" , "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Frieder, On Mon, Feb 24, 2020 at 2:22 PM Schrempf Frieder wrote: > > From: Frieder Schrempf > > On i.MX6 the DMA event for the RX channel of UART6 is '0'. To fix I would suggest being a bit more specific than saying i.MX6. I see UART6 is present on i.MX6UL/i.MX6SX, but not on i.MX6Q/i.MX6DL, so it would be better to specify it in the commit log. imx6ul.dtsi does not have dma nodes under uart6, so I guess you fixed it for imx6sx. > the broken DMA support for UART6, we change the check for event_id0 > to include '0' as a valid id. > > Fixes: 1ec1e82f2510 ("dmaengine: Add Freescale i.MX SDMA support") > Cc: stable@vger.kernel.org > Signed-off-by: Frieder Schrempf Reviewed-by: Fabio Estevam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B49DCC38BE1 for ; Mon, 24 Feb 2020 18:43:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8971020836 for ; Mon, 24 Feb 2020 18:43:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bd8gp6jr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k2mwXkvd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8971020836 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RYksrR2bR0wEtL7ddiVehrYfDnvahF/L53DPY+KIIwA=; b=bd8gp6jr1gKmLN idqLtEvlJOr924iDOeQpGGKQzY28CyhczT85v45YAj5Uhtx1pSUdM2GbEZX1rso+0ilp2+eJlNgz0 kxwQUTs7OCFuxM/VH3QU1yUXvdyJ08NAG0H/R5mCQ4mphzuY32hIlXmo30Eb9qWEAMqE5z/yJMX9Z FPfY9kK+aNnhsxWi76Oa0B0r2UY4Jy7/Lily267Pkj0uLnBPMo+8EwRHgPQM7glXHMZFPdye0D5mb 7oTCt5KlLqsKbEkq3gd1KgSUgm4x6quvjV9z7dJUpikCATOG19JIJpLJEnGrU+HHb7h/53m5ccVhW kG+u+f77nHkEn5R+oNQg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6IhV-0004kS-3S; Mon, 24 Feb 2020 18:43:29 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6IhS-0004jt-KS for linux-arm-kernel@lists.infradead.org; Mon, 24 Feb 2020 18:43:27 +0000 Received: by mail-lf1-x144.google.com with SMTP id l18so7568387lfc.1 for ; Mon, 24 Feb 2020 10:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uCmCqGkBSNCRTaEPKViwOJ/762o19mpcQcrckJGGFEA=; b=k2mwXkvdmgi8pr7kvr78v5r1c+AnLoKifDlTcCs/ZSikAZfhL088/hZVAQ1V1srjUW adK/hdF1CUFI0dDf+hlDbEPRtlSXcL2zxq95AAYfEpOO3eQVdUf6EvX6rChQV8hQbo8v 8riLPA0EsHRca0FXC9j8nsopqWH1As4UIhBuVffez4KsHgxuWIUp19NXeLhknVrRe9+N Sp+7x/eT/OC8u0VhApIAdQrx/AVHnjtYqgZrVQAlEAT/ebn/eqX6kf+7Fv8zELrAO9uZ EYLmQ5qTINJfnaSl40WMelswQ70B8cmZf+d4kRok2h07fXkML/ilqbhADPJoekdqgL9f sAGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uCmCqGkBSNCRTaEPKViwOJ/762o19mpcQcrckJGGFEA=; b=N7wUolZji6qAQlU1KjwMFJACtm0gsNhdAayrXrylPALh+SmOcF21hONuKGmSozwf+i JZbo6S9LeUiH7qTBudrrRGsGBbWJKwclCpnSWFgWwj1GcO74YmH6Bg/WjROEM4OY6OiN AN4lCxxRXyXVgkjybwoacQ1x6eHxuxoKjHIGw/x2tHzZtr7LAEGnTaLAgSw7UG3lo+5j 5u6NrPL2kCRO2TeFRe2phBc1Z/3jjjIkQLMTZBB1qfGV+Qf0+qsrffzb8qyqTU6RGK53 Ha5S6x+9cXgVnu3zHWyhcm9Y3bDgbJ2uGaSWGyqPIl5Vfe2e5DJcobWGFZVHZEmgoZnF kAAQ== X-Gm-Message-State: APjAAAXh6HRdHg7VV4sMX6lXgao6P2/sB8K73aN+2AU0bZk10OQDwk+9 0PGuX3FgH78rOZYumJVBsGo0sKEbFjnix08/64c= X-Google-Smtp-Source: APXvYqxVfNaWgGUCHRkeDD7FAEMlSi7VmD5rdHw5mtCFT9xR0L3S4D33CNY+Hp391gODfjB72gHp7oBEt0X4O41lZ/o= X-Received: by 2002:a05:6512:10d4:: with SMTP id k20mr11537422lfg.70.1582569803984; Mon, 24 Feb 2020 10:43:23 -0800 (PST) MIME-Version: 1.0 References: <20200224172236.22478-1-frieder.schrempf@kontron.de> In-Reply-To: <20200224172236.22478-1-frieder.schrempf@kontron.de> From: Fabio Estevam Date: Mon, 24 Feb 2020 15:43:13 -0300 Message-ID: Subject: Re: [PATCH] dma: imx-sdma: Fix the event id check to include RX event for UART6 To: Schrempf Frieder X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200224_104326_668100_144C0698 X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , Sascha Hauer , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Vinod Koul , NXP Linux Team , Pengutronix Kernel Team , "dmaengine@vger.kernel.org" , Dan Williams , Shawn Guo , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Frieder, On Mon, Feb 24, 2020 at 2:22 PM Schrempf Frieder wrote: > > From: Frieder Schrempf > > On i.MX6 the DMA event for the RX channel of UART6 is '0'. To fix I would suggest being a bit more specific than saying i.MX6. I see UART6 is present on i.MX6UL/i.MX6SX, but not on i.MX6Q/i.MX6DL, so it would be better to specify it in the commit log. imx6ul.dtsi does not have dma nodes under uart6, so I guess you fixed it for imx6sx. > the broken DMA support for UART6, we change the check for event_id0 > to include '0' as a valid id. > > Fixes: 1ec1e82f2510 ("dmaengine: Add Freescale i.MX SDMA support") > Cc: stable@vger.kernel.org > Signed-off-by: Frieder Schrempf Reviewed-by: Fabio Estevam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel