From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751483AbdKVUsP (ORCPT ); Wed, 22 Nov 2017 15:48:15 -0500 Received: from mail-ot0-f170.google.com ([74.125.82.170]:38483 "EHLO mail-ot0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751286AbdKVUsN (ORCPT ); Wed, 22 Nov 2017 15:48:13 -0500 X-Google-Smtp-Source: AGs4zMZKkIDt/VdQtWc6l99J4TBx/4K0nO6RwJdj/ckAFT7lbJnwJnaKkIMsbBpbgHZAJtZuQLMN/pU6iJAfUO2f2Ek= MIME-Version: 1.0 In-Reply-To: <20171122203233.2649-2-sebastien.bourdelin@savoirfairelinux.com> References: <20171122203233.2649-1-sebastien.bourdelin@savoirfairelinux.com> <20171122203233.2649-2-sebastien.bourdelin@savoirfairelinux.com> From: Fabio Estevam Date: Wed, 22 Nov 2017 18:48:12 -0200 Message-ID: Subject: Re: [PATCH v2 2/2] ARM: dts: TS-7970: add basic device tree To: Sebastien Bourdelin Cc: linux-kernel , kernel@savoirfairelinux.com, "linux-arm-kernel@lists.infradead.org" , Fabio Estevam , Sascha Hauer , Shawn Guo , Russell King - ARM Linux , Mark Rutland , "robh+dt@kernel.org" , kris@embeddedarm.com, Mark Featherston Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 22, 2017 at 6:32 PM, Sebastien Bourdelin wrote: > +/dts-v1/; > +#include "imx6q.dtsi" > +#include "imx6qdl-ts7970.dtsi" > + > +/ { > + model = "Technologic Systems i.MX6 Quad TS-7970 (Default Devuice Tree)"; Typo: Devuice--> Device > + reg_can1_3v3: reg_can1_3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "reg_can1_3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>; Are you sure this is GPIO_ACTIVE_HIGH? If so, then it would need the 'enable-active-high' property. > + }; > + > + reg_can2_3v3: en-reg_can2_3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "reg_can2_3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&gpio6 31 GPIO_ACTIVE_HIGH>; Same here. > + > +&fec { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_enet>; > + interrupts-extended = <&gpio1 6 0x04>, <&gpc 0 119 0x04>; I think you meant to say: interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; fsl,err006687-workaround-present; > +&pcie { > + reset-gpio = <&gpio2 21 GPIO_ACTIVE_HIGH>; Are you sure it is GPIO_ACTIVE_HIGH? if so, it would need a reset-gpio-active-high property. Most likely this should be: reset-gpio = <&gpio2 21 GPIO_ACTIVE_LOW>; From mboxrd@z Thu Jan 1 00:00:00 1970 From: festevam@gmail.com (Fabio Estevam) Date: Wed, 22 Nov 2017 18:48:12 -0200 Subject: [PATCH v2 2/2] ARM: dts: TS-7970: add basic device tree In-Reply-To: <20171122203233.2649-2-sebastien.bourdelin@savoirfairelinux.com> References: <20171122203233.2649-1-sebastien.bourdelin@savoirfairelinux.com> <20171122203233.2649-2-sebastien.bourdelin@savoirfairelinux.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Nov 22, 2017 at 6:32 PM, Sebastien Bourdelin wrote: > +/dts-v1/; > +#include "imx6q.dtsi" > +#include "imx6qdl-ts7970.dtsi" > + > +/ { > + model = "Technologic Systems i.MX6 Quad TS-7970 (Default Devuice Tree)"; Typo: Devuice--> Device > + reg_can1_3v3: reg_can1_3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "reg_can1_3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>; Are you sure this is GPIO_ACTIVE_HIGH? If so, then it would need the 'enable-active-high' property. > + }; > + > + reg_can2_3v3: en-reg_can2_3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "reg_can2_3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&gpio6 31 GPIO_ACTIVE_HIGH>; Same here. > + > +&fec { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_enet>; > + interrupts-extended = <&gpio1 6 0x04>, <&gpc 0 119 0x04>; I think you meant to say: interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; fsl,err006687-workaround-present; > +&pcie { > + reset-gpio = <&gpio2 21 GPIO_ACTIVE_HIGH>; Are you sure it is GPIO_ACTIVE_HIGH? if so, it would need a reset-gpio-active-high property. Most likely this should be: reset-gpio = <&gpio2 21 GPIO_ACTIVE_LOW>;