From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C2FCC433EF for ; Tue, 21 Sep 2021 21:24:05 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BAFE610A1 for ; Tue, 21 Sep 2021 21:24:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1BAFE610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B88341661; Tue, 21 Sep 2021 23:23:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B88341661 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1632259443; bh=NyTR9Q2AmZwKC9gtmONDlhJRvDD9ALEm9Hy8ULvgYeo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=h8NVcG6izU3cdT8S6FkFuiq2rzybvMkFUa8050d3hmZhGJ5j/gC/0f4PdiizdjbIa ornKtO3Lenq/38NSxzf2skrlgRx1COPEx3o4SyuXKtjecRnd/Pi9fmZAhM+Z3VuYif 5vYn8JC2K+KhtaM/l9LfyC9AG5vbCB75nqIs/PSE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4D514F8016E; Tue, 21 Sep 2021 23:23:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 298DAF80268; Tue, 21 Sep 2021 23:23:12 +0200 (CEST) Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 42648F8016E for ; Tue, 21 Sep 2021 23:23:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 42648F8016E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lI3L7AvT" Received: by mail-lf1-x12a.google.com with SMTP id e15so2871162lfr.10 for ; Tue, 21 Sep 2021 14:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yMGBZJhgLdjiD4sy6cvbQdtvYs//rHG8iQfh3SyGQf8=; b=lI3L7AvTi8Iwun3OAtga1QWsPwv819yMUHiXdIjyijYaXbZGLRJdlBdPWNnhc/W+CP GtHqPnf6DG/G+NmbIGEOxKIELz32liqbbzAHUW4HlqGaqQ65VHFcYKCOfIJrDTVKHaDi nKkB2LWkAtVz0b3mjluoh3WtLbSVOxCB4012SXFWbrlrnjl9cAj0wL8pSbswY9HUAMb0 p2GtI7koz10lmy87cAztrXAFKzLJJNJoCdbeewQCwGL+2Or3EARVRV4Qlkdncywzom65 Aaw8Q2IDjRq2yQgOefyOkSG0NuyrXsLaAdILz82GXpcZQhvR4/OnRZdoW5D8/ivXT4ud 0gnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yMGBZJhgLdjiD4sy6cvbQdtvYs//rHG8iQfh3SyGQf8=; b=6veRILkimGD8KNsuQf73cT8gM9Ny+T1xkg0m5uFSdYRIFO79ST3UItG4Khupr8z52n p21Zd6wnS0tOezSFBh8N16haeBiyCwXI8TdDJhgg6T6LLCBMrToj6qMK+TUVTWndId4f jTcr4+oE8O4CBOtgi67lEpcFOWRmgRRwb4fxQrVCtM5rJPE8uhSInXAJ2OVWdXQFze+w KQo5RiHn9tsZe2ZHfHgJ8VdT4aoIrO/CoCwIQpc3e9yNoYQSqEhGRipMiq8MXDpQ6Gwk S4AIVT5gueB54Bk7GWVpy+xBl4y8GNXCfSqjRWXiRN8dL56Zo8IQs+o3beDInSlYgdqY GVbw== X-Gm-Message-State: AOAM530qS1NVcCV9h1uixplEXiJhDglGEpI7wnwbB/m4Daw54vY7ZeV0 DS78CuXZUgqPiBebEmEDfv62xRNrHPLp+pIxU60= X-Google-Smtp-Source: ABdhPJxh9a81q0IGJIP/0g9LetfBcvltXmBhzVLEXSEszysh/R+YS6sunrAf1NcvezczNUoT95Ngg/cgfPC3kf6k6sE= X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr24597919lfq.113.1632259382841; Tue, 21 Sep 2021 14:23:02 -0700 (PDT) MIME-Version: 1.0 References: <20210921211040.11624-1-broonie@kernel.org> <20210921211040.11624-3-broonie@kernel.org> In-Reply-To: <20210921211040.11624-3-broonie@kernel.org> From: Fabio Estevam Date: Tue, 21 Sep 2021 18:22:51 -0300 Message-ID: Subject: Re: [PATCH 03/16] ASoC: fsl-audmix: Update to modern clocking terminology To: Mark Brown Content-Type: text/plain; charset="UTF-8" Cc: Linux-ALSA , Xiubo Li , Shengjiu Wang , Liam Girdwood , Nicolin Chen , linuxppc-dev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Sep 21, 2021 at 6:11 PM Mark Brown wrote: > > As part of moving to remove the old style defines for the bus clocks update > the fsl-audmix driver to use more modern terminology for clocking. > > Signed-off-by: Mark Brown > --- > sound/soc/fsl/fsl_audmix.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/fsl/fsl_audmix.c b/sound/soc/fsl/fsl_audmix.c > index f931288e256c..db2dde597edc 100644 > --- a/sound/soc/fsl/fsl_audmix.c > +++ b/sound/soc/fsl/fsl_audmix.c > @@ -257,10 +257,10 @@ static int fsl_audmix_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) > return -EINVAL; > } > > - /* For playback the AUDMIX is slave, and for record is master */ > - switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { > - case SND_SOC_DAIFMT_CBM_CFM: > - case SND_SOC_DAIFMT_CBS_CFS: > + /* For playback the AUDMIX is provider, and for record is consumer */ > + switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) { I think the comment should be the other way around: /* For playback the AUDMIX is consumer, and for record is provider */ Other than that, the series looks good. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06FA2C433EF for ; Tue, 21 Sep 2021 21:31:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4D7360FE8 for ; Tue, 21 Sep 2021 21:31:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C4D7360FE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MmjKUVCAqVxzT8KjitPniY1I27snlJ2DKL0EJDdLoMo=; b=dPDSoxEyopkruB Y3uHGtxKIjwx8aiyA5ruNjAtx1kLnlC+7puoBmK6+Yybbu2hDGXaBS4v3k8lBcqSQdhABvw2o71pH ZcNS6iIOjzWJjJUjicR3Mi4zkypeYeUGmcGAyKyUTS/l/3qtaHPNuu5u+3iMrGLaWTsJPxi4nkg8f nzURHE+OtvYMTR8rUe9LJXPaIaaHJkXGasd7sc6o6jKAyK5A++7oIb8d0bHO2CU1NaJ2Zp6EatBgm L9b55UlU1Cx9SwEOuvw01RJl+TkzMvWLSu03RITRNg8/2ZS+QGyC1Gaq3EB0ULFnekaa8FJerSzFs N3wlI5i8GGbPFtXywvMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSnJe-005vF8-4g; Tue, 21 Sep 2021 21:28:39 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSnEH-005swK-9n for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 21:23:06 +0000 Received: by mail-lf1-x134.google.com with SMTP id y28so3288318lfb.0 for ; Tue, 21 Sep 2021 14:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yMGBZJhgLdjiD4sy6cvbQdtvYs//rHG8iQfh3SyGQf8=; b=lI3L7AvTi8Iwun3OAtga1QWsPwv819yMUHiXdIjyijYaXbZGLRJdlBdPWNnhc/W+CP GtHqPnf6DG/G+NmbIGEOxKIELz32liqbbzAHUW4HlqGaqQ65VHFcYKCOfIJrDTVKHaDi nKkB2LWkAtVz0b3mjluoh3WtLbSVOxCB4012SXFWbrlrnjl9cAj0wL8pSbswY9HUAMb0 p2GtI7koz10lmy87cAztrXAFKzLJJNJoCdbeewQCwGL+2Or3EARVRV4Qlkdncywzom65 Aaw8Q2IDjRq2yQgOefyOkSG0NuyrXsLaAdILz82GXpcZQhvR4/OnRZdoW5D8/ivXT4ud 0gnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yMGBZJhgLdjiD4sy6cvbQdtvYs//rHG8iQfh3SyGQf8=; b=0/5B25EPxESD4fcCa1ZexG8Bb/PSNA4/qcuIEJnCL1jacDeQ0Sk06fHRgBhLfGpjWR wonZCnm+Jgfi+wju6nhChRl3pI94U1td3Ws65pVfIrj3SoLRBbNdddKsuYkcnUOMcsPU 0dQ27HrU/l64/DWNGOhHDjGCsJBl3/UjxNOeJh88rsBzgHovOCidIBQCwOJuMCWwXogd wc+FFzm5G14/DcY/Lhh0VOOFGeDbvfwDda956uKfLj6ET2wsCzEsB33wO8VN7QbudTrc isTlnJoRyofZ4U7t3Z0ILZwpDSeYbIIiEwa5lP7yMaXQFfvbrzdmgRY6AVJv+I1WXHv+ wmqg== X-Gm-Message-State: AOAM532wT2fCC6m0m2SemQ/WszCoRpvYjk/9WmyAr3xT2p/Z6UYshk1j Gyq1L/RP+wdOJP3k2BSdgq9UZYr1yRrEcqW8JwA= X-Google-Smtp-Source: ABdhPJxh9a81q0IGJIP/0g9LetfBcvltXmBhzVLEXSEszysh/R+YS6sunrAf1NcvezczNUoT95Ngg/cgfPC3kf6k6sE= X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr24597919lfq.113.1632259382841; Tue, 21 Sep 2021 14:23:02 -0700 (PDT) MIME-Version: 1.0 References: <20210921211040.11624-1-broonie@kernel.org> <20210921211040.11624-3-broonie@kernel.org> In-Reply-To: <20210921211040.11624-3-broonie@kernel.org> From: Fabio Estevam Date: Tue, 21 Sep 2021 18:22:51 -0300 Message-ID: Subject: Re: [PATCH 03/16] ASoC: fsl-audmix: Update to modern clocking terminology To: Mark Brown Cc: Liam Girdwood , Nicolin Chen , Xiubo Li , Shengjiu Wang , Linux-ALSA , linuxppc-dev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_142305_384639_4A7610B6 X-CRM114-Status: GOOD ( 18.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 21, 2021 at 6:11 PM Mark Brown wrote: > > As part of moving to remove the old style defines for the bus clocks update > the fsl-audmix driver to use more modern terminology for clocking. > > Signed-off-by: Mark Brown > --- > sound/soc/fsl/fsl_audmix.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/fsl/fsl_audmix.c b/sound/soc/fsl/fsl_audmix.c > index f931288e256c..db2dde597edc 100644 > --- a/sound/soc/fsl/fsl_audmix.c > +++ b/sound/soc/fsl/fsl_audmix.c > @@ -257,10 +257,10 @@ static int fsl_audmix_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) > return -EINVAL; > } > > - /* For playback the AUDMIX is slave, and for record is master */ > - switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { > - case SND_SOC_DAIFMT_CBM_CFM: > - case SND_SOC_DAIFMT_CBS_CFS: > + /* For playback the AUDMIX is provider, and for record is consumer */ > + switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) { I think the comment should be the other way around: /* For playback the AUDMIX is consumer, and for record is provider */ Other than that, the series looks good. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel