From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8995DC43331 for ; Tue, 31 Mar 2020 13:42:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 591FE2071A for ; Tue, 31 Mar 2020 13:42:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oDM3v2vU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730928AbgCaNmq (ORCPT ); Tue, 31 Mar 2020 09:42:46 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:43948 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730216AbgCaNmq (ORCPT ); Tue, 31 Mar 2020 09:42:46 -0400 Received: by mail-lf1-f66.google.com with SMTP id n20so17312816lfl.10; Tue, 31 Mar 2020 06:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g+oOx8oe1EcOiEsQwOx41lZlMI2tyT5SQXJ7reK/MjM=; b=oDM3v2vUvoB+zQ1qxrk49Rs6ZBg+nafBMNk2MMzG+O8CPZW0Hudl4k6TwLZW4EMtJQ fLBL0OIBYoNagGt804nTK8OZRHQcGD9TkcD/23CfxQu/IVD+Z8JAEon21F8t1lvztDi9 Tz5F28Tp5Nb3drKK+NDJO4zfpF1LnPGT54tgPPtUquRxFbqVF3sityDiMimZ94LN5H4m 9E30zffqveXsn+CfPYHHzZVgdTvf71weNFZ1d3R85/ri4X85LHdLh1JeCSY+++udvlls sKV1dgy8Tmy1IXx/3uurUncdjaJy+dkQBEYwfdDl7J2IpK1ctInx9/6BCAFJfyhgcD0E i0cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g+oOx8oe1EcOiEsQwOx41lZlMI2tyT5SQXJ7reK/MjM=; b=tLJWzIzn0OT1fy/Zr0ueAlW7ElOFdZjI18FZsI4XwVB4X9Bx2cX2eriRwxzBkPGoYV 098142kSvrci7raBZZTnj8RroXaWTaNQ+nJeWYt60I1BBPe7q+nu94V3qtOruFWWgST6 JiAJeOcawYkAwlwz95xD0ToyLbs3i7576nn0KkEPdYuaXRCwPosyNHcymVBA+IjRSEGr hxDtz4wTTgnaURxxEmqeB6/r6TMByzhvGapFOEIBcKF3Gui/hdGA9IcLn0aI1exzgUgw MUihpWiwOz+ulsmK9UEZ0AB981DnjiaoSZkbYHf8jzzBfDy+Blu0Hr2nCkxMX7DF0QeY ixGQ== X-Gm-Message-State: AGi0PuYjAXBve7kK8MafkdzIY9hdsc/TwRNkdUb+xHjWBE+3ZVtYcMWO 7d2KHDNIbCRI19I2WMVynKGbhhxf+maBug/iYkE= X-Google-Smtp-Source: APiQypL+H+6Kyrx6/X3/WVdrnJz8eQS2wW8bf4HVX9M6MsjMu5LPvIiOLF5pjFJDq/yzciCsM+hUGrhPSZOPEEObj1A= X-Received: by 2002:ac2:4c3b:: with SMTP id u27mr11614521lfq.7.1585662163062; Tue, 31 Mar 2020 06:42:43 -0700 (PDT) MIME-Version: 1.0 References: <20200313110350.10864-1-robert.foss@linaro.org> <20200313110350.10864-3-robert.foss@linaro.org> In-Reply-To: From: Fabio Estevam Date: Tue, 31 Mar 2020 10:42:33 -0300 Message-ID: Subject: Re: [v2 2/3] media: ov8856: Add devicetree support To: Robert Foss Cc: Dongchun Zhu , Andy Shevchenko , Sakari Ailus , Tomasz Figa , linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robert, On Tue, Mar 31, 2020 at 10:37 AM Robert Foss wrote: > After testing this change, it breaks the driver during probing. Why exactly does it break probing? Maybe the GPIO polarity defined in the device tree is wrong? > I had a quick look into GPIOD_OUT_HIGH & LOW definitions, and they > seem to never be 0 or 1. If you do a grep in all gpiod_set_value_cansleep() usages in the kernel tree, there is not a single case where GPIOD_OUT_HIGH or GPIOD_OUT_LOW is passed as argument of gpiod_set_value_cansleep(). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A103BC43331 for ; Tue, 31 Mar 2020 16:16:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 707CE20786 for ; Tue, 31 Mar 2020 16:16:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CSll24nu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oDM3v2vU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 707CE20786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0Rtj9/qV7fgOUbyKsCRkUWBXSQUM/1XlUnq9UhEBWUQ=; b=CSll24nuurtWHq BOKQTc4MeGf0WgsfSHifpvmg0j28/bh+tJKGfD4REu5xnZnCT7SMS9KsyqrIGMmAXVh1VHo2ZpdhB 0QuG1jYpxcyefdtcgRfTqM7Iuafkx8XFNuu+ADVDv6nHmMj4qeemQHGxBzInjSYx7P4DA19ZFUHri Zgr/yltCkh0S+P4UdnH/+4itfpa2C2YMZi3NVNyl8kkTfNjJ071wBBc3XyBDiqlfIO2zjP9Cs60jN +77KIN2/yQgL//TUm3DglnSIIHm86lCUJEhmejDIcXT1pIVMNV2GlHi6D69oATmnBVGtvXoTAdYZI aMwEPmS8RaYHiCFOEICg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJJYe-00033B-Pv; Tue, 31 Mar 2020 16:16:09 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJJYD-0002iI-SK for linux-arm-kernel@lists.infradead.org; Tue, 31 Mar 2020 16:15:44 +0000 Received: by mail-lf1-x12d.google.com with SMTP id j188so17819942lfj.11 for ; Tue, 31 Mar 2020 09:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g+oOx8oe1EcOiEsQwOx41lZlMI2tyT5SQXJ7reK/MjM=; b=oDM3v2vUvoB+zQ1qxrk49Rs6ZBg+nafBMNk2MMzG+O8CPZW0Hudl4k6TwLZW4EMtJQ fLBL0OIBYoNagGt804nTK8OZRHQcGD9TkcD/23CfxQu/IVD+Z8JAEon21F8t1lvztDi9 Tz5F28Tp5Nb3drKK+NDJO4zfpF1LnPGT54tgPPtUquRxFbqVF3sityDiMimZ94LN5H4m 9E30zffqveXsn+CfPYHHzZVgdTvf71weNFZ1d3R85/ri4X85LHdLh1JeCSY+++udvlls sKV1dgy8Tmy1IXx/3uurUncdjaJy+dkQBEYwfdDl7J2IpK1ctInx9/6BCAFJfyhgcD0E i0cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g+oOx8oe1EcOiEsQwOx41lZlMI2tyT5SQXJ7reK/MjM=; b=gY/0pgdp1P3tmXIIxGxRSqOw1rB6BrMurMAx6pC5UMZ0HFUOJ35XjcKSzhSaWUxxUS 3494zwv9UzvLEOR9B48NE6U9WxFGUQBisjPb6/QgYNg2m201mbfiHtYaEPcLjv4hKqk6 imvjKhCJ8TPY2GqLf7E3cgYaFRLB4QnV0UqTgBAjXVPp8uGAlwYrUqPT10nCLBCYNEJ5 ndTYYxsf1mdTn4P9zKm7q9CQzuaI7/4lN9Vnu4jjGos7HFt50abs3bBylz7BUFXy9sVj MHk0fWKzd8KqoMw1pSx1McIJET+o/KIZBdyU1/+PMC+JBtJqSx35IIwObuxygIIvtVvB JWcg== X-Gm-Message-State: AGi0PubwWKlZkdjHKLNz0ERrQP9P8g+EciLSYWdIB+uCB//lwPMd9O0B +GR9hXtigyvqir9biesf7076UiIrPXmPhiXQBf4U076y6Cs= X-Google-Smtp-Source: APiQypL+H+6Kyrx6/X3/WVdrnJz8eQS2wW8bf4HVX9M6MsjMu5LPvIiOLF5pjFJDq/yzciCsM+hUGrhPSZOPEEObj1A= X-Received: by 2002:ac2:4c3b:: with SMTP id u27mr11614521lfq.7.1585662163062; Tue, 31 Mar 2020 06:42:43 -0700 (PDT) MIME-Version: 1.0 References: <20200313110350.10864-1-robert.foss@linaro.org> <20200313110350.10864-3-robert.foss@linaro.org> In-Reply-To: From: Fabio Estevam Date: Tue, 31 Mar 2020 10:42:33 -0300 Message-ID: Subject: Re: [v2 2/3] media: ov8856: Add devicetree support To: Robert Foss X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200331_091541_920416_71EB39B5 X-CRM114-Status: UNSURE ( 9.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , Tomasz Figa , Sakari Ailus , Dongchun Zhu , Andy Shevchenko , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-media Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Robert, On Tue, Mar 31, 2020 at 10:37 AM Robert Foss wrote: > After testing this change, it breaks the driver during probing. Why exactly does it break probing? Maybe the GPIO polarity defined in the device tree is wrong? > I had a quick look into GPIOD_OUT_HIGH & LOW definitions, and they > seem to never be 0 or 1. If you do a grep in all gpiod_set_value_cansleep() usages in the kernel tree, there is not a single case where GPIOD_OUT_HIGH or GPIOD_OUT_LOW is passed as argument of gpiod_set_value_cansleep(). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel