From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752466AbbCKRMq (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 Mar 2015 13:12:46 -0400
Received: from mail-la0-f41.google.com ([209.85.215.41]:45078 "EHLO
	mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750949AbbCKRMo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 Mar 2015 13:12:44 -0400
MIME-Version: 1.0
In-Reply-To: <1426093216-18370-1-git-send-email-george.joseph@fairview5.com>
References: <1426093216-18370-1-git-send-email-george.joseph@fairview5.com>
Date: Wed, 11 Mar 2015 14:12:42 -0300
Message-ID: <CAOMZO5DJPi+cZEQnO1qkWNXMc+=pboFz-z_rzxwxESD3G_1FcA@mail.gmail.com>
Subject: Re: [PATCH 1/1] net: fec: fix oops after transmit queue timeout
From: Fabio Estevam <festevam@gmail.com>
To: George Joseph <george.joseph@fairview5.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Nimrod Andy <B38611@freescale.com>,
        Russell King <rmk+kernel@arm.linux.org.uk>,
        Frank Li <Frank.Li@freescale.com>,
        Fabio Estevam <fabio.estevam@freescale.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 11, 2015 at 2:00 PM, George Joseph
<george.joseph@fairview5.com> wrote:
> When a transmit queue timeout happens, dev_watchdog calls fec_timeout
> which in turns schedules fec_enet_timeout_work.  fec_enet_timeout_work
> uses container_of to get the private data structure (fep) then tries to
> use fep->netdev.  Unfortunately, nobody ever set fep->netdev so the result
> is a NULL pointer oops.
>
> With fep->netdev set right after fep is allocated in fep_probe, the
> drivers recovers nicely after the tx queue timeout.
>
> Signed-off-by: George Joseph <george.joseph@fairview5.com>
> Tested-by: George Joseph <george.joseph@fairview5.com>

Thanks for the patch, but this has already been fixed by:

commit 0c8185944a125621a1766615585238a3563ccac3
Author: Hubert Feurstein <h.feurstein@gmail.com>
Date:   Wed Jan 7 14:48:17 2015 +0100

    net: fec: fix NULL pointer dereference in fec_enet_timeout_work

    This patch initialises the fep->netdev pointer. This pointer was not
    initialised at all, but is used in fec_enet_timeout_work and in some
    error paths.

    Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>