All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>, Stefan Agner <stefan@agner.ch>,
	Linus Walleij <linus.walleij@linaro.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST
Date: Fri, 17 Sep 2021 08:50:55 -0300	[thread overview]
Message-ID: <CAOMZO5DKGv1GQBpwr0ff0YC1yDmCH2A5Xpq7jzUA2h75bmN6eQ@mail.gmail.com> (raw)
In-Reply-To: <20210825082251.2484-1-caihuoqing@baidu.com>

Hi Cai,

On Wed, Aug 25, 2021 at 5:23 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
>
> it's helpful for complie test in other platform(e.g.X86)
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
>  drivers/pinctrl/freescale/Kconfig | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> index 21fa21c6547b..defc1f38efc7 100644
> --- a/drivers/pinctrl/freescale/Kconfig
> +++ b/drivers/pinctrl/freescale/Kconfig
> @@ -119,28 +119,28 @@ config PINCTRL_IMX7ULP
>
>  config PINCTRL_IMX8MM
>         tristate "IMX8MM pinctrl driver"
> -       depends on ARCH_MXC
> +       depends on ARCH_MXC || (COMPILE_TEST && OF)
>         select PINCTRL_IMX

I am not sure why you need the && OF, as we have a "select PINCTRL_IMX",
that already depends on OF.

Also, why was PINCTRL_IMX8DXL not updated?

Thanks

  parent reply	other threads:[~2021-09-17 11:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25  8:22 [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST Cai Huoqing
2021-09-16 22:07 ` Linus Walleij
2021-09-17  1:54   ` Cai Huoqing
2021-09-17 11:50 ` Fabio Estevam [this message]
2021-09-18  2:26   ` Cai Huoqing
2021-09-23 22:17     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5DKGv1GQBpwr0ff0YC1yDmCH2A5Xpq7jzUA2h75bmN6eQ@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=aisheng.dong@nxp.com \
    --cc=caihuoqing@baidu.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.