From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57B9EC433C1 for ; Sun, 21 Mar 2021 19:07:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E2EA61934 for ; Sun, 21 Mar 2021 19:07:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230201AbhCUTHA (ORCPT ); Sun, 21 Mar 2021 15:07:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230064AbhCUTGi (ORCPT ); Sun, 21 Mar 2021 15:06:38 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBBE4C061574 for ; Sun, 21 Mar 2021 12:06:37 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id o10so17901561lfb.9 for ; Sun, 21 Mar 2021 12:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XnGCJN74ODgPcebw1KK2VajqNNiVgQntWUbh05j1Gs4=; b=ConM0sdsCGRKS9xdbAVm/HVQQKn6HtsIYNcEnt8nCXXNqDzrkHgy7WQ7COMd4h9Kms ggCTmZtQwhOLG33qbRYsW+07dmEdtodoGO5Jb44jrTGsIw/koaVJfUH6AKFMMjOMdNfM LmFqhbjrYxmCETdlJpMJusQaGg+75gDUZYKUffxHAS54lqKzHa3LQhbA4/jBAuClWVGJ El05tnJbencJawsXRbHC45uLhlUMtKUL79v2sYPDyNGot26/uBcz31j1j/7c1m+H6mQ4 vRLuSACeg+kV6KXnf0FPPECcMThm0HOSy9Z7oaIZCWJWopJjqlPQB0Po3hS+vTkwuAkS Xt0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XnGCJN74ODgPcebw1KK2VajqNNiVgQntWUbh05j1Gs4=; b=kFU2xGPMLKHuwfiR/MewUlElIez9cTP9gGArOavdeQyXq4Rdg4sZ7lMhXZwwy7AILD oYYmWs5AfcMRvjER0hnBoJlNJ4qOKxzTnDzPLfGODuRSocnL9TZcuOw5KDVxDEGzlzZr PvIZR02+/bBVhCP8JslzLoR9PaBqygTRTFSoi+zUQBJ64G3a1TZ7g46v4uvlw5ViZghI hJpiGqqOxt0Tfm+/GEM68tYlDtJSh+s7R6QtKptiVSd8hgyKYlBJ+MG0JlFEQt3Bm9Ka EDJIpml6SJEJ/ktsQ81V6PJqCzJduPqkfE3NdAg32WkypBBVVxVfSKFbGpiNRgOrBMnB +4hw== X-Gm-Message-State: AOAM531vUj2xbAWoqUxkdtNHkKZnMwTyrdql/PTK9mjoqHHofA8xkscF 8XNXsWwhDJU4Qf5FAJ58VJlHNYBW03HbUt4KFfs= X-Google-Smtp-Source: ABdhPJwkT2kzFj4bjY/jKrHaHA7YG+VjSUyX6bdLhkFg6pnrUKLw8ukDG3eiH6FlPOOBMDDHUI24sSO33zaNAwJYFrc= X-Received: by 2002:a05:6512:3996:: with SMTP id j22mr4563670lfu.443.1616353596107; Sun, 21 Mar 2021 12:06:36 -0700 (PDT) MIME-Version: 1.0 References: <2e552c36-84a5-a642-a8f0-1395f77a1a6a@omprussia.ru> In-Reply-To: From: Fabio Estevam Date: Sun, 21 Mar 2021 16:06:24 -0300 Message-ID: Subject: Re: [PATCH 4/4] pata_imx: deny IRQ0 To: Sergey Shtylyov Cc: Jens Axboe , linux-ide@vger.kernel.org, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Hi Sergey, On Sun, Mar 21, 2021 at 3:59 PM Sergey Shtylyov wrote: > > If platform_get_irq() returns IRQ0 (considered invalid according to Linus) How can platform_get_irq() return 0 on i.MX? This driver only runs on imx31 and imx51 and in both platforms the PATA IRQ is non-zero. IMHO the current code is correct as-is. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C41A5C433C1 for ; Sun, 21 Mar 2021 19:09:53 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5965E6194C for ; Sun, 21 Mar 2021 19:09:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5965E6194C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D1p8CW2YqMWuL2lJg91mIXAG8cC1GO5Vi29FugggFj4=; b=C/2M1e65Kcv1MS+Fp6b4UQtDw TM80yxfouxQ/HmpC9ah9pqCEvezGvlZr8MoAPv7kK0pLdyBIPl0mQSS3Th6ckANQvjt55P6quRmA4 TO7Ox2CRI84fzSXN1PA5O+eECSpAxC6aY8cHzMfSQSLtbDhdHV2tWtGKWV/XqkU0knJBiQxjGt86a l7/QPBM0AEglCzml9lE0e0WFWIIjf0o8qJ6Ogz9xX03Xpi0sRk4yZ+/Y8K72i84iNTFdtAGj3850a s/Z+JmzQwG8+4O0U8kqKMo//+Wwmyd7gDIreq6TmZz8ximNlYgbnuIR7AF+SBA1rOoFbrm9rmQ7F1 0I47zPgqw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lO3Qv-00AH4V-6d; Sun, 21 Mar 2021 19:08:17 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lO3PI-00AGwU-TE for linux-arm-kernel@lists.infradead.org; Sun, 21 Mar 2021 19:06:57 +0000 Received: by mail-lf1-x12b.google.com with SMTP id b14so4665062lfv.8 for ; Sun, 21 Mar 2021 12:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XnGCJN74ODgPcebw1KK2VajqNNiVgQntWUbh05j1Gs4=; b=ConM0sdsCGRKS9xdbAVm/HVQQKn6HtsIYNcEnt8nCXXNqDzrkHgy7WQ7COMd4h9Kms ggCTmZtQwhOLG33qbRYsW+07dmEdtodoGO5Jb44jrTGsIw/koaVJfUH6AKFMMjOMdNfM LmFqhbjrYxmCETdlJpMJusQaGg+75gDUZYKUffxHAS54lqKzHa3LQhbA4/jBAuClWVGJ El05tnJbencJawsXRbHC45uLhlUMtKUL79v2sYPDyNGot26/uBcz31j1j/7c1m+H6mQ4 vRLuSACeg+kV6KXnf0FPPECcMThm0HOSy9Z7oaIZCWJWopJjqlPQB0Po3hS+vTkwuAkS Xt0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XnGCJN74ODgPcebw1KK2VajqNNiVgQntWUbh05j1Gs4=; b=aOitbyztsOWmwco9SMV8mSM3gpJrG5Iit5kCXnew5nUHZKQ6DVZUS/ETLFKQhh4unK bA8qXJJNQkKcUU6RGmNmh9CHF136zFVGcutUYS1B7PI3lEaz2jPBMjSDlPXyXE1mLVas IAiSUNbSu0vTSzxnuii2ipwlMRvg35NPh2nTXw8ABPtM4rBOmGJZCkqB4PrrpldupJR2 xTz21zNeNzzYJNUKiwmZxnA+qDN3h8Ui5ffVE1PC7nv9WUKtnJ5l/rxL/wEniQXkMjC1 /0PrMFXgp1W4l8Hf44278kiWrP0pqnKRmq13hB/TwXr/D+YZxeqElHqYiqlm1gPJGom9 ZgNQ== X-Gm-Message-State: AOAM5334BKlxmcOCl31dS5kenQI5j5tSekSPPVxLcGNVLdj+hxpVymhE rME9DbNOMvF1XleIZ0+AEdcWDea1Jtcwsr/8+vQ= X-Google-Smtp-Source: ABdhPJwkT2kzFj4bjY/jKrHaHA7YG+VjSUyX6bdLhkFg6pnrUKLw8ukDG3eiH6FlPOOBMDDHUI24sSO33zaNAwJYFrc= X-Received: by 2002:a05:6512:3996:: with SMTP id j22mr4563670lfu.443.1616353596107; Sun, 21 Mar 2021 12:06:36 -0700 (PDT) MIME-Version: 1.0 References: <2e552c36-84a5-a642-a8f0-1395f77a1a6a@omprussia.ru> In-Reply-To: From: Fabio Estevam Date: Sun, 21 Mar 2021 16:06:24 -0300 Message-ID: Subject: Re: [PATCH 4/4] pata_imx: deny IRQ0 To: Sergey Shtylyov Cc: Jens Axboe , linux-ide@vger.kernel.org, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210321_190639_774025_2827B65C X-CRM114-Status: UNSURE ( 8.36 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sergey, On Sun, Mar 21, 2021 at 3:59 PM Sergey Shtylyov wrote: > > If platform_get_irq() returns IRQ0 (considered invalid according to Linus) How can platform_get_irq() return 0 on i.MX? This driver only runs on imx31 and imx51 and in both platforms the PATA IRQ is non-zero. IMHO the current code is correct as-is. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel