All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Stefano Babic <sbabic@denx.de>,
	u-boot@lists.denx.de,  Anatolij Gustschin <agust@denx.de>,
	Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 2/6] arm: xea: Add support for reading SoM (CPU) and base board HW revision
Date: Thu, 28 Mar 2024 13:42:33 -0300	[thread overview]
Message-ID: <CAOMZO5DTc1S_HnHtVbNmUxswGMXV346gtBcVRutCdja52RMTpw@mail.gmail.com> (raw)
In-Reply-To: <20240328153415.3706637-3-lukma@denx.de>

Hi Lukasz,

On Thu, Mar 28, 2024 at 12:34 PM Lukasz Majewski <lukma@denx.de> wrote:

> +static inline u8 get_som_rev(void)

There is no need for 'inline' here.

Also, get_som_rev() is only used 5/6, so I suggest to squash this
patch with 5/6.

Besides that, the series looks good.

  reply	other threads:[~2024-03-28 16:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28 15:34 [PATCH 0/6] arm: xea: Provide enhancements for XEA board Lukasz Majewski
2024-03-28 15:34 ` [PATCH 1/6] arm: spl: xea: Remove I2S pins configuration from early initialization Lukasz Majewski
2024-03-28 15:34 ` [PATCH 2/6] arm: xea: Add support for reading SoM (CPU) and base board HW revision Lukasz Majewski
2024-03-28 16:42   ` Fabio Estevam [this message]
2024-03-28 15:34 ` [PATCH 3/6] arm: spl: Add definition for PHY reset GPIO for XEA HW rev. 2 Lukasz Majewski
2024-03-28 15:34 ` [PATCH 4/6] config: xea: Enable late board initialization to set revision variable Lukasz Majewski
2024-03-28 15:34 ` [PATCH 5/6] arm: xea: Print information about XEA's SoM HW revision Lukasz Majewski
2024-03-28 15:34 ` [PATCH 6/6] config: xea: Add limits for SPL and u-boot proper sizes Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5DTc1S_HnHtVbNmUxswGMXV346gtBcVRutCdja52RMTpw@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=agust@denx.de \
    --cc=lukma@denx.de \
    --cc=sbabic@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.