From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756889AbeDZRYa (ORCPT ); Thu, 26 Apr 2018 13:24:30 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:45163 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753282AbeDZRY1 (ORCPT ); Thu, 26 Apr 2018 13:24:27 -0400 X-Google-Smtp-Source: AIpwx49pdjcjLokNrrjQ8YkhzjAWdk4QGYF+zlzxQMya2cmcTdTsYVZ6LFMsWqu8Zub8rFb7+qAJnUwFFDOWKBbFU3Y= MIME-Version: 1.0 In-Reply-To: References: <1524634571-5914-1-git-send-email-Anson.Huang@nxp.com> <1524634571-5914-3-git-send-email-Anson.Huang@nxp.com> From: Fabio Estevam Date: Thu, 26 Apr 2018 14:24:26 -0300 Message-ID: Subject: Re: [PATCH V4 3/6] ARM: dts: imx6sx-sabreauto: add IO expander max7310 support To: Anson Huang Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , Rob Herring , Mark Rutland , Russell King - ARM Linux , dl-linux-imx , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 26, 2018 at 3:31 AM, Anson Huang wrote: > I searched the mail I sent, I can NOT found where I said "MAX7310 controls the ethernet phy".... Initially you passed: pinctrl-assert-gpios = <&max7322 0 GPIO_ACTIVE_HIGH> inside the fec1 node. Then I explained that 'pinctrl-assert-gpios' is not a valid property in mainline. It only exists in NXP vendor tree. Then you explained: "Sorry, I made a mistake here, the MAX7320 IO0 is for adjusting FEC1's voltage" > There are MAX7310 users, it is just because currently those users are NOT enabled, so I can > NOT verify them. MAX7310 is an independent I2C device, why we can NOT enable it first? > I tested it from sysfs interface, we can control the MAX7310's IO output via echo different value > to GPIO value, that means MAX7310 itself as an IO expander chip is working just fine, similar with PMIC, > it is a I2C device, can be enabled independently, then consumers can be added later when they are enabled. > Just my personal opinion, thanks. Right, but if FEC needs max7322 IO0 at level 1 then better describe it in dts. From mboxrd@z Thu Jan 1 00:00:00 1970 From: festevam@gmail.com (Fabio Estevam) Date: Thu, 26 Apr 2018 14:24:26 -0300 Subject: [PATCH V4 3/6] ARM: dts: imx6sx-sabreauto: add IO expander max7310 support In-Reply-To: References: <1524634571-5914-1-git-send-email-Anson.Huang@nxp.com> <1524634571-5914-3-git-send-email-Anson.Huang@nxp.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Apr 26, 2018 at 3:31 AM, Anson Huang wrote: > I searched the mail I sent, I can NOT found where I said "MAX7310 controls the ethernet phy".... Initially you passed: pinctrl-assert-gpios = <&max7322 0 GPIO_ACTIVE_HIGH> inside the fec1 node. Then I explained that 'pinctrl-assert-gpios' is not a valid property in mainline. It only exists in NXP vendor tree. Then you explained: "Sorry, I made a mistake here, the MAX7320 IO0 is for adjusting FEC1's voltage" > There are MAX7310 users, it is just because currently those users are NOT enabled, so I can > NOT verify them. MAX7310 is an independent I2C device, why we can NOT enable it first? > I tested it from sysfs interface, we can control the MAX7310's IO output via echo different value > to GPIO value, that means MAX7310 itself as an IO expander chip is working just fine, similar with PMIC, > it is a I2C device, can be enabled independently, then consumers can be added later when they are enabled. > Just my personal opinion, thanks. Right, but if FEC needs max7322 IO0 at level 1 then better describe it in dts.