From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48870CA9ECE for ; Thu, 31 Oct 2019 12:07:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18C5B2087F for ; Thu, 31 Oct 2019 12:07:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sWvZD90G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726675AbfJaMHQ (ORCPT ); Thu, 31 Oct 2019 08:07:16 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:35388 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726462AbfJaMHP (ORCPT ); Thu, 31 Oct 2019 08:07:15 -0400 Received: by mail-lf1-f66.google.com with SMTP id y6so4458537lfj.2; Thu, 31 Oct 2019 05:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yLdb6BKKsBwdTyCqC3oQr2+bLOSWyaoFNjx8aaET/HU=; b=sWvZD90G57wEHYe8Pgdv+Opt8LMv8QJ47fYyZyYAqKyVohLypEc/k5xmxMYQrtVhtg c4+Gv2vRm4USOBpQChSEyz9IopS/XX8Nl1yar4DVdPV/s63tDtR0oHYJXqRA6DA/S5Ti 5QJLHveP0STTYEV8W4SiS2rMZRRbomLtlf3r3x7hKsrL8J5fXJ5yPcKx4qSkYCnygOao PYBgSFir3lDNXeZ4NFHEwNj6yQMg1E4ihqoD2GKV5gFuNBcwxomAEOl1gqaw8ejkLIAu VgzS0eFF6O9yCe6NhWxr1UoK1QHd182uEFLpuvx7FW1l55L/61MnXJIF7FzMvumAECoz 7D4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yLdb6BKKsBwdTyCqC3oQr2+bLOSWyaoFNjx8aaET/HU=; b=tuZei9Ej0whXIYZFMNL1Reo5T3TnoTWEUjXE71W+71juRHowwrVEpAM1tcqruWxjL9 VswSkXXCgYlbruRdXsuAiqmJ3JLIn3H5h5YUla+Lu136dK2IfEt8jM1U5NVmylLSLQdS EBvfRIDWOlUMMbJVuaEdWBLJRBoeLS7pUMiMXey9INLj3wSMJsJjiWL41+3ngt8NGXXX U7GCOPIMf9UWue2+FSVGhh0oHfW+SOZCt0G+U8litx9mZYb8IaHYmNOKPxj/tgmEWVYT slO7in9Bsuncuj9NVq5jLfjY6gW90jxUsEzjltPaePmbWyskx5K6GOemZtXxC/Azr5eh f/LQ== X-Gm-Message-State: APjAAAWSfxbXf9WfON9S9FNGNhl3mhazPNtj0tA7BOjfAZR3Hk7qVpjd mSOOmwZI8plVID75rbRtKtpyUIqc0Mj1yf+GsPc= X-Google-Smtp-Source: APXvYqzouS1Q1he9V4ma5fFVHYkpzWmxxcN5v9/+VSFY+GMtwPnz/Rhj664y3z7SNUmnvg/zabQ+BfeH/1fUBA55JkM= X-Received: by 2002:ac2:4564:: with SMTP id k4mr3360446lfm.20.1572523633629; Thu, 31 Oct 2019 05:07:13 -0700 (PDT) MIME-Version: 1.0 References: <1572515888-3385-1-git-send-email-peng.fan@nxp.com> <1572515888-3385-3-git-send-email-peng.fan@nxp.com> In-Reply-To: <1572515888-3385-3-git-send-email-peng.fan@nxp.com> From: Fabio Estevam Date: Thu, 31 Oct 2019 09:07:22 -0300 Message-ID: Subject: Re: [PATCH 2/2] clk: imx: imx7d: remove clk_set_parent To: Peng Fan Cc: "sboyd@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , Abel Vesa , "kernel@pengutronix.de" , dl-linux-imx , Anson Huang , Jacky Bai , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Leonard Crestez Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peng, On Thu, Oct 31, 2019 at 7:02 AM Peng Fan wrote: > > From: Peng Fan > > Since the set parent could be done by assigned-clock-parents in > dts, so no need clk_set_parent in driver. It looks like this will cause breakage if someone is using an old dtb, right? We try not to break existing dtbs. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC92CCA9EC3 for ; Thu, 31 Oct 2019 12:07:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABB13208E3 for ; Thu, 31 Oct 2019 12:07:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ixkuY4fw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sWvZD90G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABB13208E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZJXzo6OkNlGASqg7wVlYW5VhwUcQCKe65pthsjroj3w=; b=ixkuY4fwEE88EY 1tKoBcTFfvs/Q1F+0TBdCGonH78O5luDkcKacrryv1ob0lzApVpESnRLhzFmYS45D9lXbMBX+2sH2 5BZ5D2oDSQ30rqJEdMUcTQncl7XlNYLg0/gx2pKIHwFRejlEhs+/pQynftsNQ5rixMB/b90Y9o6Cf d8XRl8YxaOM700UGc1d2fWwYmbnETFMqid/VTZDaCi//NRpBPO0+L4oc4wkWsdrXbbIvXXBaT9wSu cM3Vdyxiq1wjZ7vl0tsTavTPgvUrrk75dx2eLF5S75j5I3X+JM3pzSAOJdQcRKZMNF0jqpeSRuFv9 TsQvQyhEt2edPOtupNZg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQ9EV-0006G3-Ag; Thu, 31 Oct 2019 12:07:19 +0000 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQ9ER-0006FG-Pq for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2019 12:07:17 +0000 Received: by mail-lf1-x143.google.com with SMTP id y6so4458539lfj.2 for ; Thu, 31 Oct 2019 05:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yLdb6BKKsBwdTyCqC3oQr2+bLOSWyaoFNjx8aaET/HU=; b=sWvZD90G57wEHYe8Pgdv+Opt8LMv8QJ47fYyZyYAqKyVohLypEc/k5xmxMYQrtVhtg c4+Gv2vRm4USOBpQChSEyz9IopS/XX8Nl1yar4DVdPV/s63tDtR0oHYJXqRA6DA/S5Ti 5QJLHveP0STTYEV8W4SiS2rMZRRbomLtlf3r3x7hKsrL8J5fXJ5yPcKx4qSkYCnygOao PYBgSFir3lDNXeZ4NFHEwNj6yQMg1E4ihqoD2GKV5gFuNBcwxomAEOl1gqaw8ejkLIAu VgzS0eFF6O9yCe6NhWxr1UoK1QHd182uEFLpuvx7FW1l55L/61MnXJIF7FzMvumAECoz 7D4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yLdb6BKKsBwdTyCqC3oQr2+bLOSWyaoFNjx8aaET/HU=; b=r+3zlw9t5FZnZ1TOyq4CG2spM4gVhvgFpXPVLvXLrcYHgsueOyyMaA6C0ji98/Yygz Aki1SRbuqbSm7zxmt84VAoXamSt4ljI70viiZPb6aeoFdnAZJYhYxKe5uHwqgpjLKmkY DpTz+rTFwQD8Yx/q05ltiItzMQZounv/e7On6lzOgIJ9u1K9wByrBYSaGqoSZKG090xI SzNKqFiZ4iPhsEcTLEjKBFBhyiZyZi75kw0NI1QiehMcYud7tRN2dFvXKj1seTVZd9yf tJCAmEzvR1YFt+YFvB7MJn7ic+GMlUNcEx1nalryqgmeEMWrQPU4T6LLHU5phG/r2f7o CTQQ== X-Gm-Message-State: APjAAAWWyR+TSu4wX1SOiKRKLXwqlGtV816GhKwkTHQLTflJUw0+RN7+ o/prrf1GSb2gHo7uLQMd9ueFQtnWZIEtPqTRhGo= X-Google-Smtp-Source: APXvYqzouS1Q1he9V4ma5fFVHYkpzWmxxcN5v9/+VSFY+GMtwPnz/Rhj664y3z7SNUmnvg/zabQ+BfeH/1fUBA55JkM= X-Received: by 2002:ac2:4564:: with SMTP id k4mr3360446lfm.20.1572523633629; Thu, 31 Oct 2019 05:07:13 -0700 (PDT) MIME-Version: 1.0 References: <1572515888-3385-1-git-send-email-peng.fan@nxp.com> <1572515888-3385-3-git-send-email-peng.fan@nxp.com> In-Reply-To: <1572515888-3385-3-git-send-email-peng.fan@nxp.com> From: Fabio Estevam Date: Thu, 31 Oct 2019 09:07:22 -0300 Message-ID: Subject: Re: [PATCH 2/2] clk: imx: imx7d: remove clk_set_parent To: Peng Fan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191031_050715_862801_D63FEDFD X-CRM114-Status: UNSURE ( 7.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Abel Vesa , Anson Huang , "sboyd@kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , Leonard Crestez , "shawnguo@kernel.org" , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jacky Bai Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peng, On Thu, Oct 31, 2019 at 7:02 AM Peng Fan wrote: > > From: Peng Fan > > Since the set parent could be done by assigned-clock-parents in > dts, so no need clk_set_parent in driver. It looks like this will cause breakage if someone is using an old dtb, right? We try not to break existing dtbs. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel