From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AB0DC49361 for ; Fri, 18 Jun 2021 11:20:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66D9561351 for ; Fri, 18 Jun 2021 11:20:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233996AbhFRLXB (ORCPT ); Fri, 18 Jun 2021 07:23:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231240AbhFRLXA (ORCPT ); Fri, 18 Jun 2021 07:23:00 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FE48C061574 for ; Fri, 18 Jun 2021 04:20:51 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id j2so16104398lfg.9 for ; Fri, 18 Jun 2021 04:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hnZIrqamucMgtoQRhalXW35f06vviRSLKNiJcGvVIRY=; b=PR0QsGfN3ZzRnmtP2GvpRBUfh1fS2bB3MVYoqYFIfQ5y3OtmE1H4Bi5MkHfwqNstN+ sIdovZvPvvNyNOOE84n6c+/whP9ME8CgCVKNDFDjbmCLV/SJ/Osrr5Dk9vUiGGGnRgDT Ulj6kyWju4RyjfaUCvhazK66qs0HhwQiFm/0qOB73JXbK8ooV/OSn1wJ3huEN347SYDR g7efyEFPYMBD3p1dbqv+kUsjK5w+L+Ckz33klkhIfqGxyD2HDtU2rRw3BvWSw+bnjNdW UQMvQqLSCSV/OqCc61vs4BlSEazhXwNbCMfH6PNCYuVL6dI6ovqzpBzkfjzQve886+lL VksA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hnZIrqamucMgtoQRhalXW35f06vviRSLKNiJcGvVIRY=; b=Ik5cGo2fePRA+SDi6bd3l4GVvwKIIgl4jWqrboUVBGbh3EmVOpkj8f43nYe2ZdM0aX d6ne8w/6Y/DN+HfIiUL9ulM8yy9rDzR2f4chEsOjbVCig81xJnk1jTMSwzgjYxqpi9AD hYguH8+44PDpndFfvshHYXzirFsza703xqBPLfZi3Ws1Kivk0NSt6OlSFNz8Siy8XZau xcYL1DnFXGZ+kAE99twpefDEBVgBlPi0vQZVOFdTqf9bRezD7wgrwbZkXB3B+hPJOuU6 3e5TO2HGIaBstXkf6hhA5xxHDkmbgyT9wYvHkonFEzlpdJBVFLsdI7Cfex3P2zezDeyt 94hw== X-Gm-Message-State: AOAM531nkyC8tre38yJ8f6kkNkBx5c2Yseg+ppC6xIEiRgl15svz3tgk sx/JMk7DRr9BbUuStl1eVQ+dQT0GfZSxfcKjICU= X-Google-Smtp-Source: ABdhPJyIeUNC0wnC3kJcXj8pUsII7RDjnztdAY6DS/4xUuhjoSVZ1NjwJYq3BaF++8TyxD1naFh8F7l7is0XL2Dbiq8= X-Received: by 2002:a05:6512:15a4:: with SMTP id bp36mr2830068lfb.539.1624015249338; Fri, 18 Jun 2021 04:20:49 -0700 (PDT) MIME-Version: 1.0 References: <1624009876-3076-1-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: <1624009876-3076-1-git-send-email-shengjiu.wang@nxp.com> From: Fabio Estevam Date: Fri, 18 Jun 2021 08:20:38 -0300 Message-ID: Subject: Re: [PATCH] ASoC: fsl_xcvr: disable all interrupts when suspend happens To: Shengjiu Wang Cc: Timur Tabi , Nicolin Chen , Xiubo Li , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linux-ALSA , linuxppc-dev@lists.ozlabs.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shengjiu, On Fri, Jun 18, 2021 at 7:10 AM Shengjiu Wang wrote: > > There is an unhandled interrupt after suspend, which cause endless > interrupt when system resume, so system may hang. > > Disable all interrupts in runtime suspend callback to avoid above > issue. Fixe tag? > + ret = regmap_update_bits(xcvr->regmap, FSL_XCVR_EXT_IER0, > + FSL_XCVR_IRQ_EARC_ALL, 0); > + if (ret < 0) > + dev_err(dev, "Failed to clear IER0: %d\n", ret); > + The operations in _suspend() are usually balanced with the ones in _resume(). Shouldn't you enable the interrupts in resume() then? I see that the interrupts are currently enabled inside fsl_xcvr_prepare(). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62385C48BE8 for ; Fri, 18 Jun 2021 11:21:50 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC5D96112D for ; Fri, 18 Jun 2021 11:21:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC5D96112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 899BD16DD; Fri, 18 Jun 2021 13:20:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 899BD16DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1624015306; bh=svKPLcM0vSqx7JJ/aHs3yHiAH5Ixje4VFmN+cxVxM4g=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=K5BYL2cQt6P4QG8IAVhC6xJl9lGI97/yega35HwrB+Y7vmLrznGdaNzQ1F8inwal0 tc5hd6Gp+Gpg0drD61Lcm/N5PY/QxEd4fsY9Nt2SSKGlBWfJSJb65ssMfrZy210/tt J//D5jwmTRL7Gz1OYjGZieSI4ePfBD5SWYZq065U= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 24766F802E8; Fri, 18 Jun 2021 13:20:56 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E9C47F8032D; Fri, 18 Jun 2021 13:20:54 +0200 (CEST) Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EDBD1F80084 for ; Fri, 18 Jun 2021 13:20:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EDBD1F80084 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PR0QsGfN" Received: by mail-lf1-x12a.google.com with SMTP id m21so16051376lfg.13 for ; Fri, 18 Jun 2021 04:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hnZIrqamucMgtoQRhalXW35f06vviRSLKNiJcGvVIRY=; b=PR0QsGfN3ZzRnmtP2GvpRBUfh1fS2bB3MVYoqYFIfQ5y3OtmE1H4Bi5MkHfwqNstN+ sIdovZvPvvNyNOOE84n6c+/whP9ME8CgCVKNDFDjbmCLV/SJ/Osrr5Dk9vUiGGGnRgDT Ulj6kyWju4RyjfaUCvhazK66qs0HhwQiFm/0qOB73JXbK8ooV/OSn1wJ3huEN347SYDR g7efyEFPYMBD3p1dbqv+kUsjK5w+L+Ckz33klkhIfqGxyD2HDtU2rRw3BvWSw+bnjNdW UQMvQqLSCSV/OqCc61vs4BlSEazhXwNbCMfH6PNCYuVL6dI6ovqzpBzkfjzQve886+lL VksA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hnZIrqamucMgtoQRhalXW35f06vviRSLKNiJcGvVIRY=; b=rk3KHM2wRY3UfEmLSv5S05rTyg1ReDzOeINGXuj83iqxm+w9G0asIjY7dvAsaIWRoQ 9Hs6dburGKTlOiBdCsJGGQfphQwpZnM7j8d8/8yMQ7qrNPsVTboa5x1gysFRLQcFK6Tj my5eYwWbVdlZ2aXu8wnQJW9XyqxWgg0ryq50SGobtlO/3fQ+yqBjlks7P/oYuhdbwEen y/h6+DCM4m5qQ5QYyy5Ha5onFrA4q4h1ZvAAmXgRgAAD3esymrK4O0vRmc+07BUEIaQN 4wtH5o6JxkZ5ZD4ALkz4p6+VguEkckk37waWiwB8wMfDleoeXeG5GMVvMXSNOIm2kt7U zd8g== X-Gm-Message-State: AOAM530c+YKWYMVFRGSEpd+0uSj4ddEmpb/eHpBtjzFHePefr33rRDSq aQxkQtOTU2hiojxdwE3fpxQzSsSAWFDlffRi810= X-Google-Smtp-Source: ABdhPJyIeUNC0wnC3kJcXj8pUsII7RDjnztdAY6DS/4xUuhjoSVZ1NjwJYq3BaF++8TyxD1naFh8F7l7is0XL2Dbiq8= X-Received: by 2002:a05:6512:15a4:: with SMTP id bp36mr2830068lfb.539.1624015249338; Fri, 18 Jun 2021 04:20:49 -0700 (PDT) MIME-Version: 1.0 References: <1624009876-3076-1-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: <1624009876-3076-1-git-send-email-shengjiu.wang@nxp.com> From: Fabio Estevam Date: Fri, 18 Jun 2021 08:20:38 -0300 Message-ID: Subject: Re: [PATCH] ASoC: fsl_xcvr: disable all interrupts when suspend happens To: Shengjiu Wang Content-Type: text/plain; charset="UTF-8" Cc: Linux-ALSA , Timur Tabi , Xiubo Li , linux-kernel , Takashi Iwai , Nicolin Chen , Mark Brown , linuxppc-dev@lists.ozlabs.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Shengjiu, On Fri, Jun 18, 2021 at 7:10 AM Shengjiu Wang wrote: > > There is an unhandled interrupt after suspend, which cause endless > interrupt when system resume, so system may hang. > > Disable all interrupts in runtime suspend callback to avoid above > issue. Fixe tag? > + ret = regmap_update_bits(xcvr->regmap, FSL_XCVR_EXT_IER0, > + FSL_XCVR_IRQ_EARC_ALL, 0); > + if (ret < 0) > + dev_err(dev, "Failed to clear IER0: %d\n", ret); > + The operations in _suspend() are usually balanced with the ones in _resume(). Shouldn't you enable the interrupts in resume() then? I see that the interrupts are currently enabled inside fsl_xcvr_prepare(). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7B61C48BDF for ; Fri, 18 Jun 2021 11:21:29 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14FAD61248 for ; Fri, 18 Jun 2021 11:21:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14FAD61248 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4G5xMD1jVTz3c60 for ; Fri, 18 Jun 2021 21:21:28 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=PR0QsGfN; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::132; helo=mail-lf1-x132.google.com; envelope-from=festevam@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=PR0QsGfN; dkim-atps=neutral Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4G5xLh4fr8z3bx3 for ; Fri, 18 Jun 2021 21:20:59 +1000 (AEST) Received: by mail-lf1-x132.google.com with SMTP id p7so16008840lfg.4 for ; Fri, 18 Jun 2021 04:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hnZIrqamucMgtoQRhalXW35f06vviRSLKNiJcGvVIRY=; b=PR0QsGfN3ZzRnmtP2GvpRBUfh1fS2bB3MVYoqYFIfQ5y3OtmE1H4Bi5MkHfwqNstN+ sIdovZvPvvNyNOOE84n6c+/whP9ME8CgCVKNDFDjbmCLV/SJ/Osrr5Dk9vUiGGGnRgDT Ulj6kyWju4RyjfaUCvhazK66qs0HhwQiFm/0qOB73JXbK8ooV/OSn1wJ3huEN347SYDR g7efyEFPYMBD3p1dbqv+kUsjK5w+L+Ckz33klkhIfqGxyD2HDtU2rRw3BvWSw+bnjNdW UQMvQqLSCSV/OqCc61vs4BlSEazhXwNbCMfH6PNCYuVL6dI6ovqzpBzkfjzQve886+lL VksA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hnZIrqamucMgtoQRhalXW35f06vviRSLKNiJcGvVIRY=; b=rscCQDaBKspak6yXxnJ69IGMiQiYJ8d96LSA5vaZADymDNY3c7CX5w2MUgPB8w3R7Y fYlG60dro9rZ37+G+saVJC1f9lyG9mIZcQmfyQJ45Wi2ry/vZQrNk5I3uvHzD/l7VzM3 udSdwW+Y3TKoNnro+4IV9Q4RAgbBh9/027CueGbqLcAZ3pX8wQ9px09W9bc9+DQkF3rH sqyhl7voFOX8W39BZgpVzrnSpvtilFeypVRvnFXWUeyC9DvkzuR0DuUy0FrxDjmhkpsy vxeBY/UhrQ9At1nFr7FbAK2QwjjXKkqxLp5f6h7x0j/KGIFyx1tOqdUdZu2v66aAJw45 WdWg== X-Gm-Message-State: AOAM533MjQpzIbEgTKf3Zdwdk50lMwDs8hPI+w+5s5hCunfjXddLy/k8 shMl0DBYgwhGh7b66YOXlc0UF/MI/QCAnGbOCgA= X-Google-Smtp-Source: ABdhPJyIeUNC0wnC3kJcXj8pUsII7RDjnztdAY6DS/4xUuhjoSVZ1NjwJYq3BaF++8TyxD1naFh8F7l7is0XL2Dbiq8= X-Received: by 2002:a05:6512:15a4:: with SMTP id bp36mr2830068lfb.539.1624015249338; Fri, 18 Jun 2021 04:20:49 -0700 (PDT) MIME-Version: 1.0 References: <1624009876-3076-1-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: <1624009876-3076-1-git-send-email-shengjiu.wang@nxp.com> From: Fabio Estevam Date: Fri, 18 Jun 2021 08:20:38 -0300 Message-ID: Subject: Re: [PATCH] ASoC: fsl_xcvr: disable all interrupts when suspend happens To: Shengjiu Wang Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-ALSA , Timur Tabi , Xiubo Li , linux-kernel , Takashi Iwai , Jaroslav Kysela , Nicolin Chen , Mark Brown , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Shengjiu, On Fri, Jun 18, 2021 at 7:10 AM Shengjiu Wang wrote: > > There is an unhandled interrupt after suspend, which cause endless > interrupt when system resume, so system may hang. > > Disable all interrupts in runtime suspend callback to avoid above > issue. Fixe tag? > + ret = regmap_update_bits(xcvr->regmap, FSL_XCVR_EXT_IER0, > + FSL_XCVR_IRQ_EARC_ALL, 0); > + if (ret < 0) > + dev_err(dev, "Failed to clear IER0: %d\n", ret); > + The operations in _suspend() are usually balanced with the ones in _resume(). Shouldn't you enable the interrupts in resume() then? I see that the interrupts are currently enabled inside fsl_xcvr_prepare().