From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Subject: Re: [PATCH] pinctrl: imx: make sure that maps are fully initialized Date: Mon, 12 Nov 2018 13:09:26 -0200 Message-ID: References: <1541871439-4882-1-git-send-email-martin@kaiser.cx> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dong Aisheng Cc: Martin Kaiser , Shawn Guo , Stefan Agner , Sascha Hauer , Linus Walleij , "open list:GPIO SUBSYSTEM" , linux-kernel , Leonard Crestez List-Id: linux-gpio@vger.kernel.org Hi Dong, On Mon, Nov 12, 2018 at 1:04 PM A.s. Dong wrote: > Thanks for reporting this issue. > The original code intended to save 3 common lines for both SCU and MMIO pads, > but it did change the code logic a bit which resulted in a regression specificly > for NO_PAD_CTL cases used on a few legacy boards. (NO_PAD_CTL is deprecated > for new boards dts). Just a clarification: NO_PAD_CTL is not deprecated. It is not recommended for new dts as we should not rely on the bootloader pinctrl settings. > As you both had a patch, i'm not sure who i'm going to expect for a updated one, > so I would send it my own with both of your tags. Yes, please send a patch putting a Reported-by tag from Martin and a Suggested-by tag from Leonard. Thanks