From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8624C433EF for ; Wed, 17 Nov 2021 14:41:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EA4361BCF for ; Wed, 17 Nov 2021 14:41:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238710AbhKQOop (ORCPT ); Wed, 17 Nov 2021 09:44:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233131AbhKQOom (ORCPT ); Wed, 17 Nov 2021 09:44:42 -0500 Received: from mail-vk1-xa29.google.com (mail-vk1-xa29.google.com [IPv6:2607:f8b0:4864:20::a29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76BDFC061570; Wed, 17 Nov 2021 06:41:43 -0800 (PST) Received: by mail-vk1-xa29.google.com with SMTP id d130so1827294vke.0; Wed, 17 Nov 2021 06:41:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aQX8G7rKHKZpQg48Q5MVfIqJ7w7XTW5bUNjp+OA8epI=; b=pMaVYoNziyx91tIqKDpmfA1rvzysvj9AE6tuddjG6iKNtXx/lW/n36v+UGgHq5vKUt SS8Il5Gv7NvjuRu1MASBDQDJdQX2EV9P307lFq0fyps9KKWU102O97l8c4DLGfA8oNUb m4PG8RN0EisgBYWCKsI6DNGDtgOUn9+1P6R/HH8nIQvVsu2P6idJ01WZ5Gn9EJCLKG0F TBuYlVegMOZNRrrMYmTlw5Xjm8Uwmod7tZUlqqPVcqXbwnxlP59VrE14oa/6EdS3Rhd9 Br0ibo8pZHVIteHwZyEa2hIAYAtlfXHwbKZFadnVYZb7QmAdqg0674oJh79grhCYNAip cWmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aQX8G7rKHKZpQg48Q5MVfIqJ7w7XTW5bUNjp+OA8epI=; b=gkgNUVid97V7lyzpm7cbkjgOXZqY6wZa0anrRE2YL0UEP/YFNGeXUptveOYYLCtZsZ 1S6nmjwqhpEf8a95KXpyeU4DXbWzgnRPRnD4eFUDIKUBAKMileMtKitlykW89pnzlh4i P71Gnp5JGHZhjODxzihaytl7Ok/QkX+TOfmd8uq6T3QlsGQRNUDQJypQtpVYjUxFD95I weaPqnoja7qrC/ZegjB9L1l59sm/7mZbK6MIBXC1UNrt3tl8mhEtko11jihgaY11rhV9 sZNPXp1YQOx8JSzEaiooA5RGDnyn7qLWqUKthmEETd8uezU71fvPyiC+rMhh1p/mUt3T 8tqA== X-Gm-Message-State: AOAM5330IyK5SYo326cLuSUVv0ydNZbLclY/xzuO5tGCEcnS/NpM7nEv 4QMW1rOTe2n6Elaa8EhyWjXi42wmIuVESqMx+GQ= X-Google-Smtp-Source: ABdhPJwkgwfg9vWaWtU0OosC5rdhZC3+RSAz0/4plgC3o++3h8wcVw0CbJO3vSK9W9mlwjRknryDJMg2DiycQX81KdA= X-Received: by 2002:a1f:9158:: with SMTP id t85mr89356241vkd.8.1637160102615; Wed, 17 Nov 2021 06:41:42 -0800 (PST) MIME-Version: 1.0 References: <20211117133202.775633-1-aford173@gmail.com> In-Reply-To: <20211117133202.775633-1-aford173@gmail.com> From: Fabio Estevam Date: Wed, 17 Nov 2021 11:41:32 -0300 Message-ID: Subject: Re: [PATCH] clk: imx8mn: Fix imx8mn_clko1_sels To: Adam Ford Cc: linux-clk , Adam Ford-BE , cstevens@beaconembedded.com, Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Anson Huang , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 17, 2021 at 10:32 AM Adam Ford wrote: > > When attempting to use sys_pll1_80m as the parent for clko1, the > system hangs. This is due to the fact that the source select > for sys_pll1_80m was incorrectly pointing to m7_alt_pll_clk, which > doesn't yet exist. > > According to Rev 3 of the TRM, The imx8mn_clko1_sels also incorrectly > references an osc_27m which does not exist, nor does an entry for > source select bits 010b. Fix both by inserting a dummy clock into > the missing space in the table and renaming the incorrectly name clock > with dummy. > > Fixes: 96d6392b54db ("clk: imx: Add support for i.MX8MN clock driver") > Signed-off-by: Adam Ford Reviewed-by: Fabio Estevam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CD15C433F5 for ; Wed, 17 Nov 2021 14:43:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 457FC61266 for ; Wed, 17 Nov 2021 14:43:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 457FC61266 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zs78aFW4xzDdecqqQ9Qd+Nb5Osxg7HxAu4+cEpH3zWY=; b=pOA7LaLnsdW4Ih oBOs8k1ozmjVWw6pwxGqyspESeO4dkCL6MqKeZa3rfzEqwXXMs2wchRJ7rs3vjIIuv5dkioFcNOWP 0uX8rvn/c9ID7+C5g4arIwC7+dj6DVQp3Q8Cr+mBkoaKAFGa9ONZMxw4WbA9GbHL7MgoDWm8u+IsB Fb+v0OgwUBKI6bcfG7KBMgyjQCD05Q6B1z/CqyHOYzEE1eVeU2a2JHCeHGPaY1tks//NmF2roP+7Z 055Sdni7n9oiGRjhjWDgY96OJb5RHinQ+tM84I+zZz0Kgy4IMjMNL2PTUOROmXHaSzL4PRWRGl52W 6KsQeqq3yZYHy3PLEQ8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnM8N-005BSD-OX; Wed, 17 Nov 2021 14:42:01 +0000 Received: from mail-vk1-xa2f.google.com ([2607:f8b0:4864:20::a2f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnM88-005BOd-M8 for linux-arm-kernel@lists.infradead.org; Wed, 17 Nov 2021 14:41:46 +0000 Received: by mail-vk1-xa2f.google.com with SMTP id t127so1744420vke.13 for ; Wed, 17 Nov 2021 06:41:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aQX8G7rKHKZpQg48Q5MVfIqJ7w7XTW5bUNjp+OA8epI=; b=pMaVYoNziyx91tIqKDpmfA1rvzysvj9AE6tuddjG6iKNtXx/lW/n36v+UGgHq5vKUt SS8Il5Gv7NvjuRu1MASBDQDJdQX2EV9P307lFq0fyps9KKWU102O97l8c4DLGfA8oNUb m4PG8RN0EisgBYWCKsI6DNGDtgOUn9+1P6R/HH8nIQvVsu2P6idJ01WZ5Gn9EJCLKG0F TBuYlVegMOZNRrrMYmTlw5Xjm8Uwmod7tZUlqqPVcqXbwnxlP59VrE14oa/6EdS3Rhd9 Br0ibo8pZHVIteHwZyEa2hIAYAtlfXHwbKZFadnVYZb7QmAdqg0674oJh79grhCYNAip cWmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aQX8G7rKHKZpQg48Q5MVfIqJ7w7XTW5bUNjp+OA8epI=; b=SOwNMhvZ+GQVhvZrf+tpEb++Invpt1vpv6G9wH6Z4Mr9yHLs2xKb/WBAQ5LxYG+s/d AGj8heU3krng8AZyiQPjxfKIl/oZY+ri6mKYyJ453mnxAyv5WqrCQO5GvUi1bXBQdH6U 2CmBrhOs+IZbW9bqdgGBUD30uqEcHOFPJGFwUXP9WjuXRvUupdD8h0q3n0sfpsfePj2f /f9Gn4JI4ERQ520zBLp0UT99PrbvOatQUSuUN+jFiDjvG98dfNvzNCNHiTkUZRwfV1az z+1yeJsF18GKeEKNjHZPdG2zZG5ugQ2FozvKHj46OjzogEwBwo1VtaDjo+6QBm7ga7QD y9JQ== X-Gm-Message-State: AOAM531MRosxoMotpfGHHuTwIGDQrsYfdAi5FHCLX9lFtf1KOJgaKjsr dHiLYzgf2UYbz6U5VPdxSkbqxu7tJcP2TaucnXw= X-Google-Smtp-Source: ABdhPJwkgwfg9vWaWtU0OosC5rdhZC3+RSAz0/4plgC3o++3h8wcVw0CbJO3vSK9W9mlwjRknryDJMg2DiycQX81KdA= X-Received: by 2002:a1f:9158:: with SMTP id t85mr89356241vkd.8.1637160102615; Wed, 17 Nov 2021 06:41:42 -0800 (PST) MIME-Version: 1.0 References: <20211117133202.775633-1-aford173@gmail.com> In-Reply-To: <20211117133202.775633-1-aford173@gmail.com> From: Fabio Estevam Date: Wed, 17 Nov 2021 11:41:32 -0300 Message-ID: Subject: Re: [PATCH] clk: imx8mn: Fix imx8mn_clko1_sels To: Adam Ford Cc: linux-clk , Adam Ford-BE , cstevens@beaconembedded.com, Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Anson Huang , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , open list X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211117_064144_765055_E4A77858 X-CRM114-Status: GOOD ( 12.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 17, 2021 at 10:32 AM Adam Ford wrote: > > When attempting to use sys_pll1_80m as the parent for clko1, the > system hangs. This is due to the fact that the source select > for sys_pll1_80m was incorrectly pointing to m7_alt_pll_clk, which > doesn't yet exist. > > According to Rev 3 of the TRM, The imx8mn_clko1_sels also incorrectly > references an osc_27m which does not exist, nor does an entry for > source select bits 010b. Fix both by inserting a dummy clock into > the missing space in the table and renaming the incorrectly name clock > with dummy. > > Fixes: 96d6392b54db ("clk: imx: Add support for i.MX8MN clock driver") > Signed-off-by: Adam Ford Reviewed-by: Fabio Estevam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel