From: Fabio Estevam <festevam@gmail.com>
To: Robert Chiras <robert.chiras@nxp.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"sam@ravnborg.org" <sam@ravnborg.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"airlied@linux.ie" <airlied@linux.ie>
Subject: Re: [EXT] Re: [PATCH 2/2] drm/panel: Add support for Raydium RM67191 panel driver
Date: Fri, 14 Jun 2019 10:39:53 -0300 [thread overview]
Message-ID: <CAOMZO5DcvKQPDhP468VSCfQkFy-7roKBkw7uqXxTMn9PTTgS+A@mail.gmail.com> (raw)
In-Reply-To: <1560518953.9328.31.camel@nxp.com>
On Fri, Jun 14, 2019 at 10:29 AM Robert Chiras <robert.chiras@nxp.com> wrote:
> The GPIO is active high, and the above sequence was received from the
> panel vendor in the following form:
> SET_RESET_PIN(1);
> MDELAY(10);
> SET_RESET_PIN(0);
> MDELAY(5);
> SET_RESET_PIN(1);
> MDELAY(20);
> I got rid of the first transition to high since seemed redundant.
> Also, according to the manual reference, the RSTB pin needs to be
> active high while operating the display.
That's exactly my point :-)
In normal operation the GPIO reset needs to be high.
During reset the GPIO reset needs to be low., which means that the
GPIO reset is "active low".
So you should invert both the dts and the driver to behave correctly.
next prev parent reply other threads:[~2019-06-14 13:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 11:51 [PATCH 0/2] Add DSI panel driver for Raydium RM67191 Robert Chiras
2019-06-14 11:51 ` [PATCH 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel Robert Chiras
2019-06-14 12:59 ` Fabio Estevam
2019-06-14 12:59 ` Fabio Estevam
2019-06-14 13:40 ` [EXT] " Robert Chiras
2019-06-14 11:51 ` [PATCH 2/2] drm/panel: Add support for Raydium RM67191 panel driver Robert Chiras
2019-06-14 12:03 ` Daniel Baluta
2019-06-14 12:27 ` Fabio Estevam
2019-06-14 12:27 ` Fabio Estevam
2019-06-14 13:29 ` [EXT] " Robert Chiras
2019-06-14 13:39 ` Fabio Estevam [this message]
2019-06-14 13:50 ` Robert Chiras
2019-06-14 15:10 ` Sam Ravnborg
2019-06-14 15:10 ` Sam Ravnborg
2019-06-18 7:21 ` [EXT] " Robert Chiras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5DcvKQPDhP468VSCfQkFy-7roKBkw7uqXxTMn9PTTgS+A@mail.gmail.com \
--to=festevam@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robert.chiras@nxp.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.