From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81A6DC433FE for ; Mon, 16 May 2022 12:08:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236619AbiEPMIf (ORCPT ); Mon, 16 May 2022 08:08:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231824AbiEPMIc (ORCPT ); Mon, 16 May 2022 08:08:32 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8264D25C6A; Mon, 16 May 2022 05:08:31 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id kq17so28238562ejb.4; Mon, 16 May 2022 05:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZnOxnQcb4Fu3paGsTHPyp7sfC5DipN/N3rq9yeMMHF4=; b=iU1ciYcrfm2hMbbA52EonHWO4UjvozsZo9+atKivTNQ0QJ4F3eIkjAW4/BuByThOU+ sXRbHpxeUKIUgcDA6a7DmyP6LDS04X8smMgARYnV7sGmCPvwT4PPhDXJuFt01vtzu6Yt wx2/z3FzorWePJMyoTkZfk07ZYiY6Pttb5em+qlO0bbIAnajPXjQI/5lOMpOtZLORYbI aguFT56I+E1t66sxT4+qEoMFrG0W3CrUWoQm0no1i/YkHw/55yWI7NMRoyyNSjt5wSeh pIzen3CQ+eqp0nb7ncne55RmnjlG+TSIiDxddXUMibUdRBRza2khxJQQVTZ7cr9GWcCK Hofw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZnOxnQcb4Fu3paGsTHPyp7sfC5DipN/N3rq9yeMMHF4=; b=6PuguFVXDkpD0vCWMaWPZvM99pMg2m18sZeWvke3+dK3FgQLOdMdrNk/XuctaGqHIz 3Mv6uNocCRN5mo1KJVG+s90dbe0CZbJcpi2VxjtMfd/s2cutg/NDel6EgLVfvkBaiLDc K31YXTY+cD0/i31y0xHYCp5fJw9DO0hKDFomBM19ClUiG1AxH2AZ/uJ4W7Dg1jleawNo 0pjzOLIk51lU0nAMqB3a2dWWToSibiixFeotgBtgkTx+wU0ABSbey1ggSGdw3RPGyIvw 2EDeLJCmP2Kr2sUFt5w7D0AM5OlbBeeCew7PXufUPomQkUSM5V1vPsZrLPeib1c4yuMz zLWw== X-Gm-Message-State: AOAM530GRBq3dInK9q/1b3jTN/nqaY1qBNcq2N29mDGOqEo2DFYzoBsx AygbEz/okJk8pxQfApixQL2ZBDp9tUJWG8MdCaY= X-Google-Smtp-Source: ABdhPJwQvqRaLEwzE8DMq08M3j9ibkibZBnZ2FqxJF0nncGfQeoPRDb1Bb8mbWxmBph9fjkFdFmKfq0fs8XHCzqq6po= X-Received: by 2002:a17:907:7b9f:b0:6f4:d8c5:392c with SMTP id ne31-20020a1709077b9f00b006f4d8c5392cmr14673262ejc.652.1652702909931; Mon, 16 May 2022 05:08:29 -0700 (PDT) MIME-Version: 1.0 References: <20220516115846.58328-1-max.oss.09@gmail.com> <20220516115846.58328-12-max.oss.09@gmail.com> In-Reply-To: <20220516115846.58328-12-max.oss.09@gmail.com> From: Fabio Estevam Date: Mon, 16 May 2022 09:08:20 -0300 Message-ID: Subject: Re: [PATCH v1 11/17] ARM: dts: imx6q-apalis: Add ov5640 mipi csi camera To: Max Krummenacher Cc: Max Krummenacher , Oleksandr Suvorov , Krzysztof Kozlowski , NXP Linux Team , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Max, On Mon, May 16, 2022 at 8:59 AM Max Krummenacher wrote: > > From: Oleksandr Suvorov > > The Apalis iMX6 modules allow connecting a mipi-csi video input. > Add support for our OV5640 camera module but have it disabled. > This allows to enable it in an overlay per the current system > configuration. > > Signed-off-by: Oleksandr Suvorov > Signed-off-by: Max Krummenacher > --- > > arch/arm/boot/dts/imx6qdl-apalis.dtsi | 67 ++++++++++++++++++++++++++- > 1 file changed, 66 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > index 506d040ea37a..0d1004eede62 100644 > --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > @@ -29,6 +29,12 @@ > status = "disabled"; > }; > > + clk_ov5640_osc: clk_ov5640_osc_int { Node names should have "-", not "_" clk_ov5640_osc: clk-ov5640-osc Also, no need for the _int suffix. Just curious: is ov5640 mipi support functional? I recalled that I had issues in getting Gstreamer pipeline to capture from the ov5640 mipi. There were some errors related to LP-11 during the start of the capture. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0BD3C433EF for ; Mon, 16 May 2022 12:10:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JokGv7Uj3TrD/qIe2O+zLAeGEraZYRqSKjscjT0U5Q8=; b=yaSF64M+oDHK/s eTy6QP45miruZgoxyIEKv8Z7S6quQhPAOrL6prlPOUZo9jRuZStO2A1rDsxgzomGowQ214Yopib5l avRhETnwNHH7TwQyN8R8DjzMt4c674bBmjZgfbcykJbZ5nWnxOgDh2L3UxAGYGl/6FXTiVemWX5nF +ETK0maTFhiEaYhhryp+dz+xtksi3lwbAn/sJPy4IzgvDDG0a2OFrcn926oqGqSfmnM97PT6MxpcX nFFeOfRaxXCMdxsgjay2AwOs56ec7DSmrh1vaDrpGc3pCaRcRGbj1KhCAkHY7S4TOwLD15ncCA0GC O7Q5APM9u8HoieYSmQgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqZWg-007UHu-Rg; Mon, 16 May 2022 12:08:40 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqZWa-007UEl-8B for linux-arm-kernel@lists.infradead.org; Mon, 16 May 2022 12:08:33 +0000 Received: by mail-ej1-x632.google.com with SMTP id g6so28256681ejw.1 for ; Mon, 16 May 2022 05:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZnOxnQcb4Fu3paGsTHPyp7sfC5DipN/N3rq9yeMMHF4=; b=iU1ciYcrfm2hMbbA52EonHWO4UjvozsZo9+atKivTNQ0QJ4F3eIkjAW4/BuByThOU+ sXRbHpxeUKIUgcDA6a7DmyP6LDS04X8smMgARYnV7sGmCPvwT4PPhDXJuFt01vtzu6Yt wx2/z3FzorWePJMyoTkZfk07ZYiY6Pttb5em+qlO0bbIAnajPXjQI/5lOMpOtZLORYbI aguFT56I+E1t66sxT4+qEoMFrG0W3CrUWoQm0no1i/YkHw/55yWI7NMRoyyNSjt5wSeh pIzen3CQ+eqp0nb7ncne55RmnjlG+TSIiDxddXUMibUdRBRza2khxJQQVTZ7cr9GWcCK Hofw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZnOxnQcb4Fu3paGsTHPyp7sfC5DipN/N3rq9yeMMHF4=; b=zBpGmzCz7gyZQV3xjg1ORK+pjfnvyS9NSuZhXRTzXlnoGwWbTZgQHx9GjasOidfkB5 5nOCiQZpl/oGOSYnGnpv4o9+nJLqV9pIZjM0imlDyp+p4pzAZpUG6mHpRyZql+zL0Wd6 pOXIGwOhFlrVb3JqD3oU/f68ZEEeLfHuNiMjbPkT4rZPyjnW+hvtz8j1uOxAMtHxae6w rI5q8t5tW65cqQYNW16szCoUgOADLOU53sLJxzt30Lr5/P/0646ElTbXiffNg/44MSXV ChjsdCK4xgCk3nMsxyGth9Vn2K14PezsgYE85wdSh7PDQtoiTIJ1UiD+v/Zbv1reu6rb ONMw== X-Gm-Message-State: AOAM530OwlDCeW4dOiLsu+Wy+fpmBbeJImLbNkOb6/bpzr1ARlLQRY/W y+nlTYQO4msHOi5GkWh7wesfZFPIr50i+KUvDW0= X-Google-Smtp-Source: ABdhPJwQvqRaLEwzE8DMq08M3j9ibkibZBnZ2FqxJF0nncGfQeoPRDb1Bb8mbWxmBph9fjkFdFmKfq0fs8XHCzqq6po= X-Received: by 2002:a17:907:7b9f:b0:6f4:d8c5:392c with SMTP id ne31-20020a1709077b9f00b006f4d8c5392cmr14673262ejc.652.1652702909931; Mon, 16 May 2022 05:08:29 -0700 (PDT) MIME-Version: 1.0 References: <20220516115846.58328-1-max.oss.09@gmail.com> <20220516115846.58328-12-max.oss.09@gmail.com> In-Reply-To: <20220516115846.58328-12-max.oss.09@gmail.com> From: Fabio Estevam Date: Mon, 16 May 2022 09:08:20 -0300 Message-ID: Subject: Re: [PATCH v1 11/17] ARM: dts: imx6q-apalis: Add ov5640 mipi csi camera To: Max Krummenacher Cc: Max Krummenacher , Oleksandr Suvorov , Krzysztof Kozlowski , NXP Linux Team , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_050832_364083_C4902A9A X-CRM114-Status: GOOD ( 17.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Max, On Mon, May 16, 2022 at 8:59 AM Max Krummenacher wrote: > > From: Oleksandr Suvorov > > The Apalis iMX6 modules allow connecting a mipi-csi video input. > Add support for our OV5640 camera module but have it disabled. > This allows to enable it in an overlay per the current system > configuration. > > Signed-off-by: Oleksandr Suvorov > Signed-off-by: Max Krummenacher > --- > > arch/arm/boot/dts/imx6qdl-apalis.dtsi | 67 ++++++++++++++++++++++++++- > 1 file changed, 66 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > index 506d040ea37a..0d1004eede62 100644 > --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > @@ -29,6 +29,12 @@ > status = "disabled"; > }; > > + clk_ov5640_osc: clk_ov5640_osc_int { Node names should have "-", not "_" clk_ov5640_osc: clk-ov5640-osc Also, no need for the _int suffix. Just curious: is ov5640 mipi support functional? I recalled that I had issues in getting Gstreamer pipeline to capture from the ov5640 mipi. There were some errors related to LP-11 during the start of the capture. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel