From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Subject: Re: [PATCH v3 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips Date: Thu, 21 May 2015 19:16:07 -0300 Message-ID: References: <1431473303-18873-1-git-send-email-computersforpeace@gmail.com> <1431473303-18873-4-git-send-email-computersforpeace@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1431473303-18873-4-git-send-email-computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Brian Norris Cc: Tejun Heo , Kishon Vijay Abraham I , Mark Rutland , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Hans de Goede , Florian Fainelli , Pawel Moll , Ian Campbell , Kevin Cernekee , linux-kernel , linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Gregory Fong , Kumar Gala , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-ide@vger.kernel.org On Tue, May 12, 2015 at 8:28 PM, Brian Norris wrote: > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ahci"); > + ahci = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(ahci)) > + return 0; You should propagate 'return PTR_ERR(ahci)' instead. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756749AbbEUWQM (ORCPT ); Thu, 21 May 2015 18:16:12 -0400 Received: from mail-lb0-f178.google.com ([209.85.217.178]:36341 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754764AbbEUWQJ (ORCPT ); Thu, 21 May 2015 18:16:09 -0400 MIME-Version: 1.0 In-Reply-To: <1431473303-18873-4-git-send-email-computersforpeace@gmail.com> References: <1431473303-18873-1-git-send-email-computersforpeace@gmail.com> <1431473303-18873-4-git-send-email-computersforpeace@gmail.com> Date: Thu, 21 May 2015 19:16:07 -0300 Message-ID: Subject: Re: [PATCH v3 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips From: Fabio Estevam To: Brian Norris Cc: Tejun Heo , Kishon Vijay Abraham I , Mark Rutland , "devicetree@vger.kernel.org" , Hans de Goede , Florian Fainelli , Pawel Moll , Ian Campbell , Kevin Cernekee , linux-kernel , linux-ide@vger.kernel.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, Gregory Fong , Kumar Gala , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 12, 2015 at 8:28 PM, Brian Norris wrote: > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ahci"); > + ahci = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(ahci)) > + return 0; You should propagate 'return PTR_ERR(ahci)' instead. From mboxrd@z Thu Jan 1 00:00:00 1970 From: festevam@gmail.com (Fabio Estevam) Date: Thu, 21 May 2015 19:16:07 -0300 Subject: [PATCH v3 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips In-Reply-To: <1431473303-18873-4-git-send-email-computersforpeace@gmail.com> References: <1431473303-18873-1-git-send-email-computersforpeace@gmail.com> <1431473303-18873-4-git-send-email-computersforpeace@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, May 12, 2015 at 8:28 PM, Brian Norris wrote: > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ahci"); > + ahci = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(ahci)) > + return 0; You should propagate 'return PTR_ERR(ahci)' instead.