From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C41B11494DF; Wed, 3 Apr 2024 13:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712151217; cv=none; b=D0I0HGOPrSTpKTpm6MPEct5ziNCaL+35SUfgOazWQKmztKiOKEPmI3qgwGnIaixOD+q3s3+C0ji2nPijBLOwTQx1advKhPhv2wLCJ3ox9xQcX2ZsUwHzGnPzAMsCm2apNiZKU1bigFV+GSqhY0VAs55bo+USbD+NsYaKpe4DzkM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712151217; c=relaxed/simple; bh=Qt01KTjE4NGp5XEomZDf90wNSv9JiA1QkpnnyKlsblA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=okKQmTJA9V2ou0EcVoPoGoTC20G11Agi2nqNNyDKJ8tTQsnOgKG1LMu1M6Xp6s6oTCGiH7vWSNo1cnufA0hlIGZ+YQcTZL/kg9g5hNJPlhyC1SR+SFZ+Y511y76nUsxaJpHGGVbnU1089qET6rNFvGOndKggCL/MavE3P+l0aEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C+u0Sd06; arc=none smtp.client-ip=209.85.161.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C+u0Sd06" Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5a52c5c96feso2359760eaf.3; Wed, 03 Apr 2024 06:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712151215; x=1712756015; darn=lists.linux.dev; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UfJ432sdibD0Lka67Qj4+39whrzSunQCkb9XAcwEVWQ=; b=C+u0Sd06AJoVEun36XNyU7Rng6YLUCg6tOOKEMNQDqIk9nods9TtQFxfHklWNv1gSc +8D9mGEixvXNnvyMleoCJeEQ5g42fQwaaK9W9rswsgIvXpA8q+0hm7CyKB9dvnSAMj6H ckWXssZTBpvhSV7skM7cHG63Ta5f4Umzg6DUSj2jAXY1yvwY5gbxYvAvnNSkZ9oLXFl+ qocII3T9kp184kDZFxt7NVt5KiGB1YrU/LKid19S+nePuwTynd/5JjDGeZoyg2A2yj2C xB00tvxjLdZgHApR/Ca+AV0iJDBjDi8u9f24TLYDZedIItdG6h8DfrhMvMw8BUk/pMDO RQnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712151215; x=1712756015; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UfJ432sdibD0Lka67Qj4+39whrzSunQCkb9XAcwEVWQ=; b=fGTyDWpFa0gP/7CXc65zDvSumNBUsTSvxOdKw/pnGOn9sONzcg2Z6Jd0SJUa66tOBE WvgNGgEMmWnIhV3vzDUEaMa/MZIIMDp4VbPCeT460jsv0Et/Y7VcQt1uRN87ZHtEr6tH 4XigWoYMHURsodG1985nhxG7uwOXlDVBuMv4NzYkCOGhe1/FHw+Spw/I9L0lbupmBAnQ fCOl4MVrYYGU02zXcdmbBi1YxYg8PiEKN2+CTfBD+p7op1ws/b3K8D7LLzazueThOs4P Lt6cKupAi2V/nYHPAFPKMyf/XiXG4Oj45mhVWTt59lecFzenSTi/jIdR2lkK4yqxj/PE 7RSw== X-Forwarded-Encrypted: i=1; AJvYcCUHEHh2fwxOSl2NvHhI1b7bMQkMB7kGG7W8s0WEH4ETaSvdrHfF4KUWgn4LsMxVwZVCEpm9ZHcHPHhxWaGI0TCqr5EWhcE1w3onfMlunt+3a3E6b8sHBR3NkgzrbJjOOjlF/o3pnLnb/LP7zPyFrkmmt8Gvi/NodA== X-Gm-Message-State: AOJu0YyoNSh5yUbXqx82zTtxTiT5ot/yXxblUAxMC6CF4YjADvUUSM7p cHGNfMwGAMRAUkZ6StyHVdA99yfHSyi3kVOD7mJNxhBwMbAs9vB6SI8JqfQLvmRF5MsTYqdQKWK hnzpHW7LQoTLYWB/LgTdKrpFBH+w= X-Google-Smtp-Source: AGHT+IFsoYFg4TPJZ/xBylk5B9Nfa55HU119ldFLC4g550cJsZKKSI+Id/ONzGwerMZ8W2tZHWzr/Kf097BxBvAdyL0= X-Received: by 2002:a05:6808:181d:b0:3c5:d426:9b87 with SMTP id bh29-20020a056808181d00b003c5d4269b87mr1074785oib.23.1712151214780; Wed, 03 Apr 2024 06:33:34 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240327160314.9982-1-apais@linux.microsoft.com> <20240327160314.9982-8-apais@linux.microsoft.com> In-Reply-To: From: Allen Date: Wed, 3 Apr 2024 06:33:23 -0700 Message-ID: Subject: Re: [PATCH 7/9] s390: Convert from tasklet to BH workqueue To: Alexandra Winter Cc: Allen Pais , linux-kernel@vger.kernel.org, tj@kernel.org, keescook@chromium.org, vkoul@kernel.org, marcan@marcan.st, sven@svenpeter.dev, florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, paul@crapouillou.net, Eugeniy.Paltsev@synopsys.com, manivannan.sadhasivam@linaro.org, vireshk@kernel.org, Frank.Li@nxp.com, leoyang.li@nxp.com, zw@zh-kernel.org, wangzhou1@hisilicon.com, haijie1@huawei.com, shawnguo@kernel.org, s.hauer@pengutronix.de, sean.wang@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, afaerber@suse.de, logang@deltatee.com, daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, andersson@kernel.org, konrad.dybcio@linaro.org, orsonzhai@gmail.com, baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com, patrice.chotard@foss.st.com, linus.walleij@linaro.org, wens@csie.org, jernej.skrabec@gmail.com, peter.ujfalusi@gmail.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jassisinghbrar@gmail.com, mchehab@kernel.org, maintainers@bluecherrydvr.com, aubin.constans@microchip.com, ulf.hansson@linaro.org, manuel.lauss@gmail.com, mirq-linux@rere.qmqm.pl, jh80.chung@samsung.com, oakad@yahoo.com, hayashi.kunihiko@socionext.com, mhiramat@kernel.org, brucechang@via.com.tw, HaraldWelte@viatech.com, pierre@ossman.eu, duncan.sands@free.fr, stern@rowland.harvard.edu, oneukum@suse.com, openipmi-developer@lists.sourceforge.net, dmaengine@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-mediatek@lists.infradead.org, linux-actions@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" > > > > Signed-off-by: Allen Pais > > --- > > drivers/s390/block/dasd.c | 42 ++++++++++++------------ > > drivers/s390/block/dasd_int.h | 10 +++--- > > drivers/s390/char/con3270.c | 27 ++++++++-------- > > drivers/s390/crypto/ap_bus.c | 24 +++++++------- > > drivers/s390/crypto/ap_bus.h | 2 +- > > drivers/s390/crypto/zcrypt_msgtype50.c | 2 +- > > drivers/s390/crypto/zcrypt_msgtype6.c | 4 +-- > > drivers/s390/net/ctcm_fsms.c | 4 +-- > > drivers/s390/net/ctcm_main.c | 15 ++++----- > > drivers/s390/net/ctcm_main.h | 5 +-- > > drivers/s390/net/ctcm_mpc.c | 12 +++---- > > drivers/s390/net/ctcm_mpc.h | 7 ++-- > > drivers/s390/net/lcs.c | 26 +++++++-------- > > drivers/s390/net/lcs.h | 2 +- > > drivers/s390/net/qeth_core_main.c | 2 +- > > drivers/s390/scsi/zfcp_qdio.c | 45 +++++++++++++------------- > > drivers/s390/scsi/zfcp_qdio.h | 9 +++--- > > 17 files changed, 117 insertions(+), 121 deletions(-) > > > > > We're looking into the best way to test this. > > For drivers/s390/net/ctcm* and drivers/s390/net/lcs*: > Acked-by: Alexandra Winter Thank you very much. > > > [...] > > diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c > > index a0cce6872075..10ea95abc753 100644 > > --- a/drivers/s390/net/qeth_core_main.c > > +++ b/drivers/s390/net/qeth_core_main.c > > @@ -2911,7 +2911,7 @@ static int qeth_init_input_buffer(struct qeth_card *card, > > } > > > > /* > > - * since the buffer is accessed only from the input_tasklet > > + * since the buffer is accessed only from the input_work > > * there shouldn't be a need to synchronize; also, since we use > > * the QETH_IN_BUF_REQUEUE_THRESHOLD we should never run out off > > * buffers > > I propose to delete the whole comment block. There have been many changes and > I don't think it is helpful for the current qeth driver. Sure, I will have it fixed in v2. - Allen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51356CD1288 for ; Wed, 3 Apr 2024 13:33:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hf7BnbmrA/5lfCt4wwMz8fwwUg7eMr7nj3jIp0Pg7BA=; b=ESVqoU9Oilg1if yxbFqVU/SCBjJyvtZvNqo0ZI2rVHPyI3cShhj9w5vnK94rodwj4oSJ9AM3GURDuQ56oZ7Fk+mmBf2 k2r+TIidgUqlfwYREsgYYIu9B9ZgRbDq2pO8+/qQ4+IZRZrf3BHuYAQcPPg5KDIsXe4MZIaDzzrh2 5v1l8YWzyGPZU5fSgwl8x+CJzbvm3IMi+EBX1RwgQDkrBcJZXbAZEsRATyW7BvRZCFro9KUTNopWs 0s57AJ8ba4yuboAT0xN/uAwszB3cmptneC5CbLEzdVgGxjanFeyiqSrbqFMNkmFfu/WMi8p1vkSkJ UUZyDHIigUWyqJcpPczw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs0kI-0000000GEUQ-3UXj; Wed, 03 Apr 2024 13:33:42 +0000 Received: from mail-oo1-xc36.google.com ([2607:f8b0:4864:20::c36]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs0kC-0000000GERm-3Wnx; Wed, 03 Apr 2024 13:33:38 +0000 Received: by mail-oo1-xc36.google.com with SMTP id 006d021491bc7-5a4f608432bso3990221eaf.2; Wed, 03 Apr 2024 06:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712151215; x=1712756015; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UfJ432sdibD0Lka67Qj4+39whrzSunQCkb9XAcwEVWQ=; b=ThBTOpns8YaLJf6pChW3WVdxrIi+QFt0XaKXDRNjU4xbpimIRfLMOauW0J45p7jTUW 5cmpwo0J0TI6xH0TXV2TjQIe0+RKhj1GagIFMM2IOBs24fJchWeStOe34Urmgem8x3E6 cph1gDY4acR8pjYqKh5uSUC084wvwYBn+aqtHWF5IomnFbQvNSHT8AflZh6iuYNU9yN+ 3URQNKniVqQT4I1HU3tfWFwsx7kH8XA7A4zBclVIbcHs0HxRVyhP4LsEQ2kkUxxLpDQh xmAbEB9qDgELEDjKu+tScUe/cIAbr/2oSBx81r1PTFj0GhYtfTzA0i9DgAkl4niA2fvl OOEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712151215; x=1712756015; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UfJ432sdibD0Lka67Qj4+39whrzSunQCkb9XAcwEVWQ=; b=Ioic9GsTFdaxt7Pj/EuL5B7uhVgoH0NWzUfV/L+78JdjjSgMjXAggOleWs2c5RdprW Q2k+EIujIfDjRN0iSHXZBnMA7b+0+bV2QiTpcYjKe8eAY6Hn8e03UzJ3NehhFaBSrjVl qTlgvFUHoIElhY3tiH2hUHW38VgsjV7DqkNBOe1yqg2NmhWX4lxnnRygAtNQp5+/obzn 7IOrYLFcYRm6ErzSlJ/u/SOL/frFTYoyZab8gaFJPx4BGnURt6K5SbVSE4GkhZtFpDNJ hFMQx89Ed+98+c3/uUDtt5aH6ACWgi4Sf/uPYG+rYJQWYOKG5gUvzlo8DgwWT6zNeN5p Rerg== X-Forwarded-Encrypted: i=1; AJvYcCVoAQ+cCxLXn+2ZkpWDLhgWzZhnVvRPnMceIK/o20jum18FCp4JzWgldKSuKj2cjMQkgWbRdXNwHWwBybhgyBl2mauA/TwIlJ9BpCMk8UMt7pLoBGqpyqjOXzbhK14mdXDFNE8pGQrR0kWk/bhYdsVCVF+5VGEEDPrpSUo018LgeWzH6P7V8yQEnO5BBqlbkFfnBCiz98wSaY9qEnd4WN7QNVDal4iW7tRYgLyNiFEvnPAE3S93dtLnS2Go/8LATF/lPJ5s+HwyOgQ+zzgtqArZArz6Y0HqyGFJ+FBVloL45V30 X-Gm-Message-State: AOJu0YzgURUVuc4iPKhzTLkwbuIex1BXWygdG0cphJqqJzKDv7pZGbMK JnsJ9OYaJEdyJPWSW/7bnk/VFTlMA73KJojVdLoxrC2jOTc1QQ+gHppqj/yVTlKl2y4ZbQ9Fx2b 3cqoknc4okTOgBKEYqThkJzw9rP0= X-Google-Smtp-Source: AGHT+IFsoYFg4TPJZ/xBylk5B9Nfa55HU119ldFLC4g550cJsZKKSI+Id/ONzGwerMZ8W2tZHWzr/Kf097BxBvAdyL0= X-Received: by 2002:a05:6808:181d:b0:3c5:d426:9b87 with SMTP id bh29-20020a056808181d00b003c5d4269b87mr1074785oib.23.1712151214780; Wed, 03 Apr 2024 06:33:34 -0700 (PDT) MIME-Version: 1.0 References: <20240327160314.9982-1-apais@linux.microsoft.com> <20240327160314.9982-8-apais@linux.microsoft.com> In-Reply-To: From: Allen Date: Wed, 3 Apr 2024 06:33:23 -0700 Message-ID: Subject: Re: [PATCH 7/9] s390: Convert from tasklet to BH workqueue To: Alexandra Winter Cc: Allen Pais , linux-kernel@vger.kernel.org, tj@kernel.org, keescook@chromium.org, vkoul@kernel.org, marcan@marcan.st, sven@svenpeter.dev, florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, paul@crapouillou.net, Eugeniy.Paltsev@synopsys.com, manivannan.sadhasivam@linaro.org, vireshk@kernel.org, Frank.Li@nxp.com, leoyang.li@nxp.com, zw@zh-kernel.org, wangzhou1@hisilicon.com, haijie1@huawei.com, shawnguo@kernel.org, s.hauer@pengutronix.de, sean.wang@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, afaerber@suse.de, logang@deltatee.com, daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, andersson@kernel.org, konrad.dybcio@linaro.org, orsonzhai@gmail.com, baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com, patrice.chotard@foss.st.com, linus.walleij@linaro.org, wens@csie.org, jernej.skrabec@gmail.com, peter.ujfalusi@gmail.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jassisinghbrar@gmail.com, mchehab@kernel.org, maintainers@bluecherrydvr.com, aubin.constans@microchip.com, ulf.hansson@linaro.org, manuel.lauss@gmail.com, mirq-linux@rere.qmqm.pl, jh80.chung@samsung.com, oakad@yahoo.com, hayashi.kunihiko@socionext.com, mhiramat@kernel.org, brucechang@via.com.tw, HaraldWelte@viatech.com, pierre@ossman.eu, duncan.sands@free.fr, stern@rowland.harvard.edu, oneukum@suse.com, openipmi-developer@lists.sourceforge.net, dmaengine@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-mediatek@lists.infradead.org, linux-actions@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_063337_093630_9CD57E9C X-CRM114-Status: GOOD ( 19.34 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org > > > > Signed-off-by: Allen Pais > > --- > > drivers/s390/block/dasd.c | 42 ++++++++++++------------ > > drivers/s390/block/dasd_int.h | 10 +++--- > > drivers/s390/char/con3270.c | 27 ++++++++-------- > > drivers/s390/crypto/ap_bus.c | 24 +++++++------- > > drivers/s390/crypto/ap_bus.h | 2 +- > > drivers/s390/crypto/zcrypt_msgtype50.c | 2 +- > > drivers/s390/crypto/zcrypt_msgtype6.c | 4 +-- > > drivers/s390/net/ctcm_fsms.c | 4 +-- > > drivers/s390/net/ctcm_main.c | 15 ++++----- > > drivers/s390/net/ctcm_main.h | 5 +-- > > drivers/s390/net/ctcm_mpc.c | 12 +++---- > > drivers/s390/net/ctcm_mpc.h | 7 ++-- > > drivers/s390/net/lcs.c | 26 +++++++-------- > > drivers/s390/net/lcs.h | 2 +- > > drivers/s390/net/qeth_core_main.c | 2 +- > > drivers/s390/scsi/zfcp_qdio.c | 45 +++++++++++++------------- > > drivers/s390/scsi/zfcp_qdio.h | 9 +++--- > > 17 files changed, 117 insertions(+), 121 deletions(-) > > > > > We're looking into the best way to test this. > > For drivers/s390/net/ctcm* and drivers/s390/net/lcs*: > Acked-by: Alexandra Winter Thank you very much. > > > [...] > > diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c > > index a0cce6872075..10ea95abc753 100644 > > --- a/drivers/s390/net/qeth_core_main.c > > +++ b/drivers/s390/net/qeth_core_main.c > > @@ -2911,7 +2911,7 @@ static int qeth_init_input_buffer(struct qeth_card *card, > > } > > > > /* > > - * since the buffer is accessed only from the input_tasklet > > + * since the buffer is accessed only from the input_work > > * there shouldn't be a need to synchronize; also, since we use > > * the QETH_IN_BUF_REQUEUE_THRESHOLD we should never run out off > > * buffers > > I propose to delete the whole comment block. There have been many changes and > I don't think it is helpful for the current qeth driver. Sure, I will have it fixed in v2. - Allen _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D17CCD128A for ; Wed, 3 Apr 2024 21:02:47 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ZGxG3Jdv; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4V8xz95LbFz3dVC for ; Thu, 4 Apr 2024 08:02:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ZGxG3Jdv; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::c2d; helo=mail-oo1-xc2d.google.com; envelope-from=allen.lkml@gmail.com; receiver=lists.ozlabs.org) Received: from mail-oo1-xc2d.google.com (mail-oo1-xc2d.google.com [IPv6:2607:f8b0:4864:20::c2d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4V8m0y3vC0z3dh2 for ; Thu, 4 Apr 2024 00:33:37 +1100 (AEDT) Received: by mail-oo1-xc2d.google.com with SMTP id 006d021491bc7-5a9d06da012so119357eaf.1 for ; Wed, 03 Apr 2024 06:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712151215; x=1712756015; darn=lists.ozlabs.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UfJ432sdibD0Lka67Qj4+39whrzSunQCkb9XAcwEVWQ=; b=ZGxG3JdvXgTjwXUjEtsmX3/Zwx89nM88QxayhVkJozOH/XEHZ+jSQjCm2LtXrG/eJt wW6F86lvEdeOc7Wwk7tzIRRr6OJ9nyKt6UqmOsS+lKswaBI0g/wbKxiwj//zEP6fYAn5 3TGHZaZaPMV/BcoF8qTXn86ZRWz2qJEMzOEeIEmbBq0ykKOhjPoEkByZis+A/iNlHHbr nIe8SucSWEoxw9RKMGwI3uiWbxaP4zikk0gVWM7broHLoOkNoIWfPDdFOwKojhkUlaXq OTpcW/ajoEzeG52uqrBkfBXWbABFHX6WOq3HYdJAiyiE01yH5xttZt3W3ld2esOBKHpV Q97A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712151215; x=1712756015; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UfJ432sdibD0Lka67Qj4+39whrzSunQCkb9XAcwEVWQ=; b=k39RXzZdsp8mpk2GO5+uXuZgBzCiytB1K41N0xB7BkCECbOx26+M6IO2ko1XTaY4xi 7uyzT5U60o0TGNGmHQSygqhzXSGo6ccN03P9fr3bcIJKBHtrtp2nr9qtoMGvz5FP8JMj /7M0O6NksomXJGrAkgcH7SqTKRQN03+Vyl0T5uBOE+pIgWRy9CJf69wTtZk7GPH9i8h6 2Yual1URzRhL8m+SanWeL5HMpPaM6n0CFs7/+XswxeOfrreg20PgGYRT7Mf13VkHJwpo i+3E4Az6sBfd/JO7fmtVbXSbWB91rWfa1BG6nsz+b7ty0xZH5vrI/7NYHgAEFOnB9gln mqkw== X-Forwarded-Encrypted: i=1; AJvYcCUdg0BWpXHhJBNEls/8ly73ESC77o6dYGYDxCg6QDek/KHlpSdQAK9cCiA5lJEPg/iTuxHJzZranlRQR4/Y3+QZZTS4SFGZ5Cwvp342/w== X-Gm-Message-State: AOJu0YzHthKj4TlsiogayKACDMB+YwkvkkUCkZNVbVifs587ldCY887X 7sjdp8c9nAkFLAjRGyDE73jyyb48cSJpDaBho72ke8oa0WNUoog4WsBGzJwSzccMbxRQZarwGa6 X6AqIvy4w+fEOn73dqZyo1eetE10= X-Google-Smtp-Source: AGHT+IFsoYFg4TPJZ/xBylk5B9Nfa55HU119ldFLC4g550cJsZKKSI+Id/ONzGwerMZ8W2tZHWzr/Kf097BxBvAdyL0= X-Received: by 2002:a05:6808:181d:b0:3c5:d426:9b87 with SMTP id bh29-20020a056808181d00b003c5d4269b87mr1074785oib.23.1712151214780; Wed, 03 Apr 2024 06:33:34 -0700 (PDT) MIME-Version: 1.0 References: <20240327160314.9982-1-apais@linux.microsoft.com> <20240327160314.9982-8-apais@linux.microsoft.com> In-Reply-To: From: Allen Date: Wed, 3 Apr 2024 06:33:23 -0700 Message-ID: Subject: Re: [PATCH 7/9] s390: Convert from tasklet to BH workqueue To: Alexandra Winter Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Thu, 04 Apr 2024 08:02:05 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, ulf.hansson@linaro.org, oneukum@suse.com, duncan.sands@free.fr, hayashi.kunihiko@socionext.com, linux-mmc@vger.kernel.org, aubin.constans@microchip.com, linus.walleij@linaro.org, Frank.Li@nxp.com, linux-hyperv@vger.kernel.org, linux-usb@vger.kernel.org, HaraldWelte@viatech.com, paul@crapouillou.net, linux-tegra@vger.kernel.org, netdev@vger.kernel.org, maintainers@bluecherrydvr.com, peter.ujfalusi@gmail.com, manivannan.sadhasivam@linaro.org, linux-riscv@lists.infradead.org, kys@microsoft.com, robert.jarzmik@free.fr, haijie1@huawei.com, linux-renesas-soc@vger.kernel.org, wei.liu@kernel.org, linux-omap@vger.kernel.org, florian.fainelli@broadcom.com, linux-rdma@vger.kernel.org, vireshk@kernel.org, jassisinghbrar@gmail.com, decui@microsoft.com, wangzhou1@hisilicon.com, jernej.skrabec@gmail.com, jh80.chung@samsung.com, zw@zh-kernel.org, wens@csie.org, stern@rowland.harvard.edu, linux-arm-msm@vger.kernel.org, orsonzhai@gmail.com, pierre@ossman.eu, linux-mips@vger.ke rnel.org, Eugeniy.Paltsev@synopsys.com, patrice.chotard@foss.st.com, asahi@lists.linux.dev, brucechang@via.com.tw, keescook@chromium.org, oakad@yahoo.com, sven@svenpeter.dev, rjui@broadcom.com, s.hauer@pengutronix.de, sean.wang@mediatek.com, linux-actions@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, haojian.zhuang@gmail.com, mirq-linux@rere.qmqm.pl, dmaengine@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, baolin.wang@linux.alibaba.com, matthias.bgg@gmail.com, openipmi-developer@lists.sourceforge.net, mchehab@kernel.org, Allen Pais , linux-arm-kernel@lists.infradead.org, angelogioacchino.delregno@collabora.com, sbranden@broadcom.com, logang@deltatee.com, andersson@kernel.org, marcan@marcan.st, haiyangz@microsoft.com, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, konrad.dybcio@linaro.org, linux-sunxi@lists.linux.dev, vkoul@kernel.org, linux-s390@vger.kernel.org, mhiramat@kernel.org, zhang.lyra@gmail.com, tj@kernel.org, manuel.lauss@gmail.com, linux-media@vger.kernel.org, shawnguo@kernel.org, afaerber@suse.de, daniel@zonque.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" > > > > Signed-off-by: Allen Pais > > --- > > drivers/s390/block/dasd.c | 42 ++++++++++++------------ > > drivers/s390/block/dasd_int.h | 10 +++--- > > drivers/s390/char/con3270.c | 27 ++++++++-------- > > drivers/s390/crypto/ap_bus.c | 24 +++++++------- > > drivers/s390/crypto/ap_bus.h | 2 +- > > drivers/s390/crypto/zcrypt_msgtype50.c | 2 +- > > drivers/s390/crypto/zcrypt_msgtype6.c | 4 +-- > > drivers/s390/net/ctcm_fsms.c | 4 +-- > > drivers/s390/net/ctcm_main.c | 15 ++++----- > > drivers/s390/net/ctcm_main.h | 5 +-- > > drivers/s390/net/ctcm_mpc.c | 12 +++---- > > drivers/s390/net/ctcm_mpc.h | 7 ++-- > > drivers/s390/net/lcs.c | 26 +++++++-------- > > drivers/s390/net/lcs.h | 2 +- > > drivers/s390/net/qeth_core_main.c | 2 +- > > drivers/s390/scsi/zfcp_qdio.c | 45 +++++++++++++------------- > > drivers/s390/scsi/zfcp_qdio.h | 9 +++--- > > 17 files changed, 117 insertions(+), 121 deletions(-) > > > > > We're looking into the best way to test this. > > For drivers/s390/net/ctcm* and drivers/s390/net/lcs*: > Acked-by: Alexandra Winter Thank you very much. > > > [...] > > diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c > > index a0cce6872075..10ea95abc753 100644 > > --- a/drivers/s390/net/qeth_core_main.c > > +++ b/drivers/s390/net/qeth_core_main.c > > @@ -2911,7 +2911,7 @@ static int qeth_init_input_buffer(struct qeth_card *card, > > } > > > > /* > > - * since the buffer is accessed only from the input_tasklet > > + * since the buffer is accessed only from the input_work > > * there shouldn't be a need to synchronize; also, since we use > > * the QETH_IN_BUF_REQUEUE_THRESHOLD we should never run out off > > * buffers > > I propose to delete the whole comment block. There have been many changes and > I don't think it is helpful for the current qeth driver. Sure, I will have it fixed in v2. - Allen