From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752996Ab2CHVEe (ORCPT ); Thu, 8 Mar 2012 16:04:34 -0500 Received: from mail-vx0-f174.google.com ([209.85.220.174]:49315 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895Ab2CHVEd convert rfc822-to-8bit (ORCPT ); Thu, 8 Mar 2012 16:04:33 -0500 MIME-Version: 1.0 In-Reply-To: <1331238865.25686.474.camel@gandalf.stny.rr.com> References: <1331237591-4406-1-git-send-email-jkacur@redhat.com> <1331237840.25686.470.camel@gandalf.stny.rr.com> <20120308142257.145e0968@redhat.com> <1331238865.25686.474.camel@gandalf.stny.rr.com> Date: Thu, 8 Mar 2012 22:04:32 +0100 X-Google-Sender-Auth: AD5kCUChauRdQhctTX6DjXOz7M0 Message-ID: Subject: Re: [PATCH-RT] preempt.h: Fix implicit declaration of 'preempt_check_resched_rt' From: John Kacur To: Steven Rostedt Cc: Clark Williams , Thomas Gleixner , rt-users , lkml Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 8, 2012 at 9:34 PM, Steven Rostedt wrote: > On Thu, 2012-03-08 at 14:22 -0600, Clark Williams wrote: >> On Thu, 08 Mar 2012 15:17:20 -0500 >> Steven Rostedt wrote: >> >> > On Thu, 2012-03-08 at 21:13 +0100, John Kacur wrote: >> > > When building a non-preempt kernel where CONFIG_PREEMPT_COUNT is not >> > > defined the following build break occurs. >> > > >> > > /home/jkacur/linux-rt/block/blk-softirq.c: In function ‘trigger_softirq’: >> > > /home/jkacur/linux-rt/block/blk-softirq.c:54: error: implicit declaration of function ‘preempt_check_resched_rt’ >> > > make[2]: *** [block/blk-softirq.o] Error 1 >> > > make[1]: *** [block/blk-softirq.o] Error 2 >> > > make: *** [sub-make] Error 2 >> > > >> > > This patch fixes the build error by adding a define to the >> > > !CONFIG_PREEMPT_COUNT section. >> > > >> > > Signed-off-by: Clark Williams >> > >> > Why Clark's SOB? Did he write it and send it to you? >> >> I suppose to be technically correct it should have been a Tested-by: >> >> John found it while I was working on it and I tested it for him. > > Either a "Reported-by" if you mentioned it to John and he fixed it, or a > "Tested-by" if he fixed it and you tested it. You can have both if that > is true too. > > But "Signed-off-by" has supposed legal significance. It means that you > are responsible for this patch. Either you authored it, or it went > through you to get to the git repo (ie. you are the maintainer that took > the patch). > > All other tags are FYI only. Only the SOB is required and has real > meaning. Also, you should *never* add a SOB to a patch without the > person explicitly giving it to you. > > -- Steve > Good, understood. Please change to Tested-by: Clark Willilams Signed-off-by: John Kacur Note that the patch is for 3.2.9-rt17 Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Kacur Subject: Re: [PATCH-RT] preempt.h: Fix implicit declaration of 'preempt_check_resched_rt' Date: Thu, 8 Mar 2012 22:04:32 +0100 Message-ID: References: <1331237591-4406-1-git-send-email-jkacur@redhat.com> <1331237840.25686.470.camel@gandalf.stny.rr.com> <20120308142257.145e0968@redhat.com> <1331238865.25686.474.camel@gandalf.stny.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Clark Williams , Thomas Gleixner , rt-users , lkml To: Steven Rostedt Return-path: Received: from mail-vx0-f174.google.com ([209.85.220.174]:49315 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895Ab2CHVEd convert rfc822-to-8bit (ORCPT ); Thu, 8 Mar 2012 16:04:33 -0500 In-Reply-To: <1331238865.25686.474.camel@gandalf.stny.rr.com> Sender: linux-rt-users-owner@vger.kernel.org List-ID: On Thu, Mar 8, 2012 at 9:34 PM, Steven Rostedt wr= ote: > On Thu, 2012-03-08 at 14:22 -0600, Clark Williams wrote: >> On Thu, 08 Mar 2012 15:17:20 -0500 >> Steven Rostedt wrote: >> >> > On Thu, 2012-03-08 at 21:13 +0100, John Kacur wrote: >> > > When building a non-preempt kernel where CONFIG_PREEMPT_COUNT is= not >> > > defined the following build break occurs. >> > > >> > > /home/jkacur/linux-rt/block/blk-softirq.c: In function =91trigge= r_softirq=92: >> > > /home/jkacur/linux-rt/block/blk-softirq.c:54: error: implicit de= claration of function =91preempt_check_resched_rt=92 >> > > make[2]: *** [block/blk-softirq.o] Error 1 >> > > make[1]: *** [block/blk-softirq.o] Error 2 >> > > make: *** [sub-make] Error 2 >> > > >> > > This patch fixes the build error by adding a define to the >> > > !CONFIG_PREEMPT_COUNT section. >> > > >> > > Signed-off-by: Clark Williams >> > >> > Why Clark's SOB? Did he write it and send it to you? >> >> I suppose to be technically correct it should have been a Tested-by: >> >> John found it while I was working on it and I tested it for him. > > Either a "Reported-by" if you mentioned it to John and he fixed it, o= r a > "Tested-by" if he fixed it and you tested it. You can have both if th= at > is true too. > > But "Signed-off-by" has supposed legal significance. It means that yo= u > are responsible for this patch. Either you authored it, or it went > through you to get to the git repo (ie. you are the maintainer that t= ook > the patch). > > All other tags are FYI only. Only the SOB is required and has real > meaning. Also, you should *never* add a SOB to a patch without the > person explicitly giving it to you. > > -- Steve > Good, understood. Please change to Tested-by: Clark Willilams Signed-off-by: John Kacur Note that the patch is for 3.2.9-rt17 Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-rt-user= s" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html