All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
	zhangyi <yi.zhang@huawei.com>,
	"linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH v5 1/4] ovl: move include of ovl_entry.h into overlayfs.h
Date: Tue, 31 Oct 2017 15:22:45 +0200	[thread overview]
Message-ID: <CAOQ4uxg3H0WgQMMkDNYKMq=kwJVBVCb01h+GEwPKdo3Jyeaw0g@mail.gmail.com> (raw)
In-Reply-To: <CAJfpegupc9mb8AWYocnn-RB6zaemfSpCSHb+H4NDUxD=RtX-XA@mail.gmail.com>

On Tue, Oct 31, 2017 at 3:14 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> Is this really necessary?
>
> "ovl_entry.h" is supposed to be more of a low level thing, and I'm not
> sure having that proliferate to all parts of the code is a good idea.
>
> At least some justification would be good here.

The "problem" is that include "ovl_entry.h" is already included by 5/8
overlayfs c files and by the end of the NFS export series its 7/9 and
there are exported functions in overlayfs.h whose signature include
pointers to structs defined in ovl_entry.h, so I started forward declaring those
structs in overlayfs.h.

After you look at the next patch "anonymous devs for lowerdirs"
let me know if you prefer a different distribution between the 2 include
files, or a 3rd include file.

Thanks,
Amir.

  reply	other threads:[~2017-10-31 13:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-30 20:27 [PATCH v5 0/4] Overlayfs: constant st_ino/d_ino for non-samefs Amir Goldstein
2017-10-30 20:27 ` [PATCH v5 1/4] ovl: move include of ovl_entry.h into overlayfs.h Amir Goldstein
2017-10-31 13:14   ` Miklos Szeredi
2017-10-31 13:22     ` Amir Goldstein [this message]
2017-10-30 20:27 ` [PATCH v5 2/4] ovl: allocate anonymous devs for lowerdirs Amir Goldstein
2017-10-31 13:43   ` Miklos Szeredi
2017-10-31 13:53     ` Amir Goldstein
2017-10-31 23:01       ` Amir Goldstein
2017-11-01 13:17         ` Chandan Rajendra
2017-11-01 13:34           ` Amir Goldstein
2017-11-01 14:42   ` Vivek Goyal
2017-11-01 15:02     ` Amir Goldstein
2017-11-01 15:47       ` Vivek Goyal
2017-11-01 16:41         ` Amir Goldstein
2017-11-02 12:27           ` Vivek Goyal
2017-11-02 12:47             ` Amir Goldstein
2017-11-02 14:05               ` Vivek Goyal
2017-11-02 14:38                 ` Amir Goldstein
2017-11-01 15:41   ` Vivek Goyal
2017-11-01 16:30     ` Amir Goldstein
2017-10-30 20:27 ` [PATCH v5 3/4] ovl: relax same fs constrain for constant st_ino Amir Goldstein
2017-10-30 20:27 ` [PATCH v5 4/4] ovl: relax same fs constraint for constant d_ino Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ4uxg3H0WgQMMkDNYKMq=kwJVBVCb01h+GEwPKdo3Jyeaw0g@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=chandan@linux.vnet.ibm.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.