From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E3FEC31E45 for ; Thu, 13 Jun 2019 16:53:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 706C320665 for ; Thu, 13 Jun 2019 16:53:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lojDYtBt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392938AbfFMQxu (ORCPT ); Thu, 13 Jun 2019 12:53:50 -0400 Received: from mail-yw1-f68.google.com ([209.85.161.68]:45686 "EHLO mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404431AbfFMQxi (ORCPT ); Thu, 13 Jun 2019 12:53:38 -0400 Received: by mail-yw1-f68.google.com with SMTP id m16so8606390ywh.12 for ; Thu, 13 Jun 2019 09:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2sPkTPdJ3wOyLAIYnFkdamPG63sZ+DeF7BYB5onzOKU=; b=lojDYtBtcdzshl4fWmF/BKJaI7rMcG9iFo3d/WVo5IJlaZbQDg8EFeHp9BfcyY82IL Y+wFGtqgiDOROUOSPEkeKXYTzYxVLwYzcoIfzWwOz86jJpDrIcSGMN6CG/VdeTA/q7aF zOGyOeeKWhY3EPdfv/GL7AWk2cV/lyitf+Zk66ImFj4mE+0qAwV9yviJfwXq+7nI6i1+ qJ6OiNqID3sUoAudotTHlfgW8Huk2HadR8XHNYC5s6vOk3JqtXkSOTkG3WnxkG0LNJtk 6a/NsvqEnfGRyO1quKtZSS5AIfUECw48N75AtuGg7bib8rLGbMhab5PWJ0GDC7R7gZwR rLfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2sPkTPdJ3wOyLAIYnFkdamPG63sZ+DeF7BYB5onzOKU=; b=YWE020hfvJCXpSfmNiitXcHBE44KBRyMiq3rj2yrL6QOdZdhOlYppdG0LN9ogkzhGU hm+s8wzMlL7KiuLxZrlG68XlYtMNfow3fEJFHqo/0uitnOi/t23cBrwm1WWVQ/ZGpwLM qo6m7ipDmD9ccYqUdZUQgU7p2YVsx9Y5ePEL5TOuuyYorxM8p8zsm07NFlAZ1x0wgxnD YS0AlgXSXrf9ZgK1LaqWM3EQP4slfga25/v6njEGoh9jBeHwyO85qfZ1d01McGehVc1d ByI/y15RW6NzMWo69RsurdFGP5b70rTyGWtkp5LL6lx7meis+R2GQ1A2jxdSIuD5q4jD rMRw== X-Gm-Message-State: APjAAAWpjmw73JgKvxlLVgLnjHVl1KCnoXARShs08wB9n1xRU7+sjLWJ gz+9QyQG9bvJZNwW6YSSXy8z97kOUPfXBVCZKas= X-Google-Smtp-Source: APXvYqxT7CSa1Fp1M4Dmj9UNPC0yB+eVMw913N8MwhuTGH+dbWfLCKeb6LXBboWSKfziMlOH43lSoEFk1vFh0jzO4fs= X-Received: by 2002:a81:7096:: with SMTP id l144mr50488611ywc.294.1560444817087; Thu, 13 Jun 2019 09:53:37 -0700 (PDT) MIME-Version: 1.0 References: <20190526143411.11244-1-amir73il@gmail.com> <20190526143411.11244-5-amir73il@gmail.com> In-Reply-To: <20190526143411.11244-5-amir73il@gmail.com> From: Amir Goldstein Date: Thu, 13 Jun 2019 19:53:25 +0300 Message-ID: Subject: Re: [PATCH v3 04/10] tracefs: call fsnotify_{unlink,rmdir}() hooks To: Steven Rostedt Cc: David Sterba , Christoph Hellwig , Joel Becker , John Johansen , Trond Myklebust , Anna Schumaker , Greg Kroah-Hartman , Al Viro , linux-fsdevel , Jan Kara Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, May 26, 2019 at 5:34 PM Amir Goldstein wrote: > > This will allow generating fsnotify delete events after the > fsnotify_nameremove() hook is removed from d_delete(). > > Cc: Steven Rostedt > Signed-off-by: Amir Goldstein Hi Steven, Would you be able to provide an ACK on this patch? We need to add those explicit fsnotify hooks to match the existing fsnotify_create/mkdir hooks in tracefs, because the hook embedded inside d_delete() is going away [1]. Thanks, Amir. [1] https://lore.kernel.org/linux-fsdevel/20190526143411.11244-1-amir73il@gmail.com/ > --- > fs/tracefs/inode.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c > index 7098c49f3693..497a8682b5b9 100644 > --- a/fs/tracefs/inode.c > +++ b/fs/tracefs/inode.c > @@ -509,9 +509,12 @@ static int __tracefs_remove(struct dentry *dentry, struct dentry *parent) > switch (dentry->d_inode->i_mode & S_IFMT) { > case S_IFDIR: > ret = simple_rmdir(parent->d_inode, dentry); > + if (!ret) > + fsnotify_rmdir(parent->d_inode, dentry); > break; > default: > simple_unlink(parent->d_inode, dentry); > + fsnotify_unlink(parent->d_inode, dentry); > break; > } > if (!ret) > -- > 2.17.1 >