All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	shepjeng@gmail.com, kernel@cccheng.net,
	Chung-Chiang Cheng <cccheng@synology.com>,
	Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH] splice: report related fsnotify events
Date: Mon, 3 Apr 2023 20:00:26 +0300	[thread overview]
Message-ID: <CAOQ4uxg_=7ypNL1nZKQ-=Sp-Q11sQjA4Jbws3Zgxgvirdw242w@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxiAbMaXqa8r-ErVsM_N1eSNWq+Wnyua4d+Eq89JZWb7sA@mail.gmail.com>

On Wed, Mar 22, 2023 at 9:08 AM Amir Goldstein <amir73il@gmail.com> wrote:
>
> On Wed, Mar 22, 2023 at 8:51 AM Chung-Chiang Cheng <cccheng@synology.com> wrote:
> >
> > The fsnotify ACCESS and MODIFY event are missing when manipulating a file
> > with splice(2).
> >

Jens, Jan,

FYI, I've audited aio routines and found that
fsnotify_access()/modify() are also missing in aio_complete_rw()
and in io_complete_rw_iopoll() (io_req_io_end() should be called?).

I am not using/testing aio/io_uring usually, so I wasn't planning on sending
a patch any time soon. I'll get to it someday.
Just wanted to bring this to public attention in case someone is
interested in testing/fixing.

Thanks,
Amir.

  reply	other threads:[~2023-04-03 17:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22  6:25 [PATCH] splice: report related fsnotify events Chung-Chiang Cheng
2023-03-22  7:08 ` Amir Goldstein
2023-04-03 17:00   ` Amir Goldstein [this message]
2023-04-03 17:03     ` Jens Axboe
2023-04-03 17:15       ` Amir Goldstein
2023-04-03 17:23         ` Jens Axboe
2023-04-04  9:21           ` Jan Kara
2023-04-04 13:45             ` Amir Goldstein
2023-04-04 16:30               ` Jens Axboe
2023-04-04 16:29             ` Jens Axboe
2023-04-03 12:31 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ4uxg_=7ypNL1nZKQ-=Sp-Q11sQjA4Jbws3Zgxgvirdw242w@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=cccheng@synology.com \
    --cc=jack@suse.cz \
    --cc=kernel@cccheng.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=shepjeng@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.