Re: [PATCH v2 11/16] fanotify: prepare to encode both parent and child fid's

[Amir Goldstein <amir73il@gmail.com>]

>
> > struct fanotify_fh_name {
> >          union {
> >                 struct {
> >                        u8 fh_type;
> >                        u8 fh_len;
> >                        u8 name_len;
> >                        u32 hash;
> >                 };
> >                 u64 hash_len;
> >         };
> >         union {
> >                 unsigned char fh[FANOTIFY_INLINE_FH_LEN];
> >                 unsigned char *ext_fh;
> >         };
> >         char name[0];
> > };
>
> So based on the above I wouldn't add just name hash to fanotify_fh_name at
> this point...
>

OK. but what do you think about tying name with fh as above?
At least name_len gets to use the hole this way.

I am trying this out now and it is really hard for me not to call the struct
above fanotify_fid.
IMO code looks much better when it is called this way.
The problem is inconsistency with struct fanotify_event_info_fid which
does include fsid, but I think we can live with that.

Anyway, I'll prepare a version or two of the end result and let you see
how it looks.

Thanks,
Amir.