All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Lubos Dolezel <lubos@dolezel.info>
Cc: overlayfs <linux-unionfs@vger.kernel.org>,
	Miklos Szeredi <miklos@szeredi.hu>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] overlay: return required buffer size for file handles
Date: Wed, 6 May 2020 13:22:10 +0300	[thread overview]
Message-ID: <CAOQ4uxgrLMOu69CUwsxvZWWc0Ly5yixeFdmN9WA-BNU+=ydc8A@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxhEu+vLrvpnqdCdT+vaLAnaNXBBiQ9fPmN39zC4_UzLSg@mail.gmail.com>

On Tue, May 5, 2020 at 5:58 AM Amir Goldstein <amir73il@gmail.com> wrote:
>
> On Mon, May 4, 2020 at 10:50 PM Lubos Dolezel <lubos@dolezel.info> wrote:
> >
> > Hello,
> >
> > overlayfs doesn't work well with the fanotify mechanism.
> >
> > Fanotify first probes for the required buffer size for the file handle,
> > but overlayfs currently bails out without passing the size back.
> >
> > That results in errors in the kernel log, such as:
> >
> > [527944.485384] overlayfs: failed to encode file handle (/, err=-75, buflen=0, len=29, type=1)
> > [527944.485386] fanotify: failed to encode fid (fsid=ae521e68.a434d95f, type=255, bytes=0, err=-2)
> >
> > Lubos
>
> Hi Lubos,
>
> Thank you for the fix.
> Please leave greeting (Hello) and this line outside of the commit message.
> You may add extra notes for email after --- line
>
> >
> > Signed-off-by: Lubos Dolezel <lubos@dolezel.info>
>
> After fixing below you may add for v2:
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
>

Pushed my v2 to:
https://github.com/amir73il/linux/commits/ovl-fixes

Along with Dan's patch.

Tests are at:
https://github.com/amir73il/xfstests/commits/ovl-fixes

Thanks,
Amir.

      reply	other threads:[~2020-05-06 10:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04 19:35 [PATCH] overlay: return required buffer size for file handles Lubos Dolezel
2020-05-05  2:58 ` Amir Goldstein
2020-05-06 10:22   ` Amir Goldstein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ4uxgrLMOu69CUwsxvZWWc0Ly5yixeFdmN9WA-BNU+=ydc8A@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=lubos@dolezel.info \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.