Re: [PATCH 5.15 CANDIDATE v2 0/8] xfs stable candidate patches for 5.15.y (part 1)

[Amir Goldstein <amir73il@gmail.com>]

On Thu, Jun 23, 2022 at 7:53 AM Amir Goldstein <amir73il@gmail.com> wrote:
>
> On Thu, Jun 23, 2022 at 12:38 AM Leah Rumancik <leah.rumancik@gmail.com> wrote:
> >
> > On Wed, Jun 22, 2022 at 09:35:19AM -0700, Darrick J. Wong wrote:
> > > On Wed, Jun 22, 2022 at 09:23:07AM -0700, Darrick J. Wong wrote:
> > > > On Thu, Jun 16, 2022 at 11:27:41AM -0700, Leah Rumancik wrote:
> > > > > The patch testing has been increased to 100 runs per test on each
> > > > > config. A baseline without the patches was established with 100 runs
> > > > > to help detect hard failures / tests with a high fail rate. Any
> > > > > failures seen in the backports branch but not in the baseline branch
> > > > > were then run 1000+ times on both the baseline and backport branches
> > > > > and the failure rates compared. The failures seen on the 5.15
> > > > > baseline are listed at
> > > > > https://gist.github.com/lrumancik/5a9d85d2637f878220224578e173fc23.
> > > > > No regressions were seen with these patches.
> > > > >
> > > > > To make the review process easier, I have been coordinating with Amir
> > > > > who has been testing this same set of patches on 5.10. He will be
> > > > > sending out the corresponding 5.10 series shortly.
> > > > >
> > > > > Change log from v1
> > > > > (https://lore.kernel.org/all/20220603184701.3117780-1-leah.rumancik@gmail.com/):
> > > > > - Increased testing
> > > > > - Reduced patch set to overlap with 5.10 patches
> > > > >
> > > > > Thanks,
> > > > > Leah
> > > > >
> > > > > Brian Foster (1):
> > > > >   xfs: punch out data fork delalloc blocks on COW writeback failure
> > > > >
> > > > > Darrick J. Wong (4):
> > > > >   xfs: remove all COW fork extents when remounting readonly
> > > > >   xfs: prevent UAF in xfs_log_item_in_current_chkpt
> > > > >   xfs: only bother with sync_filesystem during readonly remount
> > > >
> > > > 5.15 already has the vfs fixes to make sync_fs/sync_filesystem actually
> > > > return error codes, right?
> > Confirmed "vfs: make sync_filesystem return errors from ->sync_fs" made
> > it into 5.15.y (935745abcf4c695a18b9af3fbe295e322547a114).
>
> Confirmed that it made it into 5.10.y and that
> 2719c7160dcf ("vfs: make freeze_super abort when sync_filesystem returns error")
> also made it to both 5.10.y and 5.15.y

Correcting myself:
All of these vfs fixes are in 5.15.y:

* 2d86293c7075 - (xfs/vfs-5.17-fixes) xfs: return errors in xfs_fs_sync_fs
* dd5532a4994b - quota: make dquot_quota_sync return errors from ->sync_fs
* 5679897eb104 - vfs: make sync_filesystem return errors from ->sync_fs
* 2719c7160dcf - vfs: make freeze_super abort when sync_filesystem returns error

5.10.y has only 2719c7160dcf and dd5532a4994b which applied cleanly
and are outside of the fs/xfs/* AUTOSEL ban.

I have backported the two other patches to 5.10, but I may defer them
and the readonly remount patch to the next submission.

Thanks,
Amir.