All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: "linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>,
	"# v4 . 13" <stable@vger.kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] ovl: handle ENOENT on index lookup
Date: Fri, 20 Oct 2017 17:21:32 +0300	[thread overview]
Message-ID: <CAOQ4uxgvokfgNiUCFoHtENA5-20DMB3uBN2AmfeHw5ujoQtzjg@mail.gmail.com> (raw)
In-Reply-To: <CAJfpegusagcsC8EM46fR9E6B0OOCsqhq==zisPioLxX91XUKbg@mail.gmail.com>

On Fri, Oct 20, 2017 at 4:23 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> On Fri, Oct 20, 2017 at 1:01 PM, Amir Goldstein <amir73il@gmail.com> wrote:
>> Fixes: 359f392ca53e ("ovl: lookup index entry for copy up origin")
>> Cc: <stable@vger.kernel.org> # v4.13
>> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
>> ---
>>  fs/overlayfs/namei.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> Miklos,
>>
>> This is a complimentary/fixup patch to the patch currently at the tip of
>> overlayfs-next. I did not run into ENOENT in my tests, but it seems that
>> all other places in overlayfs that call lookup_one_len_unlocked() check
>> the ENOENT return value and treat it the same as negative dentry.
>>
>> I suppose this could be expected from some file systems?
>
> I haven't done the research, but I suppose it's possible.  Nobody is
> forcing filesystems to cache negative dentries, although not doing so
> might be stupid.
>
> However, the patch seems to be wrong, since it does not treat -ENOENT
> quite the same way as a negative index (no warning for hard links).
>
> Btw you can use "--suppress-cc=bodycc" to not spam stable@vger with
> review patches.
>

OK, but Greg didn't seem annoyed by getting CC'ed - on the contrary..
Anyway, sent fixed v2 and CC'ed stable, since there was already a
discussion on v1

Amir.

      reply	other threads:[~2017-10-20 14:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-20 11:01 [PATCH] ovl: handle ENOENT on index lookup Amir Goldstein
2017-10-20 11:37 ` Greg KH
2017-10-20 11:42   ` Amir Goldstein
2017-10-20 13:23 ` Miklos Szeredi
2017-10-20 14:21   ` Amir Goldstein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxgvokfgNiUCFoHtENA5-20DMB3uBN2AmfeHw5ujoQtzjg@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.