All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
	linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	David Howells <dhowells@redhat.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Shaohua Li <shli@kernel.org>,
	Steven Whitehouse <swhiteho@redhat.com>
Subject: Re: [PATCH 17/17] fs: switch ->s_uuid to uuid_t
Date: Mon, 15 May 2017 22:38:18 +0300	[thread overview]
Message-ID: <CAOQ4uxgyetFTbtuE3H2Msv9Zg1LEdoxr0YqZJ6yv0cFgiTAmAw@mail.gmail.com> (raw)
In-Reply-To: <20170515154308.26739-18-hch@lst.de>

On Mon, May 15, 2017 at 6:43 PM, Christoph Hellwig <hch@lst.de> wrote:
> For some file systems we still memcpy into it, but in various places this
> already allows us to use the proper uuid helpers.  More to come..
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---

> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -75,7 +75,7 @@ xfs_uuid_mount(
>
>         /* Publish UUID in struct super_block */
>         BUILD_BUG_ON(sizeof(mp->m_super->s_uuid) != sizeof(uuid_t));

BUILD_BUG_ON not needed anymore now that s_uuid is uuid_t

> -       memcpy(&mp->m_super->s_uuid, uuid, sizeof(uuid_t));
> +       uuid_copy(&mp->m_super->s_uuid, uuid);
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID
From: Amir Goldstein <amir73il-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: linux-xfs <linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
	Mimi Zohar
	<zohar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-fsdevel
	<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Andy Shevchenko
	<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Shaohua Li <shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Steven Whitehouse
	<swhiteho-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 17/17] fs: switch ->s_uuid to uuid_t
Date: Mon, 15 May 2017 22:38:18 +0300	[thread overview]
Message-ID: <CAOQ4uxgyetFTbtuE3H2Msv9Zg1LEdoxr0YqZJ6yv0cFgiTAmAw@mail.gmail.com> (raw)
In-Reply-To: <20170515154308.26739-18-hch-jcswGhMUV9g@public.gmane.org>

On Mon, May 15, 2017 at 6:43 PM, Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> wrote:
> For some file systems we still memcpy into it, but in various places this
> already allows us to use the proper uuid helpers.  More to come..
>
> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> ---

> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -75,7 +75,7 @@ xfs_uuid_mount(
>
>         /* Publish UUID in struct super_block */
>         BUILD_BUG_ON(sizeof(mp->m_super->s_uuid) != sizeof(uuid_t));

BUILD_BUG_ON not needed anymore now that s_uuid is uuid_t

> -       memcpy(&mp->m_super->s_uuid, uuid, sizeof(uuid_t));
> +       uuid_copy(&mp->m_super->s_uuid, uuid);

WARNING: multiple messages have this Message-ID
From: Amir Goldstein <amir73il@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Shaohua Li <shli@kernel.org>,
	Dan Williams <dan.j.williams@intel.com>,
	David Howells <dhowells@redhat.com>,
	Steven Whitehouse <swhiteho@redhat.com>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	linux-raid@vger.kernel.org, linux-nvdimm@ml01.01.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 17/17] fs: switch ->s_uuid to uuid_t
Date: Mon, 15 May 2017 22:38:18 +0300	[thread overview]
Message-ID: <CAOQ4uxgyetFTbtuE3H2Msv9Zg1LEdoxr0YqZJ6yv0cFgiTAmAw@mail.gmail.com> (raw)
In-Reply-To: <20170515154308.26739-18-hch@lst.de>

On Mon, May 15, 2017 at 6:43 PM, Christoph Hellwig <hch@lst.de> wrote:
> For some file systems we still memcpy into it, but in various places this
> already allows us to use the proper uuid helpers.  More to come..
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---

> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -75,7 +75,7 @@ xfs_uuid_mount(
>
>         /* Publish UUID in struct super_block */
>         BUILD_BUG_ON(sizeof(mp->m_super->s_uuid) != sizeof(uuid_t));

BUILD_BUG_ON not needed anymore now that s_uuid is uuid_t

> -       memcpy(&mp->m_super->s_uuid, uuid, sizeof(uuid_t));
> +       uuid_copy(&mp->m_super->s_uuid, uuid);

WARNING: multiple messages have this Message-ID
From: Amir Goldstein <amir73il@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Shaohua Li <shli@kernel.org>,
	Dan Williams <dan.j.williams@intel.com>,
	David Howells <dhowells@redhat.com>,
	Steven Whitehouse <swhiteho@redhat.com>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 17/17] fs: switch ->s_uuid to uuid_t
Date: Mon, 15 May 2017 22:38:18 +0300	[thread overview]
Message-ID: <CAOQ4uxgyetFTbtuE3H2Msv9Zg1LEdoxr0YqZJ6yv0cFgiTAmAw@mail.gmail.com> (raw)
In-Reply-To: <20170515154308.26739-18-hch@lst.de>

On Mon, May 15, 2017 at 6:43 PM, Christoph Hellwig <hch@lst.de> wrote:
> For some file systems we still memcpy into it, but in various places this
> already allows us to use the proper uuid helpers.  More to come..
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---

> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -75,7 +75,7 @@ xfs_uuid_mount(
>
>         /* Publish UUID in struct super_block */
>         BUILD_BUG_ON(sizeof(mp->m_super->s_uuid) != sizeof(uuid_t));

BUILD_BUG_ON not needed anymore now that s_uuid is uuid_t

> -       memcpy(&mp->m_super->s_uuid, uuid, sizeof(uuid_t));
> +       uuid_copy(&mp->m_super->s_uuid, uuid);

  reply	other threads:[~2017-05-15 19:38 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15 15:42 cleanup UUID types V2 Christoph Hellwig
2017-05-15 15:42 ` Christoph Hellwig
2017-05-15 15:42 ` Christoph Hellwig
2017-05-15 15:42 ` Christoph Hellwig
2017-05-15 15:42 ` [PATCH 01/17] xfs: use uuid_copy() helper to abstract uuid_t Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42 ` [PATCH 02/17] xfs: use uuid_be to implement the uuid_t type Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42 ` [PATCH 03/17] uuid: rename uuid types Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42 ` [PATCH 04/17] uuid: don't export guid_index and uuid_index Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42 ` [PATCH 05/17] uuid: add the v1 layout to uuid_t Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42 ` [PATCH 06/17] uuid: hoist helpers uuid_equal() and uuid_copy() from xfs Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42 ` [PATCH 07/17] uuid: remove the now unused uuid_be_cmp helper Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42 ` [PATCH 08/17] uuid: hoist uuid_is_null() helper from libnvdimm Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 15:42   ` Christoph Hellwig
2017-05-15 17:48   ` Dan Williams
2017-05-15 17:48     ` Dan Williams
2017-05-15 17:48     ` Dan Williams
2017-05-15 15:43 ` [PATCH 09/17] s390/sysinfo: use uuid_is_null instead of opencoding it Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43 ` [PATCH 10/17] afs: switch to use uuid_t and uuid_gen Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43 ` [PATCH 11/17] uuid: remove struct uuid_v1 Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43 ` [PATCH 12/17] xfs: remove uuid_getnodeuniq and xfs_uu_t Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43 ` [PATCH 13/17] md: namespace private helper names Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43 ` [PATCH 14/17] xfs: use the common helper uuid_is_null() Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43 ` [PATCH 15/17] block: remove blk_part_pack_uuid Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43 ` [PATCH 16/17] ima/policy: switch to use uuid_t Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43 ` [PATCH 17/17] fs: switch ->s_uuid to uuid_t Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 15:43   ` Christoph Hellwig
2017-05-15 19:38   ` Amir Goldstein [this message]
2017-05-15 19:38     ` Amir Goldstein
2017-05-15 19:38     ` Amir Goldstein
2017-05-15 19:38     ` Amir Goldstein
2017-05-16 15:53     ` Christoph Hellwig
2017-05-16 15:53       ` Christoph Hellwig
2017-05-16 15:53       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxgyetFTbtuE3H2Msv9Zg1LEdoxr0YqZJ6yv0cFgiTAmAw@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dhowells@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=shli@kernel.org \
    --cc=swhiteho@redhat.com \
    --cc=zohar@linux.vnet.ibm.com \
    --subject='Re: [PATCH 17/17] fs: switch ->s_uuid to uuid_t' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.