From: Amir Goldstein <amir73il@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Xiong Zhou <xzhou@redhat.com>, fstests <fstests@vger.kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH v4] generic: add stress test for fanotify and inotify
Date: Wed, 14 Feb 2018 13:22:06 +0200 [thread overview]
Message-ID: <CAOQ4uxhUv0Wy+v_i8mzhx5y7NA88VyULxWniJ-HXCLg_Pq7bUw@mail.gmail.com> (raw)
In-Reply-To: <20180214110331.ojgyabcta34lzo4s@quack2.suse.cz>
On Wed, Feb 14, 2018 at 1:03 PM, Jan Kara <jack@suse.cz> wrote:
> On Mon 12-02-18 13:46:48, Xiong Zhou wrote:
>> Stress test for fanotify and inotify. Exercise fanotify and
>> inotify user interfaces in loop while other stress tests going
>> on in the watched test directory.
>>
>> Watching slab object inotify_inode_mark size, report fail
>> it increases too fast. This may lead to a crash if OOM killer
>> invoked.
>>
>> kernel commit related to the fixes in v4.15-rc1:
>> 0d6ec07 fsnotify: pin both inode and vfsmount mark
>>
>> Signed-off-by: Xiong Zhou <xzhou@redhat.com>
>
> I'm sorry for chiming in so late but I was on vacation. Just one question:
> Currently, all inotify and fanotify tests are part of LTP. Is there any
> good reason for putting this particular test to fstests and not LTP?
> Specifically I've refrained from putting notification framework tests to
> fstests because there's practically no relation of it to implementation of
> any particular filesystem. Also I'd prefer not to have fanotify / inotify
> tests in two different frameworks...
>
I second that.
Also, Eryu did not chime in yet (and Dave probably did not look closely),
but I think fstests in general try to refrain from single purpose test
programs such as fsnotify_stress.
Xiong,
If you do choose to implement an LTP test as Jan recommended,
please base it on top of my patches to convert LTP inotify tests to
new lib https://github.com/linux-test-project/ltp/pull/246.
Thanks,
Amir.
next prev parent reply other threads:[~2018-02-14 11:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CCAOQ4uxh2ZmEJi8gbiDRsYefV+XC20TNLjW9OFOZM0=j0_0yf+Q@mail.gmail.com>
2018-02-11 6:59 ` [PATCH v3] generic: add stress test for fanotify and inotify Xiong Zhou
2018-02-11 20:03 ` Amir Goldstein
2018-02-12 0:41 ` Xiong Zhou
2018-02-12 3:50 ` Amir Goldstein
2018-02-12 4:33 ` Xiong Zhou
2018-02-12 5:08 ` Dave Chinner
2018-02-12 5:38 ` Xiong Zhou
2018-02-12 5:46 ` [PATCH v4] " Xiong Zhou
2018-02-12 7:02 ` Dave Chinner
2018-02-12 8:34 ` Xiong Zhou
2018-02-14 11:03 ` Jan Kara
2018-02-14 11:22 ` Amir Goldstein [this message]
2018-02-14 15:03 ` Eryu Guan
2018-02-15 8:33 ` Amir Goldstein
2018-02-15 0:49 ` Xiong Zhou
2018-02-15 9:23 ` Jan Kara
2018-02-16 0:38 ` Xiong Zhou
2018-02-16 9:52 ` Jan Kara
2018-02-17 1:21 ` Xiong Zhou
2018-02-12 5:17 ` [PATCH v3] " Xiong Zhou
2018-02-12 6:48 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxhUv0Wy+v_i8mzhx5y7NA88VyULxWniJ-HXCLg_Pq7bUw@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
--cc=miklos@szeredi.hu \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.