All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Jan Kara <jack@suse.cz>,
	Matthew Bobrowski <mbobrowski@mbobrowski.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH][v2] fanotify: fix permission model of unprivileged group
Date: Tue, 25 May 2021 16:23:25 +0300	[thread overview]
Message-ID: <CAOQ4uxhqkF7J06FCY6phoK1nY=1COo=swT8Ffg3vrU1koGs0wA@mail.gmail.com> (raw)
In-Reply-To: <20210525101505.rspv2c6kajzswvwn@wittgenstein>

On Tue, May 25, 2021 at 1:15 PM Christian Brauner
<christian.brauner@ubuntu.com> wrote:
>
> On Mon, May 24, 2021 at 04:53:21PM +0300, Amir Goldstein wrote:
> > Reporting event->pid should depend on the privileges of the user that
> > initialized the group, not the privileges of the user reading the
> > events.
>
> I think it's in general a good permission model to not have the result
> depend as little on the reader as possible post-open/init. So this makes
> a lot of sense to me and I'm a bit surprised it wasn't like that right
> away. :)
>

You are right. We got lot there.
The fact that pid_vnr() may not report pid depending on the caller's ns
contributed to the confusion for making it depend in the caller's creds,
but namespace and credentials behave differently.

Thanks for the review,
Amir.

  reply	other threads:[~2021-05-25 13:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24 13:53 [PATCH][v2] fanotify: fix permission model of unprivileged group Amir Goldstein
2021-05-24 23:13 ` Matthew Bobrowski
2021-05-25 10:14 ` Jan Kara
2021-05-25 10:15 ` Christian Brauner
2021-05-25 13:23   ` Amir Goldstein [this message]
2021-06-08 12:21 ` Greg KH
2021-06-08 12:28   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ4uxhqkF7J06FCY6phoK1nY=1COo=swT8Ffg3vrU1koGs0wA@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=christian.brauner@ubuntu.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mbobrowski@mbobrowski.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.