All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Seth Forshee <sforshee@digitalocean.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Christian Brauner <christian.brauner@ubuntu.com>
Subject: Re: [PATCH 02/10] fs: move mapping helpers
Date: Tue, 30 Nov 2021 08:35:56 +0200	[thread overview]
Message-ID: <CAOQ4uxi+3-OaZNrO2X3KawExE8PTvCkncDAsMQ8KL-UEhNwHLA@mail.gmail.com> (raw)
In-Reply-To: <20211123114227.3124056-3-brauner@kernel.org>

On Tue, Nov 23, 2021 at 3:29 PM Christian Brauner <brauner@kernel.org> wrote:
>
> From: Christian Brauner <christian.brauner@ubuntu.com>
>
> The low-level mapping helpers were so far crammed into fs.h. They are
> out of place there. The fs.h header should just contain the higher-level
> mapping helpers that interact directly with vfs objects such as struct
> super_block or struct inode and not the bare mapping helpers. Similarly,
> only vfs and specific fs code shall interact with low-level mapping
> helpers. And so they won't be made accessible automatically through
> regular {g,u}id helpers.
>
> Cc: Seth Forshee <sforshee@digitalocean.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> CC: linux-fsdevel@vger.kernel.org
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> ---
>  include/linux/fs.h          |  91 +-------------------------------
>  include/linux/mnt_mapping.h | 101 ++++++++++++++++++++++++++++++++++++
>  2 files changed, 102 insertions(+), 90 deletions(-)
>  create mode 100644 include/linux/mnt_mapping.h
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 192242476b2b..eb69e8b035fa 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -41,6 +41,7 @@
>  #include <linux/stddef.h>
>  #include <linux/mount.h>
>  #include <linux/cred.h>
> +#include <linux/mnt_mapping.h>

If I grepped correctly, there are ~20 files that use these helpers.
Please put the include in those files, so changes to this header
will not compile the world.

And how about mnt_idmapping.h or idmapped_mnt.h?
Not sure if this naming issue was discussed already.

Thanks,
Amir.

  reply	other threads:[~2021-11-30  6:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 11:42 [PATCH 00/10] Extend and tweak mapping support Christian Brauner
2021-11-23 11:42 ` [PATCH 01/10] fs: add is_mapped_mnt() helper Christian Brauner
2021-11-30  6:25   ` Amir Goldstein
2021-11-30  8:48     ` Christian Brauner
2021-11-23 11:42 ` [PATCH 02/10] fs: move mapping helpers Christian Brauner
2021-11-30  6:35   ` Amir Goldstein [this message]
2021-11-30  8:53     ` Christian Brauner
2021-11-23 11:42 ` [PATCH 03/10] fs: tweak fsuidgid_has_mapping() Christian Brauner
2021-11-30  6:44   ` Amir Goldstein
2021-11-23 11:42 ` [PATCH 04/10] fs: account for filesystem mappings Christian Brauner
2021-11-23 11:42 ` [PATCH 05/10] docs: update mapping documentation Christian Brauner
2021-11-23 11:42 ` [PATCH 06/10] fs: use low-level mapping helpers Christian Brauner
2021-11-23 11:42 ` [PATCH 07/10] fs: remove unused " Christian Brauner
2021-11-30  6:53   ` Amir Goldstein
2021-11-23 11:42 ` [PATCH 08/10] fs: port higher-level " Christian Brauner
2021-11-30  7:15   ` Amir Goldstein
2021-11-30  8:52     ` Christian Brauner
2021-11-23 11:42 ` [PATCH 09/10] fs: add i_user_ns() helper Christian Brauner
2021-11-30  7:02   ` Amir Goldstein
2021-11-23 11:42 ` [PATCH 10/10] fs: support mapped mounts of mapped filesystems Christian Brauner
2021-11-29 10:36 ` [PATCH 00/10] Extend and tweak mapping support Christian Brauner
2021-11-30  5:51 ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxi+3-OaZNrO2X3KawExE8PTvCkncDAsMQ8KL-UEhNwHLA@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=christian.brauner@ubuntu.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sforshee@digitalocean.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.