Re: fsnotify path hooks

[Amir Goldstein <amir73il@gmail.com>]

On Fri, Apr 9, 2021 at 7:06 PM Amir Goldstein <amir73il@gmail.com> wrote:
>
> On Fri, Apr 9, 2021 at 5:30 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > On Fri, Apr 09, 2021 at 04:22:58PM +0300, Amir Goldstein wrote:
> >
> > > But we are actually going in cycles around the solution that we all want,
> > > but fear of rejection. It's time to try and solicit direct feedback from Al.
> > >
> > > Al,
> > >
> > > would you be ok with passing mnt arg to vfs_create() and friends,
> > > so that we can pass that to fsnotify_create() (and friends) in order to
> > > be able to report FAN_CREATE events to FAN_MARK_MOUNT listeners?
> >
> > I would very much prefer to avoid going that way.
>
> OK, so I will go with the more "expressive" implementation that Jan suggested.
>
> Callers that do NOT care about mount mark semantics will use the
> wrapper:
>
> vfs_create_notify(mnt, ...)

Oops, there was not supposed to be mnt arg in this wrapper -
that's the point.
Maybe I should name it xxx_inode_notify() to be more exact.

Thanks,
Amir.

> {
>     vfs_create(...
>     fsnotify_create(NULL,...
> }
>
> The two callers that do care about mount mark semantics (syscalls
> and nfsd) will open code:
>
> vfs_create(...
> fsnotify_create(mnt,...
>
> Hope that way works better for you.
>
> Thanks,
> Amir.