From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AC5BC33C99 for ; Tue, 7 Jan 2020 10:12:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFBD92077B for ; Tue, 7 Jan 2020 10:12:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mE+vclw3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727822AbgAGKMN (ORCPT ); Tue, 7 Jan 2020 05:12:13 -0500 Received: from mail-io1-f68.google.com ([209.85.166.68]:44804 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726558AbgAGKMM (ORCPT ); Tue, 7 Jan 2020 05:12:12 -0500 Received: by mail-io1-f68.google.com with SMTP id b10so51989466iof.11; Tue, 07 Jan 2020 02:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PbyQyZ9o+Ro7E6bXOC6SCrk7HuZRr+h0vUWe4gZ98uQ=; b=mE+vclw3cfYF8tFzCALd6ffjBbn9elwbyo2EMwffZsN59D8gkO888bX94L0BigDx7F v4pyG7hhBxC13kJmfR5Yx8yFLrRgTbf53DgRK+6BNulX4LVJ88/uqtPDurJ+IbRaAmKe 8EWtlB5diKEI3JJzHIL8tmpDSqiLcfuZhHLn6DioccebewAhH/tDiUTWY3XPDQVBh5ZG rvl714eo8s/x6NhqpZbqD0JRkjrfe02kKiYkAiEV5zMYyvV91xk04MCXKgcpnnVq4paH LtkyG1gx+IMCw52HZAq5gzXbppsUW0ZEga4mS2tYjQn9/QgoxTukRxnnCE3/iT4jmU9B 09xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PbyQyZ9o+Ro7E6bXOC6SCrk7HuZRr+h0vUWe4gZ98uQ=; b=fNWl0PPULz+gTBaZQtSSdEY6kQW403O0mhiHGQplPgu4/CkIPagZzL6EpGywS1uXsQ tnZIpkZnQFCjNWxiuH7+iMFBSsYO9UsW0mNC/nBLYz41Ksw9z8SDmDrPiWO0VP4xLdy3 shVqUd+98Z6FWtMdVoqLXdbn4dLmVp0nN7UHceccNE6Chfb6mEhHT5qmVn8HyJN3yvyb /kwtaonwNrVu8xr/6oVqv1iLKj9HikVGe1Ku5NW5TXdIKCeZR7bdWP8AZD6F7Pevm6L+ 7sXgt0DroheBEPCExPgkGilCSLji7gHnLCcch4195mk3CUkIe0LNAPniGxlRJ7xy/uYP r3jQ== X-Gm-Message-State: APjAAAUfjhrMX3HbMOIzLc4sXmGuSK+SUWgbgYoHAJqKvFGJC2AlDmm0 A6umI48uuI8oMhFPzbmgf8/gqwLFErumDDSfle1wgw== X-Google-Smtp-Source: APXvYqx3r2qgxfq0fEj3TX01n99so2jqPkAzW5BeIfMPMxERNE6WNcSTMhTdDGboy4GGuyjRN9uytisFExuwcaccWaw= X-Received: by 2002:a02:81cc:: with SMTP id r12mr80549653jag.93.1578391931918; Tue, 07 Jan 2020 02:12:11 -0800 (PST) MIME-Version: 1.0 References: <20200107001039.GM23195@dread.disaster.area> <20200107001643.GA485121@chrisdown.name> <20200107003944.GN23195@dread.disaster.area> In-Reply-To: From: Amir Goldstein Date: Tue, 7 Jan 2020 12:12:00 +0200 Message-ID: Subject: Re: [PATCH v5 2/2] tmpfs: Support 64-bit inums per-sb To: Hugh Dickins Cc: Dave Chinner , Chris Down , Linux MM , Andrew Morton , Al Viro , Matthew Wilcox , Jeff Layton , Johannes Weiner , Tejun Heo , linux-fsdevel , linux-kernel , kernel-team@fb.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 7, 2020 at 10:36 AM Hugh Dickins wrote: > > On Tue, 7 Jan 2020, Amir Goldstein wrote: > > On Tue, Jan 7, 2020 at 2:40 AM Dave Chinner wrote: > > > On Tue, Jan 07, 2020 at 12:16:43AM +0000, Chris Down wrote: > > > > Dave Chinner writes: > > > > > It took 15 years for us to be able to essentially deprecate > > > > > inode32 (inode64 is the default behaviour), and we were very happy > > > > > to get that albatross off our necks. In reality, almost everything > > > > > out there in the world handles 64 bit inodes correctly > > > > > including 32 bit machines and 32bit binaries on 64 bit machines. > > > > > And, IMNSHO, there no excuse these days for 32 bit binaries that > > > > > don't using the *64() syscall variants directly and hence support > > > > > 64 bit inodes correctlyi out of the box on all platforms. > > Interesting take on it. I'd all along imagined we would have to resort > to a mount option for safety, but Dave is right that I was too focused on > avoiding tmpfs regressions, without properly realizing that people were > very unlikely to have written such tools for tmpfs in particular, but > written them for all filesystems, and already encountered and fixed > such EOVERFLOWs for other filesystems. > > Hmm, though how readily does XFS actually reach the high inos on > ordinary users' systems? > Define 'ordinary' I my calculations are correct, with default mkfs.xfs any inode allocated from logical offset > 2TB on a volume has high ino bits set. Besides, a deployment with more than 4G inodes shouldn't be hard to find. Thanks, Amir. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B665CC33C9E for ; Tue, 7 Jan 2020 10:12:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 51E2720678 for ; Tue, 7 Jan 2020 10:12:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mE+vclw3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51E2720678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9B20D8E0022; Tue, 7 Jan 2020 05:12:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 964DC8E001E; Tue, 7 Jan 2020 05:12:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8790D8E0022; Tue, 7 Jan 2020 05:12:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id 7377B8E001E for ; Tue, 7 Jan 2020 05:12:13 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 38ED73D12 for ; Tue, 7 Jan 2020 10:12:13 +0000 (UTC) X-FDA: 76350422946.30.women09_87bd1ded20037 X-HE-Tag: women09_87bd1ded20037 X-Filterd-Recvd-Size: 4913 Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Jan 2020 10:12:12 +0000 (UTC) Received: by mail-io1-f67.google.com with SMTP id v3so1127863ioj.5 for ; Tue, 07 Jan 2020 02:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PbyQyZ9o+Ro7E6bXOC6SCrk7HuZRr+h0vUWe4gZ98uQ=; b=mE+vclw3cfYF8tFzCALd6ffjBbn9elwbyo2EMwffZsN59D8gkO888bX94L0BigDx7F v4pyG7hhBxC13kJmfR5Yx8yFLrRgTbf53DgRK+6BNulX4LVJ88/uqtPDurJ+IbRaAmKe 8EWtlB5diKEI3JJzHIL8tmpDSqiLcfuZhHLn6DioccebewAhH/tDiUTWY3XPDQVBh5ZG rvl714eo8s/x6NhqpZbqD0JRkjrfe02kKiYkAiEV5zMYyvV91xk04MCXKgcpnnVq4paH LtkyG1gx+IMCw52HZAq5gzXbppsUW0ZEga4mS2tYjQn9/QgoxTukRxnnCE3/iT4jmU9B 09xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PbyQyZ9o+Ro7E6bXOC6SCrk7HuZRr+h0vUWe4gZ98uQ=; b=uT1I6IrXhU624An6X5QomOI0iDlAw+8oa6Kzj7C53ZBCOzZH9IacoBcMdj1SNgdjJv RuBbUHoZqVvOl1KZfccemOhX8MWAXuFk4kdhFy8dpodaXdckH0HP2hlhAm4ZWxpQU8fM z+OX5V/Uq13zbQwzPDauy+T8cvSa2Lj77Pl/i7LNfgRJDZ+obxJdEqdDx2xlgvlKaCLF RgEzlmkWjRANDv/jVLPr0ww/w00ZA6gibae8qvRkep59SRTU/3VUa7m3/fQu9oD121hS vmZoZVBN4kpVql+Wr/m7QSP+JorEr9T807/LLzvDB4oI2aUpbf3D1KAfqoMNcO9Af//B qbxQ== X-Gm-Message-State: APjAAAVZaCPRY6jAco2vjqHLMNlh4XUsCPstZcn6HaGGyLJe34P5e6Bk G8pmKtyRNOkhofSc03wGc674cv8E5MFuyUekjZA= X-Google-Smtp-Source: APXvYqx3r2qgxfq0fEj3TX01n99so2jqPkAzW5BeIfMPMxERNE6WNcSTMhTdDGboy4GGuyjRN9uytisFExuwcaccWaw= X-Received: by 2002:a02:81cc:: with SMTP id r12mr80549653jag.93.1578391931918; Tue, 07 Jan 2020 02:12:11 -0800 (PST) MIME-Version: 1.0 References: <20200107001039.GM23195@dread.disaster.area> <20200107001643.GA485121@chrisdown.name> <20200107003944.GN23195@dread.disaster.area> In-Reply-To: From: Amir Goldstein Date: Tue, 7 Jan 2020 12:12:00 +0200 Message-ID: Subject: Re: [PATCH v5 2/2] tmpfs: Support 64-bit inums per-sb To: Hugh Dickins Cc: Dave Chinner , Chris Down , Linux MM , Andrew Morton , Al Viro , Matthew Wilcox , Jeff Layton , Johannes Weiner , Tejun Heo , linux-fsdevel , linux-kernel , kernel-team@fb.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 7, 2020 at 10:36 AM Hugh Dickins wrote: > > On Tue, 7 Jan 2020, Amir Goldstein wrote: > > On Tue, Jan 7, 2020 at 2:40 AM Dave Chinner wrote: > > > On Tue, Jan 07, 2020 at 12:16:43AM +0000, Chris Down wrote: > > > > Dave Chinner writes: > > > > > It took 15 years for us to be able to essentially deprecate > > > > > inode32 (inode64 is the default behaviour), and we were very happy > > > > > to get that albatross off our necks. In reality, almost everything > > > > > out there in the world handles 64 bit inodes correctly > > > > > including 32 bit machines and 32bit binaries on 64 bit machines. > > > > > And, IMNSHO, there no excuse these days for 32 bit binaries that > > > > > don't using the *64() syscall variants directly and hence support > > > > > 64 bit inodes correctlyi out of the box on all platforms. > > Interesting take on it. I'd all along imagined we would have to resort > to a mount option for safety, but Dave is right that I was too focused on > avoiding tmpfs regressions, without properly realizing that people were > very unlikely to have written such tools for tmpfs in particular, but > written them for all filesystems, and already encountered and fixed > such EOVERFLOWs for other filesystems. > > Hmm, though how readily does XFS actually reach the high inos on > ordinary users' systems? > Define 'ordinary' I my calculations are correct, with default mkfs.xfs any inode allocated from logical offset > 2TB on a volume has high ino bits set. Besides, a deployment with more than 4G inodes shouldn't be hard to find. Thanks, Amir.