From: Amir Goldstein <firstname.lastname@example.org> To: "Darrick J. Wong" <email@example.com> Cc: Eryu Guan <firstname.lastname@example.org>, linux-xfs <email@example.com>, fstests <firstname.lastname@example.org>, Eryu Guan <email@example.com> Subject: Re: [PATCHSET RFC 00/10] fstests: move test group lists into test files Date: Thu, 3 Jun 2021 19:56:49 +0300 [thread overview] Message-ID: <CAOQ4uxiVSCjMfCv8+tK84jLV6d9torFo-16esk3+15PNn_+T3w@mail.gmail.com> (raw) In-Reply-To: <20210603153406.GV26380@locust> On Thu, Jun 3, 2021 at 6:34 PM Darrick J. Wong <firstname.lastname@example.org> wrote: > > On Thu, Jun 03, 2021 at 09:32:16AM +0300, Amir Goldstein wrote: > > On Wed, May 26, 2021 at 5:50 AM Darrick J. Wong <email@example.com> wrote: > > > > > > Hi all, > > > > > > Test group files (e.g. tests/generic/group) are a pain to keep up. > > > Every week I rebase on Eryu's latest upstream, and every week I have to > > > slog through dozens of trivial merge conflicts because of the > > > groupfiles. Moving tests is annoying because we have to maintain all > > > this code to move the group associations from one /group file to > > > another. > > > > > > It doesn't need to be this way -- we could move each test's group > > > information into the test itself, and automatically generate the group > > > files as part of the make process. This series does exactly that. > > > > > > > This looks very nice :) > > > > I do have one concern. > > If the auto-generated group files keep the same path as the existing > > source controlled group files, checkout of pre/post this change is > > going to be challenging for developers running make in the source > > directory. > > <nod> A temporary pain until everyone rebases, but you're right, that's > going to annoy people unnecessarily. > > Admittedly I left it as tests/*/group to avoid making any other changes. > All three lines' worth in check. :P > > > Also .gitignore entries are needed for the auto-generated group files. > > Heh, oops. Will fix. > > > I wonder if it wouldn't be easier for everyone if the auto-generated > > groups had a different name. > > Probably. We could blast fstests 25 years into the future and change > the name to "hashtag" :P > > How about "group.map" ? > <shrug> that's the hardest part ;-) I'm fine with group.map group.list group.autogen or whatnot. I am used to typing the prefix of the group file path in shell commands, but auto-complete should take care of any suffix. Thanks, Amir.
next prev parent reply other threads:[~2021-06-03 16:57 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-26 1:46 Darrick J. Wong 2021-05-26 1:46 ` [PATCH 01/10] fstests: fix group check in new script Darrick J. Wong 2021-05-26 1:46 ` [PATCH 02/10] fstests: refactor setting test sequence number variables Darrick J. Wong 2021-05-26 1:46 ` [PATCH 03/10] fstests: add tool migrate group membership data to test files Darrick J. Wong 2021-05-26 1:47 ` [PATCH 04/10] fstests: move test group info " Darrick J. Wong 2021-06-03 4:58 ` Eric Biggers 2021-06-03 15:23 ` Darrick J. Wong 2021-05-26 1:47 ` [PATCH 05/10] fstests: clean up open-coded golden output Darrick J. Wong 2021-05-26 1:47 ` [PATCH 06/10] fstests: automatically generate group files Darrick J. Wong 2021-05-26 1:47 ` [PATCH 07/10] fstests: convert nextid to use automatic group generation Darrick J. Wong 2021-05-26 1:47 ` [PATCH 08/10] fstests: adapt the new test script to our new group tagging scheme Darrick J. Wong 2021-05-26 1:47 ` [PATCH 09/10] fstests: remove group files Darrick J. Wong 2021-05-26 1:47 ` [PATCH 10/10] fstests: remove test group management code Darrick J. Wong 2021-06-03 6:32 ` [PATCHSET RFC 00/10] fstests: move test group lists into test files Amir Goldstein 2021-06-03 15:34 ` Darrick J. Wong 2021-06-03 16:56 ` Amir Goldstein [this message] 2021-06-03 22:21 ` Darrick J. Wong 2021-06-06 14:44 ` Eryu Guan 2021-06-06 18:05 ` Darrick J. Wong 2021-06-07 17:06 ` Darrick J. Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAOQ4uxiVSCjMfCv8+tK84jLV6d9torFo-16esk3+15PNn_+T3w@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCHSET RFC 00/10] fstests: move test group lists into test files' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.