From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amir Goldstein Subject: Re: [PATCH 05/13] ovl: During copy up, first copy up metadata and then data Date: Thu, 26 Oct 2017 08:42:08 +0300 Message-ID: References: <1508958575-14086-1-git-send-email-vgoyal@redhat.com> <1508958575-14086-6-git-send-email-vgoyal@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-yw0-f193.google.com ([209.85.161.193]:53488 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbdJZFmJ (ORCPT ); Thu, 26 Oct 2017 01:42:09 -0400 Received: by mail-yw0-f193.google.com with SMTP id q126so1959629ywq.10 for ; Wed, 25 Oct 2017 22:42:09 -0700 (PDT) In-Reply-To: <1508958575-14086-6-git-send-email-vgoyal@redhat.com> Sender: linux-unionfs-owner@vger.kernel.org List-Id: linux-unionfs@vger.kernel.org To: Vivek Goyal Cc: overlayfs , Miklos Szeredi On Wed, Oct 25, 2017 at 10:09 PM, Vivek Goyal wrote: > Just a little re-ordering of code. This helps with next patch where after > copying up metadata, we skip data copying step, if needed. > > Signed-off-by: Vivek Goyal Please add Reviewed-by: Amir Goldstein if you post again with no changes to patch, so help me avoid re-review Thanks > --- > fs/overlayfs/copy_up.c | 33 ++++++++++++++++----------------- > 1 file changed, 16 insertions(+), 17 deletions(-) > > diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c > index 8a8f538..4f580ec 100644 > --- a/fs/overlayfs/copy_up.c > +++ b/fs/overlayfs/copy_up.c > @@ -445,6 +445,21 @@ static int ovl_copy_up_inode(struct ovl_copy_up_ctx *c, struct dentry *temp) > { > int err; > > + err = ovl_copy_xattr(c->lowerpath.dentry, temp); > + if (err) > + return err; > + > + /* > + * Store identifier of lower inode in upper inode xattr to > + * allow lookup of the copy up origin inode. > + * > + */ > + if (c->origin) { > + err = ovl_set_origin(c->dentry, c->lowerpath.dentry, temp); > + if (err) > + return err; > + } > + > if (S_ISREG(c->stat.mode)) { > struct path upperpath; > > @@ -457,27 +472,11 @@ static int ovl_copy_up_inode(struct ovl_copy_up_ctx *c, struct dentry *temp) > return err; > } > > - err = ovl_copy_xattr(c->lowerpath.dentry, temp); > - if (err) > - return err; > - > inode_lock(temp->d_inode); > err = ovl_set_attr(temp, &c->stat); > inode_unlock(temp->d_inode); > - if (err) > - return err; > - > - /* > - * Store identifier of lower inode in upper inode xattr to > - * allow lookup of the copy up origin inode. > - */ > - if (c->origin) { > - err = ovl_set_origin(c->dentry, c->lowerpath.dentry, temp); > - if (err) > - return err; > - } > > - return 0; > + return err; > } > > static int ovl_copy_up_locked(struct ovl_copy_up_ctx *c) > -- > 2.5.5 >