From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD256C433EF for ; Wed, 27 Oct 2021 10:01:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99BCD610A0 for ; Wed, 27 Oct 2021 10:01:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231950AbhJ0KDe (ORCPT ); Wed, 27 Oct 2021 06:03:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241308AbhJ0KD0 (ORCPT ); Wed, 27 Oct 2021 06:03:26 -0400 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CC42C061236 for ; Wed, 27 Oct 2021 03:00:19 -0700 (PDT) Received: by mail-il1-x132.google.com with SMTP id j3so2320978ilr.6 for ; Wed, 27 Oct 2021 03:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wVDq4qGtvBUIvYpOPIZ9ChGPxQN3o9QK0Et0DoTcGwU=; b=XN/x9/Q1SJ537/rjg6IB8vGfIF93SaLqygc1HFCyptmeYpOocq0P8B7OBAl0AOQKpe pPL5+shyk8R6y7LLi8UMkFz/ib0cBgCttHV1ONLMNY8n3/83ZrcloNnq8n5OFpRBMiiH twLvB/mZjg2wlbSF/QYiA+PFcynMOysfMaEs+n/l2sXOJF5TLSfMgzfbuXm2G5n6OxFs v6TLOcPe1OEsabnK1rlU3zGBjpE8AMcb2jXPudXBz/osA7IrQEgsjFnlP6A9AiVUJDRd lPoen1kiBW4ua82EcAr8Q11CMdoJwu5UJxBCuMzxmmaHmpOpXRnxkYUJFDnqf7Twql9i OmDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wVDq4qGtvBUIvYpOPIZ9ChGPxQN3o9QK0Et0DoTcGwU=; b=uPd7zzKEM4vlSFQd7gFGJKAbRjj7Qvq0mmBWOhnaGcmEHApoNIN3foQA/18rWK2uwX uBDr0/BnyFMIJ5qdToydqZLJrCupkF0SZ8OUJuJy6QtMDRXqS6mn4TIR/xbHsGcV0Q/H cnWpQh5ZjkkCP+h3iCv6cSkjA/lsjUMTxZEJuNgmoBJnSfASlTnAYgVYWveSfpr3HBfE PzjxXYPXUrYLLRLxRckVxVs/vK4WmLwlzikaIRl4/Jo5UTqPGjDAWCd7xx4UXxBBoQi1 FpUYswOBgVZ/rRXhbbYPK/DHVeBWLzx2rEhSBLikIuQBMsU6gYS0aQHuShpbR1j2FM8Y IPVA== X-Gm-Message-State: AOAM530MWWq4CwwaHiQ7AZm4jun2Y+Wm7+6ZBcKscXgz6yV6RXbDentd PeiWycDV6tBNX5RRrfxgjcP8VKYGzd6uitF3Ius= X-Google-Smtp-Source: ABdhPJyCTIYtp5qhPBPELxj29cZ1X8S9hZBdzlU2Bkz8u6Vruts0jrfrSsG+Qdg9xt33e4wtVMZ4SaxS6c+OWFicsaU= X-Received: by 2002:a92:c083:: with SMTP id h3mr18481400ile.107.1635328818750; Wed, 27 Oct 2021 03:00:18 -0700 (PDT) MIME-Version: 1.0 References: <20211026184239.151156-1-krisman@collabora.com> <20211026184239.151156-11-krisman@collabora.com> In-Reply-To: <20211026184239.151156-11-krisman@collabora.com> From: Amir Goldstein Date: Wed, 27 Oct 2021 13:00:07 +0300 Message-ID: Subject: Re: [PATCH v2 10/10] syscalls/fanotify20: Test capture of multiple errors To: Gabriel Krisman Bertazi Cc: LTP List , Jan Kara , Khazhismel Kumykov , kernel@collabora.com, Ext4 , Matthew Bobrowski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Oct 26, 2021 at 9:44 PM Gabriel Krisman Bertazi wrote: > > When multiple FS errors occur, only the first is stored. This testcase > validates this behavior by issuing two different errors and making sure > only the first is stored, while the second is simply accumulated in > error_count. > > Signed-off-by: Gabriel Krisman Bertazi Reviewed-by: Amir Goldstein > --- > .../kernel/syscalls/fanotify/fanotify20.c | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/testcases/kernel/syscalls/fanotify/fanotify20.c b/testcases/kernel/syscalls/fanotify/fanotify20.c > index 7bcddcaa98cb..0083a018f2c6 100644 > --- a/testcases/kernel/syscalls/fanotify/fanotify20.c > +++ b/testcases/kernel/syscalls/fanotify/fanotify20.c > @@ -78,6 +78,18 @@ static void tcase2_trigger_lookup(void) > ret, BAD_DIR, errno, EUCLEAN); > } > > +static void tcase3_trigger(void) > +{ > + trigger_fs_abort(); > + tcase2_trigger_lookup(); So after remount,abort filesystem operations can still be executed? Then I guess my comment from the previous patch about running the test in a loop is not relevant? Thanks, Amir. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7019C433EF for ; Wed, 27 Oct 2021 10:00:33 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AFA461052 for ; Wed, 27 Oct 2021 10:00:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2AFA461052 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 9B03C3C68A0 for ; Wed, 27 Oct 2021 12:00:31 +0200 (CEST) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id C5B1D3C658F for ; Wed, 27 Oct 2021 12:00:21 +0200 (CEST) Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id D10A22010EA for ; Wed, 27 Oct 2021 12:00:19 +0200 (CEST) Received: by mail-il1-x136.google.com with SMTP id w15so2321976ilv.5 for ; Wed, 27 Oct 2021 03:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wVDq4qGtvBUIvYpOPIZ9ChGPxQN3o9QK0Et0DoTcGwU=; b=XN/x9/Q1SJ537/rjg6IB8vGfIF93SaLqygc1HFCyptmeYpOocq0P8B7OBAl0AOQKpe pPL5+shyk8R6y7LLi8UMkFz/ib0cBgCttHV1ONLMNY8n3/83ZrcloNnq8n5OFpRBMiiH twLvB/mZjg2wlbSF/QYiA+PFcynMOysfMaEs+n/l2sXOJF5TLSfMgzfbuXm2G5n6OxFs v6TLOcPe1OEsabnK1rlU3zGBjpE8AMcb2jXPudXBz/osA7IrQEgsjFnlP6A9AiVUJDRd lPoen1kiBW4ua82EcAr8Q11CMdoJwu5UJxBCuMzxmmaHmpOpXRnxkYUJFDnqf7Twql9i OmDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wVDq4qGtvBUIvYpOPIZ9ChGPxQN3o9QK0Et0DoTcGwU=; b=Cc9BMKAaJHfUEMhe+HfDiI7v1Uyk7pzok8fRsAPmzRLaoHdkLml0bescLGlAZTJ/oI 8rQOidAe0zdozpJcjiKRvQO6/QaVZcnnxpcsR+r+LCQN/2kqCrZu4N12/Pz7JMdjucX7 YqvSflTv60sipMH4L6JibSVqo/96oecp6eV/hsEuKyxvNo/nWyLI3GnvrTK7EUpgHdMx njVCFBS8ZGA5s02TvhrtQwkaB7TIAq3/nuu82m+D5j379NIF2VjAfQIe6ZeGhwufhKWJ qEqNnv6ZDsiOcASEszgMvyUC7XNi2OXz4MYl4ygHZV3fxsApAUubWwY/6OhAmshpjEPW DMRA== X-Gm-Message-State: AOAM533B7IR1y/DrwsmJ9ARH7oILfD0oX82v4+kj2qJHwAhjmgB7bdYT KWmo7B4ko385l67r4l7mT72wTL5pL0z+RqUAuF8= X-Google-Smtp-Source: ABdhPJyCTIYtp5qhPBPELxj29cZ1X8S9hZBdzlU2Bkz8u6Vruts0jrfrSsG+Qdg9xt33e4wtVMZ4SaxS6c+OWFicsaU= X-Received: by 2002:a92:c083:: with SMTP id h3mr18481400ile.107.1635328818750; Wed, 27 Oct 2021 03:00:18 -0700 (PDT) MIME-Version: 1.0 References: <20211026184239.151156-1-krisman@collabora.com> <20211026184239.151156-11-krisman@collabora.com> In-Reply-To: <20211026184239.151156-11-krisman@collabora.com> From: Amir Goldstein Date: Wed, 27 Oct 2021 13:00:07 +0300 Message-ID: To: Gabriel Krisman Bertazi X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 10/10] syscalls/fanotify20: Test capture of multiple errors X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@collabora.com, Khazhismel Kumykov , Matthew Bobrowski , Jan Kara , Ext4 , LTP List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" On Tue, Oct 26, 2021 at 9:44 PM Gabriel Krisman Bertazi wrote: > > When multiple FS errors occur, only the first is stored. This testcase > validates this behavior by issuing two different errors and making sure > only the first is stored, while the second is simply accumulated in > error_count. > > Signed-off-by: Gabriel Krisman Bertazi Reviewed-by: Amir Goldstein > --- > .../kernel/syscalls/fanotify/fanotify20.c | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/testcases/kernel/syscalls/fanotify/fanotify20.c b/testcases/kernel/syscalls/fanotify/fanotify20.c > index 7bcddcaa98cb..0083a018f2c6 100644 > --- a/testcases/kernel/syscalls/fanotify/fanotify20.c > +++ b/testcases/kernel/syscalls/fanotify/fanotify20.c > @@ -78,6 +78,18 @@ static void tcase2_trigger_lookup(void) > ret, BAD_DIR, errno, EUCLEAN); > } > > +static void tcase3_trigger(void) > +{ > + trigger_fs_abort(); > + tcase2_trigger_lookup(); So after remount,abort filesystem operations can still be executed? Then I guess my comment from the previous patch about running the test in a loop is not relevant? Thanks, Amir. -- Mailing list info: https://lists.linux.it/listinfo/ltp