All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Seth Forshee <sforshee@digitalocean.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Christian Brauner <christian.brauner@ubuntu.com>
Subject: Re: [PATCH 09/10] fs: add i_user_ns() helper
Date: Tue, 30 Nov 2021 09:02:34 +0200	[thread overview]
Message-ID: <CAOQ4uxidcYH8NRGaVgEHamsMjpKPaGvKvu0sqw8_bjZg=igmuQ@mail.gmail.com> (raw)
In-Reply-To: <20211123114227.3124056-10-brauner@kernel.org>

On Tue, Nov 23, 2021 at 3:29 PM Christian Brauner <brauner@kernel.org> wrote:
>
> From: Christian Brauner <christian.brauner@ubuntu.com>
>
> Since we'll be passing the filesystem's idmapping in even more places in
> the following patches and we do already dereference struct inode to get
> to the filesystem's idmapping multiple times add a tiny helper.
>
> Cc: Seth Forshee <sforshee@digitalocean.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> CC: linux-fsdevel@vger.kernel.org
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> ---
Reviewed-by: Amir Goldstein <amir73il@gmail.com>

>  include/linux/fs.h | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 6ccb0e7f8801..c1780be923fa 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -1600,6 +1600,11 @@ struct super_block {
>         struct list_head        s_inodes_wb;    /* writeback inodes */
>  } __randomize_layout;
>
> +static inline struct user_namespace *i_user_ns(const struct inode *inode)
> +{
> +       return inode->i_sb->s_user_ns;
> +}
> +
>  /* Helper functions so that in most cases filesystems will
>   * not need to deal directly with kuid_t and kgid_t and can
>   * instead deal with the raw numeric values that are stored
> @@ -1607,22 +1612,22 @@ struct super_block {
>   */
>  static inline uid_t i_uid_read(const struct inode *inode)
>  {
> -       return from_kuid(inode->i_sb->s_user_ns, inode->i_uid);
> +       return from_kuid(i_user_ns(inode), inode->i_uid);
>  }
>
>  static inline gid_t i_gid_read(const struct inode *inode)
>  {
> -       return from_kgid(inode->i_sb->s_user_ns, inode->i_gid);
> +       return from_kgid(i_user_ns(inode), inode->i_gid);
>  }
>
>  static inline void i_uid_write(struct inode *inode, uid_t uid)
>  {
> -       inode->i_uid = make_kuid(inode->i_sb->s_user_ns, uid);
> +       inode->i_uid = make_kuid(i_user_ns(inode), uid);
>  }
>
>  static inline void i_gid_write(struct inode *inode, gid_t gid)
>  {
> -       inode->i_gid = make_kgid(inode->i_sb->s_user_ns, gid);
> +       inode->i_gid = make_kgid(i_user_ns(inode), gid);
>  }
>
>  /**
> --
> 2.30.2
>

  reply	other threads:[~2021-11-30  7:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 11:42 [PATCH 00/10] Extend and tweak mapping support Christian Brauner
2021-11-23 11:42 ` [PATCH 01/10] fs: add is_mapped_mnt() helper Christian Brauner
2021-11-30  6:25   ` Amir Goldstein
2021-11-30  8:48     ` Christian Brauner
2021-11-23 11:42 ` [PATCH 02/10] fs: move mapping helpers Christian Brauner
2021-11-30  6:35   ` Amir Goldstein
2021-11-30  8:53     ` Christian Brauner
2021-11-23 11:42 ` [PATCH 03/10] fs: tweak fsuidgid_has_mapping() Christian Brauner
2021-11-30  6:44   ` Amir Goldstein
2021-11-23 11:42 ` [PATCH 04/10] fs: account for filesystem mappings Christian Brauner
2021-11-23 11:42 ` [PATCH 05/10] docs: update mapping documentation Christian Brauner
2021-11-23 11:42 ` [PATCH 06/10] fs: use low-level mapping helpers Christian Brauner
2021-11-23 11:42 ` [PATCH 07/10] fs: remove unused " Christian Brauner
2021-11-30  6:53   ` Amir Goldstein
2021-11-23 11:42 ` [PATCH 08/10] fs: port higher-level " Christian Brauner
2021-11-30  7:15   ` Amir Goldstein
2021-11-30  8:52     ` Christian Brauner
2021-11-23 11:42 ` [PATCH 09/10] fs: add i_user_ns() helper Christian Brauner
2021-11-30  7:02   ` Amir Goldstein [this message]
2021-11-23 11:42 ` [PATCH 10/10] fs: support mapped mounts of mapped filesystems Christian Brauner
2021-11-29 10:36 ` [PATCH 00/10] Extend and tweak mapping support Christian Brauner
2021-11-30  5:51 ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ4uxidcYH8NRGaVgEHamsMjpKPaGvKvu0sqw8_bjZg=igmuQ@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=christian.brauner@ubuntu.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sforshee@digitalocean.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.