From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f172.google.com ([209.85.213.172]:43593 "EHLO mail-yb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753622AbeDSOHa (ORCPT ); Thu, 19 Apr 2018 10:07:30 -0400 Received: by mail-yb0-f172.google.com with SMTP id y123-v6so1855340ybe.10 for ; Thu, 19 Apr 2018 07:07:30 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180419135950.6rifn5wepczwqc37@quack2.suse.cz> References: <1522934301-6520-1-git-send-email-amir73il@gmail.com> <1522934301-6520-17-git-send-email-amir73il@gmail.com> <20180419135950.6rifn5wepczwqc37@quack2.suse.cz> From: Amir Goldstein Date: Thu, 19 Apr 2018 17:07:29 +0300 Message-ID: Subject: Re: [PATCH v2 16/20] fsnotify: generalize fsnotify_detach_connector_from_object() To: Jan Kara Cc: Miklos Szeredi , Marko Rauhamaa , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Apr 19, 2018 at 4:59 PM, Jan Kara wrote: > On Thu 05-04-18 16:18:17, Amir Goldstein wrote: >> Use helper fsnotify_connector_obj() helper to reduce object type >> dependent code. >> >> Signed-off-by: Amir Goldstein > > So up to this patch I had only minor comments so once you address them > could you please send these preparatory cleanups, I'll go through them and > can then queue them up for 4.18-rc1? I like them and I think they are > worthwhile cleanups regardless of the new watch type so we don't need to > delay them more than necessary... > Will do. Will also top them up with this fanotify refactoring patch: [19/20] fanotify: factor out helpers to add/remove mark Thanks, Amir.