From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f66.google.com ([209.85.218.66]:36331 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757310AbdADKpp (ORCPT ); Wed, 4 Jan 2017 05:45:45 -0500 Received: by mail-oi0-f66.google.com with SMTP id u15so74067331oie.3 for ; Wed, 04 Jan 2017 02:45:42 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20170104103958.GN3780@quack2.suse.cz> References: <1482867148-31497-1-git-send-email-amir73il@gmail.com> <20170104082844.GH3780@quack2.suse.cz> <20170104103958.GN3780@quack2.suse.cz> From: Amir Goldstein Date: Wed, 4 Jan 2017 12:45:41 +0200 Message-ID: Subject: Re: [RFC][PATCH 0/4] fsnotify: pass single mark to handle_event() To: Jan Kara Cc: Eric Paris , linux-fsdevel Content-Type: text/plain; charset=UTF-8 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jan 4, 2017 at 12:39 PM, Jan Kara wrote: > On Wed 04-01-17 11:57:04, Amir Goldstein wrote: ... >> Yes, I am aware of those testcases. >> I find LTP quite heavy to build, so I though I would spin a dedicated >> testsuite that will contain your testcases, but will also include >> infrastructure for stress testing and profiling. >> Keeping track of performance regressions is clearly a major aspect >> of maintaining fsnotify. > > Yeah, I don't build full LTP, just testcases in those two directories. LTP seems to have this massive build system around it. So just to give me a head start, do you use any custom build scripts to build just those testcases? or simple make inside their directory will do the trick (it didn't seem so simple from first look). > The > advantage of LTP is that quite a few people run it so you get a decent test > coverage on different systems (and I've got reports from people running LTP > about regressions in fsnotify code). So I'd prefer to have the functional > tests in LTP if reasonably feasible. Sure. That's makes a lot of sense. > But with respect to performance > testing or some crazy stress tests which take long to execute I can definitely > see space for a dedicated test suite. > > Honza > -- > Jan Kara > SUSE Labs, CR