All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Zorro Lang <zlang@redhat.com>, fstests <fstests@vger.kernel.org>,
	"Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH] generic/411: change sub-path name that's duplicate of TEST_DIR
Date: Fri, 10 Mar 2017 09:44:50 +0200	[thread overview]
Message-ID: <CAOQ4uxjB_HMVsUD3XU+kFcc2CwB8P0QC52pRp+kjKShKyj1ffw@mail.gmail.com> (raw)
In-Reply-To: <20170310065734.GN14226@eguan.usersys.redhat.com>

On Fri, Mar 10, 2017 at 8:57 AM, Eryu Guan <eguan@redhat.com> wrote:
> On Fri, Mar 10, 2017 at 11:52:40AM +0800, Eryu Guan wrote:
[...]
>> > > Are you planning to keep my patch as is or drop the else statement in
>> > > the filters?
>>
>> I was testing your attached patch as is, if you can send a formal patch
>> with the else statement dropped that'd be great.
>
> Your test patch worked fine in my testing. I tested the following
> configs with both reflink enabled xfs (which could cover the most test
> cases) and overlayfs on top of xfs (both old and new config)
>
> # kvm-xfstests config
> TEST_DEV=/dev/sdc1
> TEST_DIR=/sdc1
> SCRATCH_DEV=/dev/sdc2
> SCRATCH_MNT=/sdc2
>
> # djwong config
> TEST_DEV=/dev/sdc1
> TEST_DIR=/mnt
> SCRATCH_DEV=/dev/sdc2
> SCRATCH_MNT=/opt
>

Cool. I sent you the formal patch without the else statement.
It passed my kvm-xfstests run with new overlay config (along with your patch)

  reply	other threads:[~2017-03-10  7:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08  7:26 [PATCH] generic/411: change sub-path name that's duplicate of TEST_DIR Zorro Lang
2017-03-08 10:01 ` Amir Goldstein
2017-03-08 11:51   ` Eryu Guan
2017-03-08 14:26     ` Amir Goldstein
2017-03-08 14:59       ` Zorro Lang
2017-03-08 16:32         ` Amir Goldstein
2017-03-09  3:11       ` Eryu Guan
2017-03-09  9:59       ` Eryu Guan
2017-03-09 11:28         ` Amir Goldstein
2017-03-09 13:16           ` Amir Goldstein
2017-03-10  3:52             ` Eryu Guan
2017-03-10  6:57               ` Eryu Guan
2017-03-10  7:44                 ` Amir Goldstein [this message]
2017-03-08 13:15   ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxjB_HMVsUD3XU+kFcc2CwB8P0QC52pRp+kjKShKyj1ffw@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.