All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
	Miklos Szeredi <miklos@szeredi.hu>,
	overlayfs <linux-unionfs@vger.kernel.org>,
	fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH 0/2] Another overlay test for online inconsistency detection
Date: Wed, 9 May 2018 19:20:13 +0300	[thread overview]
Message-ID: <CAOQ4uxjj1MCCvEpG-p2vr8iAsMesmUFEadM0bdCePGC9GN150g@mail.gmail.com> (raw)
In-Reply-To: <20180509153917.GI8373@desktop>

On Wed, May 9, 2018 at 6:39 PM, Eryu Guan <guaneryu@gmail.com> wrote:
> On Fri, May 04, 2018 at 12:41:29PM +0300, Amir Goldstein wrote:
>> Eryu,
>>
>> Originally, I wrote overlay/049 to test online inconcsistency detection
>> feature, which I wrote as a sub feature of NFS export, so the initial
>> version of the test required and eanbled NFS export.
>>
>> Then, at some point, the test started to pass without NFS export enabled,
>> which was a by-product of another fix for inotify I did around the same
>> time. So the test got merged without requiring NFS export, but with said
>> fix commit on next branch.
>>
>> On a recent discussion with Vivek, I realized that there was another
>> "by-product" inconsistency detection introduced by the same fix commit
>> and not covered by overlay/049.
>>
>> The variant overlay/059 checks for this case of malformed multiply
>> referenced origin files. I wrote the test to support upcoming 'metacopy'
>> feature by Vivek, so it requires and enables redirect_dir, which is
>> harmless otherwise.
>>
>> I tested overlay/059 on several old kernels. The results are:
>> - notrun on kernel < v4.10, before "redirect_dir" feature
>> - pass on kernels < v4.12, before "origin" was introduced
>> - fail on kernels < v4.16, before the fix commit
>> - pass on newer kernels
>
> Thanks a lot for the detailed background information and test status!
>
> BTW, I noticed that you still send patches to address eguan@redhat.com,
> I'm not using thaa address anymore, please send to guaneryu@gmail.com
> instead :)
>

Right. Forgot to update my scripts.
Should be good now.

Thanks,
Amir.

      reply	other threads:[~2018-05-09 16:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04  9:41 [PATCH 0/2] Another overlay test for online inconsistency detection Amir Goldstein
2018-05-04  9:41 ` [PATCH 1/2] overlay/049: update fix commit id Amir Goldstein
2018-05-04  9:41 ` [PATCH 2/2] overlay: test multiple origin references to the same lower file Amir Goldstein
2018-05-09 15:39 ` [PATCH 0/2] Another overlay test for online inconsistency detection Eryu Guan
2018-05-09 16:20   ` Amir Goldstein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxjj1MCCvEpG-p2vr8iAsMesmUFEadM0bdCePGC9GN150g@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.